From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9C7C77B7C for ; Mon, 17 Apr 2023 16:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjDQQ4j (ORCPT ); Mon, 17 Apr 2023 12:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjDQQ4h (ORCPT ); Mon, 17 Apr 2023 12:56:37 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F5A58F for ; Mon, 17 Apr 2023 09:56:35 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id sz19so8879031ejc.2 for ; Mon, 17 Apr 2023 09:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681750594; x=1684342594; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j6xy1GRSFsuZ+PUMKZhMiAkv+GOex/u5ih/pKCbE4AI=; b=aEkK/1YUBw8jtrWo6WZt3CuhZH9zX7ObDmfa3cgWfykPpUiWO+FGtH181RItSorpMS cedPHx70AyB3nPqJsdwiSF3jtD/CPTZDk2SPZfzbn97XbcDtLs9QwHOgJqtIwrxLPOL0 uaVOOOaJ08FcNZpr9RTjhgxWVA9V62J012YtaXcHdqiZChvwtUd9NZTZ6z0ZFOSzDlDs BeL85nuDcRg/5a11MlbkI38AVULRjAQH1e0bX1MJYZfLBXKDnlRxI3GHETnWe6llpWZz pkppo9SHe4Tps9RtV6DDcjPiHHu+LjKK1pJqYv/vdZn9WO61l+wpKpfNgnrcQpEt+zy3 VdfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681750594; x=1684342594; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j6xy1GRSFsuZ+PUMKZhMiAkv+GOex/u5ih/pKCbE4AI=; b=i7FeL5OyjmRFLNMQ8YkF0tKjVG61whTdeLKaWlalH0e4J4mx/JomroQuD1QZtN72N2 QUi/5wVVc05yzoeJHU56FcOhpIcvAFNHoUThE+fquPhwTTpufSfl2egJ4HxHj2acmNRV 9jzpQHEWKx7snO1bxgCnLh0vQ6PtnovQTTBmS/7QnxbbyIyQXM+erGWtln9+4NXfVRCG F7L8OSYRFJ6JW4Rv9lk2reSLsKeVWiT6nD7o+RwL4gbCSrjE9i/VTlQqT2AIZWzByaOi zdIEpdzziuOhOd3S1w3+oMOEMWM6PNg7QA4Urx6KY97fSbIqx9I27iEt23tflwZpwF6k QTrg== X-Gm-Message-State: AAQBX9exb19q3oPyP1lbaYEE3/1iiV0VMh2suOBpa+i2NPY4IJ7X1yvl X/JyweK3dNhuHC8Mh9FG6oBgFapAGLmcY2ZuXVSOzw== X-Google-Smtp-Source: AKy350bmAI+i0j9qkS9nhkX8WPcUqNIoUyi4MPQ2z+q5+QxDAbXuUzl1NiAl56xYusPQLgC9wkQAEQ== X-Received: by 2002:a17:906:5384:b0:94e:ffcb:b15d with SMTP id g4-20020a170906538400b0094effcbb15dmr6061973ejo.71.1681750593754; Mon, 17 Apr 2023 09:56:33 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:96aa:60eb:e021:6511? ([2a02:810d:15c0:828:96aa:60eb:e021:6511]) by smtp.gmail.com with ESMTPSA id l8-20020a170906414800b0094fbb76f49esm353631ejk.17.2023.04.17.09.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 09:56:33 -0700 (PDT) Message-ID: Date: Mon, 17 Apr 2023 18:56:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v12 1/4] dt-bindings: i2c: Correct interrupt support Content-Language: en-US To: Patrick Rudolph , Peter Rosin , Laurent Pinchart Cc: Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230417104801.808972-1-patrick.rudolph@9elements.com> <20230417104801.808972-2-patrick.rudolph@9elements.com> From: Krzysztof Kozlowski In-Reply-To: <20230417104801.808972-2-patrick.rudolph@9elements.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/04/2023 12:47, Patrick Rudolph wrote: > Only some of the PCA954x compatible ICs have interrupt > capability, but the binding advertises it on all ICs. Subject: Add proper prefix for the device. You are not correcting interrupt support in all I2C controllers. > > Sync the dt-binding with the driver and only advertise it on: > - nxp,pca9542 > - nxp,pca9543 > - nxp,pca9544 > - nxp,pca9545 > > Signed-off-by: Patrick Rudolph > --- > .../bindings/i2c/i2c-mux-pca954x.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > index 9f1726d0356b..93ffa67d0d9c 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > @@ -63,6 +63,24 @@ required: > - compatible > - reg > > +allOf: > + - $ref: /schemas/i2c/i2c-mux.yaml# Duplicated part. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof