From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B4983E5ECF for ; Mon, 15 Jun 2026 12:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525385; cv=none; b=Ru6HXhZ1q06g8ipp3+ruMeeGE0ZnqB3co4B/PpTJrsnT0nouTFtbWTSMA0ymlfb3MGhfgkvwgnFn8t6YAeUld8jCn5lFjT9z0CThRPhpKitVANB0iZfMUsOR3Gn8VaDjai7Mz+WXSjPLL4yfqSHr6DYcIGye+uMIAfH4HjsAqWQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781525385; c=relaxed/simple; bh=XtO4iL05RYNP4mvns6ypWCaRum1PPnfMKppbq+fRd14=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FdeOoaobpZgbuAWrgUEdru3VKRef72aTv5LaenLFk951cwl3xwpkx9Kzj1xV+Vyji9fg96GH4SA06T2HzpOYlaPlwNC2NBfg2AsOYrReF8rtAys7l2dOP/jhsGrM47D5IuFLds2Kl/YkmJwHaIJOWzre2dwyyYasPqDouCSi3cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YC9mLsns; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V6Z+OMh7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YC9mLsns"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V6Z+OMh7" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FAoQSP2481259 for ; Mon, 15 Jun 2026 12:09:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xdDWVg67DosG+2rRxU7O5SM+Su31reMdjiRDO/KtZV8=; b=YC9mLsnsBWNLnUza 35EprpEWuy4EUuPlGtPkw2oBFoFTHspuHoZZGLy+poR1XlrffUCaYeFhv2D786qt JgdMWOwo468rj5TzwhTugvM9yKS+3YDCasvScg852S2ZnDRoWSqwGIB4eqaFWODO XDdyu+aTtiH831iXuaIyCxqvqqbGCWdLolI2FydcVPag53wvAizQq7WW2PuRxtmo gHWeNmkzmjl3v1d+zdnrhY7OVQuBEgL39gsyAHamPqa1M2FBcigBsJENm1OWDdjq wFf//cIKuiCyylcFpa/CoWNwaZnvY/bT5N6mkuJ/aeQ4QELgQyKtsBxRs/47SMmd CKe9zA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ete980r4q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 12:09:42 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8d37bc61dc2so9856836d6.2 for ; Mon, 15 Jun 2026 05:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781525381; x=1782130181; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xdDWVg67DosG+2rRxU7O5SM+Su31reMdjiRDO/KtZV8=; b=V6Z+OMh7/NyoXjM1PVtEKa6yg5DPvkI7C8RcgVxnO+0Myn5YE1QCUEkObbQtvnW7D/ CQnip+0hmnJzrTDt/kyUi7i5rKm+3p3mSPrO+163zxWV8RhdH7/1vc/JXKaVSUHNqyYb o0ehtmrVDBuJipeNg5opJmperr7tQtD3++0bxKQOcnkD0KDSkCZUIF24KvsIiyHALQTj A/JIt4KNH0i/WrUUZb53Ddpm9/KJuU1CZS/poRiphNdmog0UfKzWw9E8kZnlhXIUFN5q JwYLXQ1Z2EtfqtItlcz5kV5yPMYNFny4B28XiERm8Ihp2v0CJFihcCqKVcakWnpoVkbB 8efg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781525381; x=1782130181; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xdDWVg67DosG+2rRxU7O5SM+Su31reMdjiRDO/KtZV8=; b=bvQNK29V2deExSH2aMh9Xwi4lUULCWPJavvGSuAKYaaOrtsBKPClvLfsK/5UU+omE+ hXbTi9etoYup6/lCEKAZCUhY5zS3QUjVathUegvfxYB1SZpEso2QjEIxWL1ybD4FOsoB hTT0Hc9JsiwQ8yzivte0vchQhZ6BZlKpVH4jsvpqsvTl26F4cXzto0rLblClSn/Oen52 1TNf0cZe1VI6c/rfSZYdy4kd1lLq/Tgh8Pw3/2H7f5jfJfBezwZojmrNBMxe1TEsuAVJ xOpHY7lOPDCTQ4iwFUzdBOzHfHK9Z1kXs3XFBIvPxQYnQ7/aNEo3CteMAgglE8lHaiWm vKQw== X-Forwarded-Encrypted: i=1; AFNElJ+8u4gmniUB7Blqb0HyiA6/lmeYwD07CQvRFGiyCAll2iy9H45bfbHf8NG5EGWXVuCeKqZkgR5QlMcpWqs=@vger.kernel.org X-Gm-Message-State: AOJu0YzCzmjO0PDNNhJWQ83+T+98CnVXwKd33YjFVMWan1fq4QMM8CJw JEUStigAyf5xmx1BAZyykhc6FwjTzkOrjHp+i7Bhhd81mSYafNDl7PMQO+sC47fLIv+G5NAH0VF go6UUPVVduwgAm9aXR/unHZcK5xLgk+Y+FJMtoyRXFSTcttBMxE2yHw8DzWG+LdTcAjZbdiHRH3 A= X-Gm-Gg: Acq92OF3DfM52IRPwZUgUY4lwwIXA44Ab4UgZulbwSuK09NjXNWGt+HqNwY6eCdu8kZ YvK1Yvg03xO7uAL+EU8u4APoupvYXZ5MyvSGavClc/Yf3gloKApgtnrdCUFELhQ/OiUL6HPZAWz wIZI9BGS8xZV8Kamkqw8V8U1OcYF6s0jfzLxPu2tKJSDrKdIjiwZ1G0k9XfMNOUpmSFivmv9gQ7 EaHEZ594URMTL6VNrG1mmeiMhv7s5/2QKw6ewm3RsX6i//xYG8niqFmdHbXrBkUlUKJrleLKf0Q kf5a1S+0MnmlSbkpwENTYb5olvm91GxS+4yvldAb0D/M5hpAtUh97PZ/nnPXH0rOdisVBh+TOlW ADqVCPbQPIRPqUunsb8JOpBmOZWkwq5Sh5lfXZERCPM9mhg== X-Received: by 2002:a05:620a:2892:b0:8f3:5988:f97c with SMTP id af79cd13be357-9161bc9eeabmr1284100885a.3.1781525381214; Mon, 15 Jun 2026 05:09:41 -0700 (PDT) X-Received: by 2002:a05:620a:2892:b0:8f3:5988:f97c with SMTP id af79cd13be357-9161bc9eeabmr1284095285a.3.1781525380675; Mon, 15 Jun 2026 05:09:40 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6937948fc99sm3452000a12.23.2026.06.15.05.09.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 05:09:39 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 14:09:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Sort pinctrl subnodes by pins To: Luca Weiss , Vladimir Zapolskiy , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260612-kodiak-cam-mclk-v1-0-fd294ff003a2@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=V5tNF+ni c=1 sm=1 tr=0 ts=6a2feb86 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=6H0WHjuAAAAA:8 a=VS-BQLoWTPCgKDwiL6sA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-GUID: KLi3q9Qsv87FVKlJG3vu_k79W1G0NML0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfX0elj4sUOm3cm +iboMkjVo9aDWUM2N/mrl8Vdzmtde4hT/FKHtAsjiYiKuNRhpfOz998lxwK7EbJ3YlQ3RbHcRI5 rtal5vFJ4hZTkZKi9xWdbq8fwLzCMa0= X-Proofpoint-ORIG-GUID: KLi3q9Qsv87FVKlJG3vu_k79W1G0NML0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDEyNyBTYWx0ZWRfXyBQrFi4D8Dqb R4g8WcfhP04ThFgc0zeLZ3rNlpr3erHRXkFWhvT6EWOlt216Mi3CxXqvaQUJuyToHsjqwXeLTID bdW3d6EkCSKKYJyIheJ1XFa8BoXgQUkBI9lcEsRIEb16gYITBm3ChX9PskYpTKL3n+jvRLgbpRI LoSvBRvsfZs2C173TMuSjKmSvILpnz06eOvBC9ZCvIZ14HggyL/osyyZ5T9C3d6XUAg0M9U2pIS kjzLUiK8Gm5buRYBEOMj/Js6ermPnGG65ZvxNvrBDPRweFIl1GHRXi77/yB+YgF2tjdBvdeRgPf QHSHDuckWs79iDVPYy1+mbmdIEtv8POGWvpEa7aXE8xb2S4qoxjawBwFkBuuOA7mApe3W3luqQF RUjx0nqcILP2G6vUcsUOLk3SwGDxT7wvOC9v6ioo3offvp0g3Ah/MEcWoz5VrMydTzHZHei3c2V 56ZdCbSHZTlHwFyxtEQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150127 On 6/12/26 3:46 PM, Luca Weiss wrote: > On Fri Jun 12, 2026 at 2:59 PM CEST, Vladimir Zapolskiy wrote: >> As documented in the "Devicetree Sources (DTS) Coding Style" document, >> pinctrl subnodes should be sorted by the pins property. Do this once for >> kodiak.dtsi so that future additions can be added at the right places. >> >> No functional change intended, verified with dtx_diff. >> >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/qcom/kodiak.dtsi | 1382 +++++++++++++++++----------------- >> 1 file changed, 691 insertions(+), 691 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> index fa540d8c2615..62daef726d32 100644 >> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi > > > >> + qup_uart12_cts: qup-uart12-cts-state { >> + pins = "gpio48"; >> + function = "qup14"; >> + }; >> + >> + qup_uart12_rts: qup-uart12-rts-state { >> + pins = "gpio49"; >> + function = "qup14"; >> + }; >> + >> + qup_uart12_tx: qup-uart12-tx-state { >> + pins = "gpio50"; >> + function = "qup14"; >> + }; >> >> I understand and support the intention to keep this change non-functional, >> but this pad "gpio50" is for qup16 also, right? > > According to my QCM6490 data sheet, GPIO_50 has these functions: > * UART for qup14 (OK) > * SPI for qup14 (OK) > * SPI for qup16 (no pinctrl) "no pinctrl" meaning "not defined in the upstream dt as of today"? > >> >> Similarly pads "gpio54"/"gpio55" for qup14 function, "gpio62"/"gpio63" >> for qup16 function, I find all of these are missing on the original list. > > GPIO_54: > * UART qup15 (OK) > * SPI qup15 (OK) > * SPI qup14 (no pinctrl) > > GPIO_55: > * UART qup15 (OK) > * SPI qup15 (OK) > * SPI qup14 (no pinctrl) > > GPIO_62: > * UART qup17 (OK) > * SPI qup17 (OK) > * SPI qup16 (no pinctrl) > > GPIO_63: > * UART qup16 (?) > * SPI qup16 (lane 3) (?) > * SPI qup16 (lane 5) (?) > > But the GPIO_63 looks weird, is the data sheet wrong?! Where would > UART_RX of QUP1 SE7 go? Maybe it should be UART qup17 and SPI qup17 and > then SPI qup16 ?? GPIO63: QUP1_SE6 SPI_CS2 QUP1_SE7 UART_RX/SPI_CS0 Konrad