From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbeEXF3v (ORCPT ); Thu, 24 May 2018 01:29:51 -0400 Received: from vps01.wiesinger.com ([46.36.37.179]:38280 "EHLO vps01.wiesinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbeEXF3u (ORCPT ); Thu, 24 May 2018 01:29:50 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 wiesinger.com w4O5TghU006276 Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26 To: Florian Fainelli , Andrew Lunn Cc: linux-kernel@vger.kernel.org References: <3bdb712d-38bd-e2ca-63cf-8406a7b5689d@wiesinger.com> <20180522201632.GB4396@lunn.ch> <59d6b55f-d50a-063c-90a9-31a758e01383@gmail.com> <76c3f5ec-0ab2-c06d-98e8-277284bb1a8e@gmail.com> <779f2be3-3e74-e650-5240-efaf1003d77c@wiesinger.com> <4f7c5173-019d-ba0e-70b3-addf64a6a9fa@gmail.com> <53c9272a-0e1a-e8fb-a3e4-b4e23e77be10@gmail.com> From: Gerhard Wiesinger Message-ID: Date: Thu, 24 May 2018 07:29:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <53c9272a-0e1a-e8fb-a3e4-b4e23e77be10@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After some analysis with Florian (thnx) we found out that the current implementation is broken: https://patchwork.ozlabs.org/patch/836538/ https://github.com/torvalds/linux/commit/c499696e7901bda18385ac723b7bd27c3a4af624#diff-a2b6f8d89e18de600e873ac3ac43fa1d Florians comment: c499696e7901bda18385ac723b7bd27c3a4af624 ("net: dsa: b53: Stop using dev->cpu_port incorrectly") since it would result in no longer setting the CPU port as tagged for a specific VLAN. Easiest way for you right now is to just revert it, but this needs some more thoughts for a proper upstream change. I will think about it some more. Ciao, Gerhard