mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Chun-Kuang Hu" <chunkuang.hu@kernel.org>
Cc: kernel@collabora.com, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Jitao Shi <jitao.shi@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rex-BC Chen <rex-bc.chen@mediatek.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
Date: Fri, 8 Apr 2022 10:18:59 +0200	[thread overview]
Message-ID: <ba1d3b7b-9bcf-9c45-c487-91da767b83f5@collabora.com> (raw)
In-Reply-To: <20220408013950.674477-1-nfraprado@collabora.com>

Il 08/04/22 03:39, Nícolas F. R. A. Prado ha scritto:
> The configuration for mt8192 was incorrectly using the output formats
> from mt8173. Since the output formats for mt8192 are instead the same
> ones as for mt8183, which require two bus samples per pixel, the
> pixelclock and DDR edge setting were misconfigured. This made external
> displays unable to show the image.
> 
> Fix the issue by correcting the output format for mt8192 to be the same
> as for mt8183, fixing the usage of external displays for mt8192.
> 
> Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 

Lovely!

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

  reply	other threads:[~2022-04-08  8:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  1:39 Nícolas F. R. A. Prado
2022-04-08  8:18 ` AngeloGioacchino Del Regno [this message]
2022-04-20 12:23 ` Rex-BC Chen
2022-04-22  1:03   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1d3b7b-9bcf-9c45-c487-91da767b83f5@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=airlied@linux.ie \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jitao.shi@mediatek.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®