From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Grant Likely <grant.likely@secretlab.ca>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/4] x86/of: Return consistent error type from x86_of_pci_irq_enable()
Date: Sun, 23 Jun 2024 20:27:29 +0300 (EEST) [thread overview]
Message-ID: <ba1d6bba-847a-f249-72f0-0fd2a0a461eb@linux.intel.com> (raw)
In-Reply-To: <20240621141507.GHZnWK6-r6XEH2a9CR@fat_crate.local>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Fri, 21 Jun 2024, Borislav Petkov wrote:
> On Mon, May 27, 2024 at 03:55:35PM +0300, Ilpo Järvinen wrote:
> > x86_of_pci_irq_enable() returns PCIBIOS_* code received from
> > pci_read_config_byte() directly and also -EINVAL which are not
> > compatible error types. x86_of_pci_irq_enable() is used as
> > (*pcibios_enable_irq) function which should not return PCIBIOS_* codes.
> >
> > Convert the PCIBIOS_* return code from pci_read_config_byte() into
> > normal errno using pcibios_err_to_errno().
> >
> > Fixes: 96e0a0797eba ("x86: dtb: Add support for PCI devices backed by dtb nodes")
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Cc: stable@vger.kernel.org
>
> Any particular reason why this is CC:stable?
>
> I'd say unless you're fixing a specific failure, this should go the normal
> route to 6.11...
It can go the normal route. And feel free to drop Cc stable too but I
don't think it matters much as stable folks will autoselect things
regardless of cc being there or not.
--
i.
next prev parent reply other threads:[~2024-06-23 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 12:55 Ilpo Järvinen
2024-05-27 12:55 ` [PATCH 2/4] x86/pci/intel_mid_pci: Fix PCIBIOS_* return code handling Ilpo Järvinen
2024-05-27 16:14 ` Andy Shevchenko
2024-06-24 17:47 ` [tip: x86/misc] " tip-bot2 for Ilpo Järvinen
2024-05-27 12:55 ` [PATCH 3/4] x86/pci/xen: " Ilpo Järvinen
2024-05-28 12:56 ` Jürgen Groß
2024-06-24 17:47 ` [tip: x86/misc] " tip-bot2 for Ilpo Järvinen
2024-05-27 12:55 ` [PATCH 4/4] x86/platform/iosf_mbi: Convert PCIBIOS_* return codes to errnos Ilpo Järvinen
2024-06-24 17:47 ` [tip: x86/misc] " tip-bot2 for Ilpo Järvinen
2024-06-21 14:15 ` [PATCH 1/4] x86/of: Return consistent error type from x86_of_pci_irq_enable() Borislav Petkov
2024-06-23 17:27 ` Ilpo Järvinen [this message]
2024-06-24 17:47 ` [tip: x86/misc] " tip-bot2 for Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba1d6bba-847a-f249-72f0-0fd2a0a461eb@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®