From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdHJFZs (ORCPT ); Thu, 10 Aug 2017 01:25:48 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:33113 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdHJFZq (ORCPT ); Thu, 10 Aug 2017 01:25:46 -0400 Subject: Re: [PATCH 2/7] mtd: spi-nor: cadence-quadspi: Add support to enable loopback clock circuit To: Rob Herring CC: Marek Vasut , Cyrille Pitchen , Santosh Shilimkar , David Woodhouse , Brian Norris , , , , References: <20170801045434.8733-1-vigneshr@ti.com> <20170801045434.8733-3-vigneshr@ti.com> <20170810001021.ayygkgy6xwnrxghl@rob-hp-laptop> From: Vignesh R Message-ID: Date: Thu, 10 Aug 2017 10:55:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810001021.ayygkgy6xwnrxghl@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 August 2017 05:40 AM, Rob Herring wrote: > On Tue, Aug 01, 2017 at 10:24:29AM +0530, Vignesh R wrote: >> Cadence QSPI IP has a adapted loopback circuit which can be enabled by >> setting BYPASS field to 0 in READCAPTURE register. It enables use of >> QSPI return clock to latch the data rather than the internal QSPI >> reference clock. For high speed operations, adapted loopback circuit >> using QSPI return clock helps to increase data valid window. >> >> Add DT parameter cdns,rclk-en to help enable adapted loopback circuit >> for boards which do have QSPI return clock provided. >> This patch also modifies cqspi_readdata_capture() function's bypass >> parameter to bool to match how its used in the function. >> >> Signed-off-by: Vignesh R >> --- >> Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 3 +++ >> drivers/mtd/spi-nor/cadence-quadspi.c | 8 ++++++-- >> 2 files changed, 9 insertions(+), 2 deletions(-) > > Please separate bindings to a separate patch or patches. > Ok, Will do that in v2. -- Regards Vignesh