From: Vlastimil Babka <vbabka@suse.cz>
To: Harry Yoo <harry.yoo@oracle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] slab: validate slab before using it in alloc_single_from_partial()
Date: Mon, 15 Sep 2025 16:48:52 +0200 [thread overview]
Message-ID: <ba26b2e3-0f90-442d-adba-af04829b0f3e@suse.cz> (raw)
In-Reply-To: <aMghx7WTJP9NHoNe@hyeyoo>
On 9/15/25 16:25, Harry Yoo wrote:
> On Mon, Sep 15, 2025 at 03:55:12PM +0200, Vlastimil Babka wrote:
>> @@ -2825,13 +2821,21 @@ static void *alloc_single_from_partial(struct kmem_cache *s,
>>
>> lockdep_assert_held(&n->list_lock);
>>
>> +#ifdef SLUB_DEBUG
>
> I'm sure you meant CONFIG_SLUB_DEBUG ;)
>
> With that adjusted, looks good to me,
> Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Doh yes, thanks a lot :)
>> + if (s->flags & SLAB_CONSISTENCY_CHECKS) {
>> + if (!validate_slab_ptr(slab)) {
>> + slab_err(s, slab, "Not a valid slab page");
>> + return NULL;
>> + }
>> + }
>> +#endif
>> +
>> object = slab->freelist;
>> slab->freelist = get_freepointer(s, object);
>> slab->inuse++;
>>
>> if (!alloc_debug_processing(s, slab, object, orig_size)) {
>> - if (validate_slab_ptr(slab))
>> - remove_partial(n, slab);
>> + remove_partial(n, slab);
>> return NULL;
>> }
>
next prev parent reply other threads:[~2025-09-15 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 13:55 [PATCH v2 0/6] slab: struct slab pointer validation improvements Vlastimil Babka
2025-09-15 13:55 ` [PATCH v2 1/6] slab: Remove dead code in free_consistency_checks() Vlastimil Babka
2025-09-15 13:55 ` [PATCH v2 2/6] slab: wrap debug slab validation in validate_slab_ptr() Vlastimil Babka
2025-09-15 13:55 ` [PATCH v2 3/6] slab: move validate_slab_ptr() from check_slab() to its callers Vlastimil Babka
2025-09-15 13:55 ` [PATCH v2 4/6] slab: move validate_slab_ptr() from alloc_consistency_checks() to its caller Vlastimil Babka
2025-09-15 13:55 ` [PATCH v2 5/6] slab: validate slab before using it in alloc_single_from_partial() Vlastimil Babka
2025-09-15 14:25 ` Harry Yoo
2025-09-15 14:48 ` Vlastimil Babka [this message]
2025-09-15 13:55 ` [PATCH v2 6/6] slab: don't validate slab pointer in free_debug_processing() Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba26b2e3-0f90-442d-adba-af04829b0f3e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®