From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93270C77B7A for ; Tue, 16 May 2023 07:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231475AbjEPHuM (ORCPT ); Tue, 16 May 2023 03:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbjEPHuH (ORCPT ); Tue, 16 May 2023 03:50:07 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAC13581; Tue, 16 May 2023 00:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1684223401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qKHuxejJ0gYscGISO/Lzq18vk4+b4iOzo6srIsttI8Q=; b=DPG9ROIGCjLeyrplpljQ4YAX1l0ZnPhORRJ6fpBTYqXuRjfrN8DM4fxvjte0yqxnczjIre 2UoUOZOUT6GyFMCi49aKlcljzWX7TgGQh9b8fIVGaCwOA5NJG/CI+PCaI8981caXsONPm/ TkmO2iMhrGoY8qk+QXngBmMa2AAuLu0= Message-ID: Subject: Re: [PATCH v4 5/7] pinctrl: ingenic: relax return value check for IRQ get From: Paul Cercueil To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?ISO-8859-1?Q?Neusch=E4fer?= , Linus Walleij , Wolfram Sang , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Date: Tue, 16 May 2023 09:49:58 +0200 In-Reply-To: <17d04e9b7d76fbc0804dde8e1c4a429d7f19de80.1684220962.git.mazziesaccount@gmail.com> References: <17d04e9b7d76fbc0804dde8e1c4a429d7f19de80.1684220962.git.mazziesaccount@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matti, Le mardi 16 mai 2023 =C3=A0 10:13 +0300, Matti Vaittinen a =C3=A9crit=C2=A0= : > fwnode_irq_get[_byname]() were changed to not return 0 anymore. >=20 > Drop check for return value 0. >=20 > Signed-off-by: Matti Vaittinen Reviewed-by: Paul Cercueil Cheers, -Paul >=20 > --- >=20 > The first patch of the series changes the fwnode_irq_get() so this > depends > on the first patch of the series and should not be applied alone. > --- > =C2=A0drivers/pinctrl/pinctrl-ingenic.c | 2 -- > =C2=A01 file changed, 2 deletions(-) >=20 > diff --git a/drivers/pinctrl/pinctrl-ingenic.c > b/drivers/pinctrl/pinctrl-ingenic.c > index 2f220a47b749..86e71ad703a5 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct > ingenic_pinctrl *jzpc, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0err =3D fwnode_irq_get(fw= node, 0); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (err < 0) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0return err; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!err) > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0return -EINVAL; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0jzgc->irq =3D err; > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0girq =3D &jzgc->gc.irq; > --=20 > 2.40.1 >=20 >=20