From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbdBTCPm (ORCPT ); Sun, 19 Feb 2017 21:15:42 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:34963 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbdBTCPl (ORCPT ); Sun, 19 Feb 2017 21:15:41 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-RL-SENDER: wzz@rock-chips.com X-FST-TO: linux-rockchip@lists.infradead.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wzz@rock-chips.com X-UNIQUE-TAG: <5d4cd06403df0d7f234a335731012be2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/bridge: analogix_dp: Don't return -EBUSY when msg->size is 0 in aux transaction To: Sean Paul , Daniel Vetter , Inki Dae , David Airlie References: <1486978066-5351-1-git-send-email-wzz@rock-chips.com> Cc: Tomeu Vizoso , Mika Kahola , =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Tomasz Figa , dianders@chromium.org, Thierry Reding , Heiko Stuebner , Jingoo Han , Javier Martinez Canillas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org From: Zain Wang Message-ID: Date: Mon, 20 Feb 2017 10:13:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1486978066-5351-1-git-send-email-wzz@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, Could you give some comments for this patch? Thanks Zain 在 2017/2/13 17:27, zain wang 写道: > The analogix_dp_transfer() will return -EBUSY if num_transferred is zero. > But sometimes we will send a bare address packet to start the transaction, > like drm_dp_i2c_xfer() show: > ...... > /* Send a bare address packet to start the transaction. > * Zero sized messages specify an address only (bare > * address) transaction. > */ > msg.buffer = NULL; > msg.size = 0; > err = drm_dp_i2c_do_msg(aux, &msg); > ...... > > In this case, the msg->size is zero, so the num_transferred will be zero too. > We can't return -EBUSY here, let's we return num_transferred if num_transferred > equals msg->size. > > Signed-off-by: zain wang > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index 303083a..5384aca 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -1162,5 +1162,5 @@ ssize_t analogix_dp_transfer(struct analogix_dp_device *dp, > (msg->request & ~DP_AUX_I2C_MOT) == DP_AUX_NATIVE_READ) > msg->reply = DP_AUX_NATIVE_REPLY_ACK; > > - return num_transferred > 0 ? num_transferred : -EBUSY; > + return (num_transferred == msg->size) ? num_transferred : -EBUSY; > }