From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC41C88CB2 for ; Fri, 25 Aug 2023 15:19:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbjHYPS5 (ORCPT ); Fri, 25 Aug 2023 11:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234735AbjHYPSg (ORCPT ); Fri, 25 Aug 2023 11:18:36 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65A7C2121; Fri, 25 Aug 2023 08:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692976714; x=1724512714; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4SuZ5OsPAW5MybHkdMLDB2TIspBmkp3UowO2L8p0FaQ=; b=NlK+mVrHBOZG2iJazMNzV5gut9MuET4PcfpfB9/cf0apXjZeBEbuf2ab roPxNfHGRZTCsHzeuEnhS7nq6YezdvL3FfR8AXBDrx5gtPcohXhlN8x2t ZMqusYALJ2aSNDksjrQaBX4BI90SU31ZT+UiDLCfRl9q7S/2zhKenV+Kw Gs713C1ZSGbmSzK6j0YmRXpWRZceB3FUMty7iNuQhvprPUGmBzaHgIGvz jar/dpgmHiyYdpZiTF4WFF/XjuOY54u+KOyYHdUp+9oc0PvXs+Ku/Q2hB GRZYDxFWqbO4rQtG0iyjjZJ1zh8fsb/6GGs129hJVTFLxN3ZPRlldRm9c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="405732486" X-IronPort-AV: E=Sophos;i="6.02,201,1688454000"; d="scan'208";a="405732486" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 08:18:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="714378664" X-IronPort-AV: E=Sophos;i="6.02,201,1688454000"; d="scan'208";a="714378664" Received: from sbilgin1-mobl1.amr.corp.intel.com (HELO [10.209.78.69]) ([10.209.78.69]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 08:18:32 -0700 Message-ID: Date: Fri, 25 Aug 2023 08:18:32 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] x86/sgx: Describe the parameters of sgx_calc_section_metric() Content-Language: en-US To: Jarkko Sakkinen , linux-sgx@vger.kernel.org Cc: stable@vger.kernel.org, kernel test robot , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Jethro Beekman , Serge Ayoun , Sean Christopherson , linux-kernel@vger.kernel.org References: <20230822102853.15078-1-jarkko@kernel.org> From: Dave Hansen In-Reply-To: <20230822102853.15078-1-jarkko@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/22/23 03:28, Jarkko Sakkinen wrote: > Cc: stable@vger.kernel.org # v5.11+ > Fixes: e7e0545299d8 ("x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202308221542.11UpkVfp-lkp@intel.com/ > Signed-off-by: Jarkko Sakkinen -ENOCHANGELOG > /** > + * sgx_calc_section_metric() - Calculate an EPC section metric > + * @low: low 32-bit word from CPUID:0x12:{2, ...} > + * @high: high 32-bit word from CPUID:0x12:{2, ...} > + * > * A section metric is concatenated in a way that @low bits 12-31 define the > * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the > * metric. Shouldn't we just do: - /** + /* ? This doesn't need kerneldoc comments.