From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 111083537F9 for ; Wed, 4 Mar 2026 16:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772640865; cv=none; b=dP1GLR5xIAjuBTyD3bhFStxRYmMLv8KGMPvKpIC12voM1xm9cIBvaCkD0U7twAYrBfb8hH6Rggh5HugLrDYK4z/BVnLQLmahJoktidFlG3l0m25OkHF4dGJKf5OFkoASQgKyWyIXChNIb4+tF2Lys0tr0ntF4fuSWLXM4zLPiC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772640865; c=relaxed/simple; bh=BJhSI8YyDnYwG/YSLyeauMxJaBwN/UIwFp9AQDNBSvM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZiCe6u+29N5W95j1L+TcdqhOj+Sd2hxtjXvBxz8Ce6xye/JD3I4ecftI1eJjHwUdx9Bs6N24Zn1S4cxOAYrbwtNdaWhegDPuQNAO0fvD6J6rpD9vMXepLxt/G3ngYmvRxkbXHAEdbnf2FOVlpj0UbewcU3U9f0GHm4D+MLkEqwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=s1QZQ+nk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=p71z4Fsc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=s1QZQ+nk; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=p71z4Fsc; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="s1QZQ+nk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="p71z4Fsc"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="s1QZQ+nk"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="p71z4Fsc" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6E23F3F7D0; Wed, 4 Mar 2026 16:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772640861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajoRZChLFPs1F0mUpZ7Ecdp8r2zvsyEaG9QiHQzGOr0=; b=s1QZQ+nk9hFzpc+Lca+K8Qd1w6YLC8vbOxhNVMIjZD3R87/3Kz/Qm/U/Ud1bPZ5DxJzf5Z yU/+1RmTBPYZ8SOnI6pzXIGHQFU9MOuWo4B5gc0hwEJrjGULtKPsftf2bSpX20tnG4HyDI 8BBwLt0r6cg/lPYyFjC3581P9jFAPj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772640861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajoRZChLFPs1F0mUpZ7Ecdp8r2zvsyEaG9QiHQzGOr0=; b=p71z4Fscn/K0+ATuwvNB4jyZPi+cUNzE3GwJjR2Izh728CuNUs/j6YzXuJG0A9OB+IhDyt z9nrYqji6fH84vAQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772640861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajoRZChLFPs1F0mUpZ7Ecdp8r2zvsyEaG9QiHQzGOr0=; b=s1QZQ+nk9hFzpc+Lca+K8Qd1w6YLC8vbOxhNVMIjZD3R87/3Kz/Qm/U/Ud1bPZ5DxJzf5Z yU/+1RmTBPYZ8SOnI6pzXIGHQFU9MOuWo4B5gc0hwEJrjGULtKPsftf2bSpX20tnG4HyDI 8BBwLt0r6cg/lPYyFjC3581P9jFAPj0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772640861; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajoRZChLFPs1F0mUpZ7Ecdp8r2zvsyEaG9QiHQzGOr0=; b=p71z4Fscn/K0+ATuwvNB4jyZPi+cUNzE3GwJjR2Izh728CuNUs/j6YzXuJG0A9OB+IhDyt z9nrYqji6fH84vAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD7D13EA69; Wed, 4 Mar 2026 16:14:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /veKKltaqGkoBQAAD6G6ig (envelope-from ); Wed, 04 Mar 2026 16:14:19 +0000 Message-ID: Date: Wed, 4 Mar 2026 17:13:42 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 1/3] bpf: bpf_out_neigh_v4: Fix nd_tbl NULL dereference when IPv6 is disabled To: David Ahern , Daniel Borkmann , Jakub Kicinski Cc: =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , Martin KaFai Lau , John Fastabend , Stanislav Fomichev , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Jay Vosburgh , Andrew Lunn , Hangbin Liu , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-net-nd_tbl_fixes-v1-0-2b2a274df9bb@suse.com> <20260228-net-nd_tbl_fixes-v1-1-2b2a274df9bb@suse.com> <0b52257d-d557-4f26-9931-34c81ab621bc@iogearbox.net> <20260302171131.28373ccb@kernel.org> <0d7bb5c5-4122-4dc9-b52b-c305591207d1@suse.de> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWELVE(0.00)[26]; TAGGED_RCPT(0.00)[netdev]; MID_RHS_MATCH_FROM(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLrr9ek4ud4f4qwi71m7motjzt)]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[suse.com,linux.dev,gmail.com,fomichev.me,kernel.org,google.com,davemloft.net,redhat.com,jvosburgh.net,lunn.ch,vger.kernel.org]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -2.80 X-Spam-Level: On 3/4/26 4:49 PM, David Ahern wrote: > On 3/3/26 9:49 PM, Daniel Borkmann wrote: >> Maybe the "fix" could be to just switch IPV6 from tristate to bool in >> the Kconfig, and then once net merges into net-next we could deconstruct >> all the helper cruft which makes the late on-demand module loading of >> IPv6 work. > > +1 Maybe I am missing something here, but I believe this won't solve the problem. Even if ipv6 is built-in, it should be possible to pass ipv6.disable=1 during boot and therefore nd_tbl would still be uninitialized, not NULL tho. Thanks, Fernando.