From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D7733B6365 for ; Mon, 27 Apr 2026 10:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287573; cv=none; b=HBSRB3P2blVY1ygbKHkZJuLSr34V7QfK8UCBUw+CtV36XD49TGAkH/WVvwXE6tTm294Rz+qPVszAIgETod6wiSEjEdaRH5eNUSTSwxBvWj++JvF3bm9UjpRWYoiao9En2GMPDdHBRMh9lk1ysPPi2J13ObAYq8AerdA83gqoD4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777287573; c=relaxed/simple; bh=gksHzhz6jM2JMwAGb5E1ibHl4HAsMdO3XrDOeDM6+Ik=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HfLZ51oClyNdse6I5DxhRCtvv5QRZVJG8aac5fK6DsIErv4+cDvAswlDbEWWXl5fPR/f1XrMezG/bncKMahWd1Ucy1NqS1rqrKSwvgmfCQ4gV93kAV5+VVz33FZUwv8726+otR2Hy+x/6XYKF4YQHDjeX/kzHm6E5F+JDWZyleA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n6WcaYDw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eCt98REn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n6WcaYDw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eCt98REn" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63R8TChO4054518 for ; Mon, 27 Apr 2026 10:59:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VkU+JJl/K8cKkgwkX7d5IDmAB4GLCezaNEtXZjr23fQ=; b=n6WcaYDwHAdycMlj sROINfH6SEgOcy1eR4owin/qzupXJxsjr2Le+YObTLfIvlflBSMn9nv+LSlM6Vq8 8zaeEks3hMvrWqbf79nUAuqNb8BYJtcNqrZ5EvxM5ZNDX3JLZFvX4TQZkmL5klpr 5ZL7bCWtMj8tpZS19VCaPUTqS1bMXU9gKzpogAVPlRT9sxmePd36abpWFDe2p1ws HHnDPq+reu2EPATvvgmJtPyxASDiiYPanBjGQVNLpPoTmewyHZVkma5M7mq7+X7e EXgnZUxpkUYnkC3PaId3HgT6wr4hMSEG7pVB+vQc0N0ZcXa0k98NrLRkO1Z1WkIB cjCjXA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drnkxds7m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 10:59:30 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50ffd4f8291so2735441cf.1 for ; Mon, 27 Apr 2026 03:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777287570; x=1777892370; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VkU+JJl/K8cKkgwkX7d5IDmAB4GLCezaNEtXZjr23fQ=; b=eCt98REn9uB+lCzds0/vI02+4c8dFUL7/H6/cprc2H1JNkSJ5EQscNabONy+34o4qb Ug8k7XOzF87NdR8L6I3mDY6GcVRmRayHliGy2ob7hEWLQ1NtEtJGRxAniyvG0YNP7/cY trC9z5hIn4jokcpCHnOrsw45iR+CXR/RJVKZQa1uMGnCj9GMuukqalJp3zyBiYE7sY4Q MpJpqZo41SWE20xsPFmLAJj9n1wJ18xT64XF4WEwhsGp1IOzQ+M5BLrTkxD3kXq/19cJ aTGRPNjsthe4i3D4rcutnprb1qOnvJspVF119L1934g80ZlTdFm7FL14mqem/V6vD7we yZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777287570; x=1777892370; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VkU+JJl/K8cKkgwkX7d5IDmAB4GLCezaNEtXZjr23fQ=; b=qmuPNBBMKOOndBuDwNyYFbJpqSPswoImFktzSsuxodueoDn5i4oJ3BRxTXlecLkuak YBkOtE3hwmGCFr+uj9K6WO12yGXds39Qi1meOG2nHsKe+lW/IXdgnPT8JtYj/IgfDn0f 6+ayOtXlJwmRFZQn1t0J8MHuMuSfh9dtlddPCSw8dm/AAlHwD4wQk421EW2X7OcChSeQ sCfRVOK0wshDNZcF2skdyFdM7whRP6MWsGPe5iFlpiGH4o0teWhRcM60qL6tef315GDp +lFuYcedUj8L1Nj7GJg+MKlKa6Md8oDSwyOYkqB64GxDqxRsbEFbezOy9Yt5YT5DQdig x8ZQ== X-Forwarded-Encrypted: i=1; AFNElJ+aRvWIFaXGnb1ef8awcWgLYU1pq78TsBJH8s10oxJWbeXUbFZVSHb1rmSCQsIz+Z/j5sNNSXj4cmQhZJU=@vger.kernel.org X-Gm-Message-State: AOJu0YxUdFgSHcmY2S2BWZTVPBrApo2kGHFx6sorWVH06kELvA58ZfHM 6HJSYoQI7e17BUrOW16+ydV6r+1Ey5teeBmBTpdlEdPcDb2u4zP7yUxF0agOwXNU0c1a4rjGRtz 57gmS6IgYbI/U2CcuoaJHWtL+P0muE6CwG2SEtzV7qLkBKrGP3w7Rs2+gjsIBtSHEdpc= X-Gm-Gg: AeBDieu85Yj12IMCzmpNouJnEPlbhEPO3hIrawvRfaR2t/pZVpmzrfZyhbZSm3YHidq Tt8wjh+wKvBDulu6lqpVEcD2jNL+Qa+LWdZ3SSdOtfjmQoh6MliR88GkRxcEkir0FLUwYbR4g7H L5p1QxFVuACLLq2lbvaOgFqah0b8Wn29vaKx3TOYZPPf9+WPU66epl85Phf9XHmy0Wpsxrljc6u d5sYjMOWQwSlRJHqDk/r7yw4hRYKPkRQRYxEXCstEp2Yij1pVudMkd3tYSeiUFQOrEbPuBwy/S3 OvD7KjM49ppuNGD3N/oVbD1jj3iOOymk68wuiq32tojSlvNK4UumCzP6JS+LVD3AxzJO7MI/K0t /dNr7gg+2iF+lfZrTORBuR/a0voomC76dTRG0SfY1sFmBMlmxyw2dJLDWKVwEaKdxufyuwFSEHY fHzUf2sZhnvF3j+w== X-Received: by 2002:ad4:5b85:0:b0:8ac:b9e7:a95d with SMTP id 6a1803df08f44-8b0281482dcmr450411606d6.6.1777287569774; Mon, 27 Apr 2026 03:59:29 -0700 (PDT) X-Received: by 2002:ad4:5b85:0:b0:8ac:b9e7:a95d with SMTP id 6a1803df08f44-8b0281482dcmr450411246d6.6.1777287569240; Mon, 27 Apr 2026 03:59:29 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba454d1bf00sm1082130366b.33.2026.04.27.03.59.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 03:59:28 -0700 (PDT) Message-ID: Date: Mon, 27 Apr 2026 12:59:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] phy: qualcomm: qmp-combo: Add support for Hawi SoC To: Ronak Raheja , vkoul@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, gregkh@linuxfoundation.org Cc: dmitry.baryshkov@oss.qualcomm.com, abel.vesa@oss.qualcomm.com, wesley.cheng@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260425070002.348733-1-ronak.raheja@oss.qualcomm.com> <20260425070002.348733-5-ronak.raheja@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260425070002.348733-5-ronak.raheja@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ORV0PkKZnDpByNMI8B5NQgw-unZexnSY X-Proofpoint-ORIG-GUID: ORV0PkKZnDpByNMI8B5NQgw-unZexnSY X-Authority-Analysis: v=2.4 cv=TuPWQjXh c=1 sm=1 tr=0 ts=69ef4192 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=1tJ3z92Lny5kRZNiqYQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDExNiBTYWx0ZWRfX3vSoJ9/qaq8+ N2t86uKvdY7JGcjUHx7wgJzV1n61VzYPfi2DWCqBsb2EzjkyI7+KW8eh0vX6sunEiF/WvZUwtL0 Eqyaol2ZbagScdnvQT7qUMjXQcUFfrHSt4iJdND+3jGSGRD3xdTw5cd1hbqZyvLkqep7IedsKf2 WZThD3wvfAX6Pe5g4C4ro3KnOE7sXqloAr80IYI41q7VIWUZQBGdOWwZhp/tXlJQXA3hocL1ok/ upOXyImD7nDQRIXoIO1YfEqQZITjFbfV31uyzDPUpqPdi7hdHVAJ+mVr0MJtZPZA8vsCQ+pKCv3 8/edFAUQNRx0xiULLhBK2pITebXTiH0i8ZCKEFhyOnolbBO6nRNu/TQWEeBpH1gQRg8xFx4Qk0J IgdGT6wxMP/2REkROP05BwUrg6SK8RmU61m1H9E3SzrTumIYj8Nfm+TCGOmQ1cJ0r52VQXwm1W5 Nad59HXP9fOOBPuCjnQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270116 On 4/25/26 9:00 AM, Ronak Raheja wrote: > Add support for the USB3-DP combo PHY found on Hawi platform. > > The QMP PHY for Hawi uses QSERDES V10 register layouts. Add the required > PHY sequences from the hardware programming guide and new V10 register > header files. Also add a new v10 offset structure to incorporate the new > COM AON register module. > > Signed-off-by: Ronak Raheja > --- [...] > + QMP_PHY_INIT_CFG(QSERDES_V10_RX_RX_EQ_OFFSET_ADAPTOR_CNTRL1, 0x27), > + > + QMP_PHY_INIT_CFG(QSERDES_V10_RX_SIGDET_ENABLES, 0x0c), nit: stray \n above Reviewed-by: Konrad Dybcio Konrad