Re: [PATCH -next] drivers/tty/serial: Add missing clk_disable_unprepare()

[Florian Fainelli <f.fainelli@gmail.com>]

On 6/16/2022 7:58 PM, 'Guo Mengqi' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> Add missing clk_disable_unprepare() when get clk rate fails.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>

Looks about right, can we use the same prefix as the majority of other 
changes:

serial: 8250_bcm2835aux: Add missing clk_disable_unprepare()

and slap a:

Fixes: fcc446c8aa63 ("serial: 8250_bcm2835aux: Add ACPI support")

Thanks!

> ---
>   drivers/tty/serial/8250/8250_bcm2835aux.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
> index 2a1226a78a0c..21939bb44613 100644
> --- a/drivers/tty/serial/8250/8250_bcm2835aux.c
> +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
> @@ -166,8 +166,10 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev)
>   	uartclk = clk_get_rate(data->clk);
>   	if (!uartclk) {
>   		ret = device_property_read_u32(&pdev->dev, "clock-frequency", &uartclk);
> -		if (ret)
> -			return dev_err_probe(&pdev->dev, ret, "could not get clk rate\n");
> +		if (ret) {
> +			dev_err_probe(&pdev->dev, ret, "could not get clk rate\n");
> +			goto dis_clk;
> +		}
>   	}
>   
>   	/* the HW-clock divider for bcm2835aux is 8,

-- 
Florian