From: Lyude Paul <lyude@redhat.com>
To: Jakob Koschel <jkl820.git@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Pietro Borrello <borrello@diag.uniroma1.it>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
"Bos, H.J." <h.j.bos@vu.nl>
Subject: Re: [PATCH 2/2] drm/nouveau/clk: avoid usage of list iterator after loop
Date: Tue, 07 Mar 2023 17:50:30 -0500 [thread overview]
Message-ID: <ba3790cb9f3adcb4f7d3935ce9aa88ecacb3bf7d.camel@redhat.com> (raw)
In-Reply-To: <20230301-drm-nouveau-avoid-iter-after-loop-v1-2-0702ec23f970@gmail.com>
On Wed, 2023-03-01 at 18:25 +0100, Jakob Koschel wrote:
> + }
> }
>
> + BUG_ON(!pstate);
> nvkm_debug(subdev, "setting performance state %d\n", pstatei);
> clk->pstate = pstatei;
We should probably also replace this with
if (WARN_ON(!pstate)
return -EINVAL;
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
next prev parent reply other threads:[~2023-03-07 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 17:25 [PATCH 0/2] drm/nouveau: " Jakob Koschel
2023-03-01 17:25 ` [PATCH 1/2] drm/nouveau/device: " Jakob Koschel
2023-03-07 22:49 ` Lyude Paul
2023-03-01 17:25 ` [PATCH 2/2] drm/nouveau/clk: " Jakob Koschel
2023-03-07 22:50 ` Lyude Paul [this message]
2023-03-07 22:43 ` [PATCH 0/2] drm/nouveau: " Lyude Paul
2023-03-07 22:46 ` Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3790cb9f3adcb4f7d3935ce9aa88ecacb3bf7d.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=borrello@diag.uniroma1.it \
--cc=bskeggs@redhat.com \
--cc=c.giuffrida@vu.nl \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=h.j.bos@vu.nl \
--cc=jkl820.git@gmail.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®