From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752645AbdJMRjP (ORCPT ); Fri, 13 Oct 2017 13:39:15 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:50330 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdJMRjN (ORCPT ); Fri, 13 Oct 2017 13:39:13 -0400 X-Google-Smtp-Source: AOwi7QAYuU9diPbxTLdSSvXWJWFoO49BHtGJsxKP/cgZh0WO7+nPJ6iQjvtp/w2pJzSQvqB8DUgMCQ== Subject: Re: [PATCH v2 5/5] fsl/fman: add dpaa in module names To: madalin.bucur@nxp.com, netdev@vger.kernel.org, davem@davemloft.net Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, junote@outlook.com, linux-kernel@vger.kernel.org References: <1507906212-10076-1-git-send-email-madalin.bucur@nxp.com> <1507906212-10076-6-git-send-email-madalin.bucur@nxp.com> From: Florian Fainelli Message-ID: Date: Fri, 13 Oct 2017 10:39:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1507906212-10076-6-git-send-email-madalin.bucur@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/2017 07:50 AM, Madalin Bucur wrote: > Signed-off-by: Madalin Bucur You should provide a line or two to explain why are you making this change, it is to resolve modular build configurations? > --- > drivers/net/ethernet/freescale/fman/Makefile | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fman/Makefile b/drivers/net/ethernet/freescale/fman/Makefile > index 2c38119..4ae524a 100644 > --- a/drivers/net/ethernet/freescale/fman/Makefile > +++ b/drivers/net/ethernet/freescale/fman/Makefile > @@ -1,9 +1,9 @@ > subdir-ccflags-y += -I$(srctree)/drivers/net/ethernet/freescale/fman > > -obj-$(CONFIG_FSL_FMAN) += fsl_fman.o > -obj-$(CONFIG_FSL_FMAN) += fsl_fman_port.o > -obj-$(CONFIG_FSL_FMAN) += fsl_mac.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_fman_port.o > +obj-$(CONFIG_FSL_FMAN) += fsl_dpaa_mac.o > > -fsl_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > -fsl_fman_port-objs := fman_port.o > -fsl_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o > +fsl_dpaa_fman-objs := fman_muram.o fman.o fman_sp.o fman_keygen.o > +fsl_dpaa_fman_port-objs := fman_port.o > +fsl_dpaa_mac-objs:= mac.o fman_dtsec.o fman_memac.o fman_tgec.o > -- Florian