From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbdFTVmH (ORCPT ); Tue, 20 Jun 2017 17:42:07 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36762 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbdFTVmG (ORCPT ); Tue, 20 Jun 2017 17:42:06 -0400 Subject: Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround To: Zach Brown Cc: andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1497980891-10495-1-git-send-email-zach.brown@ni.com> From: Florian Fainelli Message-ID: Date: Tue, 20 Jun 2017 14:41:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1497980891-10495-1-git-send-email-zach.brown@ni.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2017 10:48 AM, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll. However if the phy uses only > intterupts, the phy will stall, since interrupts are off. This patch > fixes the issue by calling config_intr after resetting the phy. > > Fixes: d2fd719bcb0e ("net/phy: micrel: Add workaround for bad autoneg ") > Signed-off-by: Zach Brown Reviewed-by: Florian Fainelli -- Florian