Re: [PATCH v2] arm64: dts: broadcom: bcm2712-rpi-5-b: add spi0 interface

[Florian Fainelli <florian.fainelli@broadcom.com>]

On 9/4/26 03:54, Gregor Herburger wrote:
> Hi Andrea,
> 
> On Fri, Sep 04, 2026 at 12:33:51PM +0200, Andrea della Porta wrote:
>> Hi Gregor,
>>
>> On 11:24 Fri 04 Sep     , Gregor Herburger wrote:
>>> The Raspberry Pi 5 routes the spi0 of the rp1 chip to the pin header.
>>> Add the rp1_spi0 node and its pinctrl node to the devicetree to enable
>>> the spi interface.
>>
>> Just a nit-pick: in the comment it's stated that the spi interface is enabled,
>> which is not true since rp1_usb inherit status="disabled" from its node
>> definition. This is fine because the user would probably want to enable the
>> spi interface through some overlay, so no need to resend the patch (at least
>> for me), so:
> Indeed. It could be rephrased to:
> 
> 	Add the rp1_spi0 node and its pinctrl nodes to the devicetree to make
> 	the spi interface available.
> 
> @Florian: Should I send another version or do you want to change it yourself?

I used that as the new version of your second paragraph, please let me 
know if I should be making further adjustments.

Thanks!
-- 
Florian