From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE2E53624AB for ; Mon, 1 Jun 2026 06:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780296750; cv=none; b=dF4N/1HnJK7mthiKJZHFJalWSIU+EIKnarSR481dNHJJLjnXj93QnjctT+X9MGRUQfMKTVZb6+F33EwzWPp+z9XnzEfGO81m4kuvv0EKGGFVc1TYxVgWfBT+VHJZfRTRyscM19l7ps3GMqPQ4vVIRTHAM3Y1hVYxSN3n7pPdByI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780296750; c=relaxed/simple; bh=XZpXct3qr36dcgHjb2/rqDwDBavphiOSG42YiqiT71A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iy4OrWFnSEzNhJSMTj5rg1x6K+HwdSi8A4guG6bFRYQU6jFVkDJjW4oN/uIBWsE6xLkaiSonWLAWt8Xbbw6plCiGAGhNrVxCFT+5lVG0Q6HhF9RxE7GVtbo4S/MVGJxPE0tqJZ3+51DJ9ckPaPvvxJ0WSPz14HgIP7zrXwyQSWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jo0Lzogy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aMeGbOuV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jo0Lzogy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aMeGbOuV" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6512PArH1012189 for ; Mon, 1 Jun 2026 06:52:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Iyou3X5eHXmwONgdpxt9PcO5bf2Dompms35djagGuVM=; b=Jo0LzogyHkUG0B30 j+53Q2rYx2xRzmSddxgDAxAFVah7jcfmEzEnxfiuqqvLbhgb3tkOYuxdmKOpBrK/ 8yUjcFdifWXzL7sE/ajeDXsrv/xNBNx/jwVfQDKkZ4mcYYNeZgyaY4mu2VhTA91N sPmC7pzTCT2UzBicIeGr63WfdD4S9C2VpQj3nAWatavKUp0DkuLRLcyEqntEL3QB uqWizwKTNTJ1epDWuqs7+UoJxuIjvLi++HQueheh17ptPN39wTZGR+5gsXsAIsgO GJsxefdlA5qEOPD0SoPEdqo12SrnmgmtGvF68FeAwJ7YboraUzTZYOABMhDYFAFW lMM3sQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efr98e31y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Jun 2026 06:52:27 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-84247fed609so395345b3a.0 for ; Sun, 31 May 2026 23:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780296747; x=1780901547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Iyou3X5eHXmwONgdpxt9PcO5bf2Dompms35djagGuVM=; b=aMeGbOuVXPqULmrQLbRTzEQagT+uAozPvyjl3gS589YUrMsKNXKpi6QeR+AhWrgFMc 9W0C1pPOzpdCJWl8WL1/Ch5Ap1UDAqYslUYDkLH05Mzy659HmWh+45wUux5bMR2AzHcS J+0IRc3lgw3eVQXYsPZhH6UKsnRx+K3TeIIiIGobYPuyOA00G4r88U4kQUXxhqAwIG/Z nJj18v5WBqfC4eUUjWK5gZZpaYlCAI1z1qL76gd2mMS8pGW7oOCojV8oeKPME4+bK2lO uID35D16eb9SmCYIRNItc8UHLWDh9ijOxIkejHs8Ed5Z4t2TtwhqspoRNjWly/4Mlcyz mDkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780296747; x=1780901547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Iyou3X5eHXmwONgdpxt9PcO5bf2Dompms35djagGuVM=; b=Ds2SzmInwyIPMLYnSzyrlyBttvJ5IKWRkw31tMedVPW6Jlj3LeXmT1zmZowNlXdkCd gU99FD9a3cFE/4XGz4yNO5whYs6Oj0NEmV5yVOT+SwqrPCC0iXXdTNp2E1YLpa5RJ4OC QvDRk4DBclM9eKjQkFlfwOevRFRTAUg+TVgA2DA5MzBY0o4aDrAW0Fpt+84zauRdWV8L 8Por7cSEyqRVbK7r1QjYV+8URbmgwBhTgpO/1/hyFhct+okwreaDimTl91x0ikfqVPup NWMTzrb+1nAD6dfJbLbK15DiPCny/+KlXkYXAVDrYDcFOIFwdPNh0WTEYpWj+6AEzqds 6hbw== X-Forwarded-Encrypted: i=1; AFNElJ8kOFZlggXugVLtk9KYrMz/GiXLQkeEacB9faWMLdnFAWuEi5IkWCl9b6xcD4CiA9GiuI8L6Lk9DKSCu6M=@vger.kernel.org X-Gm-Message-State: AOJu0YwD2zKjB0rJqeJVhQU5ZPDVKcERpQfxEZjJ22CIfyXTbJG7Wqvg goBiQ61Bbe7POSKGbpTGWqQC0tTKOvwwrof76687ZRKXdMtiugK7Y5wmS+hJdx2e84WK+j0g0Qy 4ZWmDZ2qJrK4Kx4VRkeBSQ1ECYjjZjncm5XJcUiz8ir5JLoBLCbE0ZuzEBiiLnHf5GA== X-Gm-Gg: Acq92OGgHggRLK0gFbb/MsA5S4pvXo2S6D4jT7VLIgdB807VuJcv+x79AvekOsC321C u9DnasP4rYcpXlfLVbx4bwA67cJOsG/aHKHimzfvk4fMUoUx5MTptDnYOLEJ2CQirRLuWcfGf5B 6pvDz3cuPw/PMo8a07jcok+6YRSytgj1HsZbbM2oypfLaTNoRZis6ULz7/iPLxskGWLjVl3ByWO egvYFZjBzfRJapqBT2CjQgsrqL8TDiIL/PChTkO853z3lCvhKva68P2A2pehUhhwSB0qerewUzc MRiMnMz2fH2XJP1JjG1mscPh1sUOp4yrQ7AYS7cqxsuTOhQx0Nhjm4lUFHWgUK8Lm1CAMwTuQBB 8AWZO3hKDT9/pJT5/lSDMirLtKMOOQyNSo6EsTde2xumuI0phQuIkRAca X-Received: by 2002:a05:6a00:71c9:b0:842:2f28:4e36 with SMTP id d2e1a72fcca58-8422f28a598mr6117540b3a.17.1780296746725; Sun, 31 May 2026 23:52:26 -0700 (PDT) X-Received: by 2002:a05:6a00:71c9:b0:842:2f28:4e36 with SMTP id d2e1a72fcca58-8422f28a598mr6117517b3a.17.1780296746151; Sun, 31 May 2026 23:52:26 -0700 (PDT) Received: from [10.217.216.18] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8423bdd217csm4400839b3a.49.2026.05.31.23.52.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2026 23:52:25 -0700 (PDT) Message-ID: Date: Mon, 1 Jun 2026 12:22:21 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] mmc: sdhci-msm: Set ice clk rate To: Abhinaba Rakshit Cc: Adrian Hunter , Ulf Hansson , konrad.dybcio@oss.qualcomm.com, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, pradeep.pragallapati@oss.qualcomm.com, manivannan.sadhasivam@oss.qualcomm.com References: <20260529081045.2877910-1-ram.gupta@oss.qualcomm.com> <20260529081045.2877910-2-ram.gupta@oss.qualcomm.com> Content-Language: en-US From: Ram Prakash Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BaDoFLt2 c=1 sm=1 tr=0 ts=6a1d2c2b cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=yX8Kf8TJ2c6MFKM0v7gA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: 70D1nyT73TDul8kXr2F0zpq6Z4UjDQHr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAxMDA2NyBTYWx0ZWRfX/srvcC8AurfQ RByqAhWmajixTD0d2nlokD23Nhg/QFOtaUO6Rf192n3yZmLncchcIFS2d8HbY/TQ+ZNJgAgbJkP H+I3cdRdLxeZpCQZ7TpUGEPx6+pA4Egkx65FZgkG1KUjujE8tRMa1KTnbRwRuBidZlPT5uZKkYm DbcDxnHp4AQeZ8o3YzVrK4X2b9yoTJ6rxqydZ3dqj8dM/HmF1FJc5S0saAESqO8/bnM9Z38RBBR b8y85NASdRkEBECxBJmB9PcE6Gu2QfA4GSm/KRzgz29sGNZyidJHyiwzg71yaqlOGkIlaeR3rfH I/GlJlAmr1JpuI0V26i440VimW7k1g82gCiffn+910HJKv5nOklP638EAxrpJ6CJPwyxL0i/jMX Vfn5bYUavUfX1jqd5w7fcKyUDa0Y/4SMr7qynq03ip5hJ6WekJKU5n2iVd44WsuABKATQiP25PI tH9pWO4GTjV8LRf5cCQ== X-Proofpoint-ORIG-GUID: 70D1nyT73TDul8kXr2F0zpq6Z4UjDQHr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606010067 On 5/31/2026 10:54 PM, Abhinaba Rakshit wrote: > On Fri, May 29, 2026 at 01:40:45PM +0530, Ram Prakash Gupta wrote: >> Set ice clk rate from sdhci msm platform driver, needed for >> target which are having legacy ice support, and need sdhci msm >> platform driver to set rate. >> >> Signed-off-by: Ram Prakash Gupta >> --- >> drivers/mmc/host/sdhci-msm.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c >> index b4131b12df56..c6a073718aa4 100644 >> --- a/drivers/mmc/host/sdhci-msm.c >> +++ b/drivers/mmc/host/sdhci-msm.c >> @@ -286,6 +286,7 @@ struct sdhci_msm_host { >> /* core, iface, cal and sleep clocks */ >> struct clk_bulk_data bulk_clks[4]; >> #ifdef CONFIG_MMC_CRYPTO >> + struct clk *ice_clk; /* ICE clock */ >> struct qcom_ice *ice; >> #endif >> unsigned long clk_rate; >> @@ -2708,6 +2709,17 @@ static int sdhci_msm_probe(struct platform_device *pdev) >> return ret; >> } >> >> +#ifdef CONFIG_MMC_CRYPTO >> + /* Setup ICE clock */ >> + msm_host->ice_clk = devm_clk_get(&pdev->dev, "ice"); >> + if (!IS_ERR(msm_host->ice_clk)) { >> + /* Vote for max. clk rate for max. performance */ >> + ret = clk_set_rate(msm_host->ice_clk, INT_MAX); >> + if (ret) >> + dev_err(&pdev->dev, "ice clk set rate failed (%d)\n", ret); > > If we keep dev_err(), the failure path should probably go to bus_clk_disable. > However, since boosting the core clock to max is kept optional, > I think dev_warn() is more appropriate here and avoids making this a fatal error. > > Abhinaba Rakshit Here its only setting rate of clk, so no clean up is needed, hence logging is sufficient here, but I agree dev_warn should suffice instead of dev_err. I will update this to dev_warn. Thanks, Ram