From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42B2C88CB2 for ; Mon, 12 Jun 2023 14:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238016AbjFLOWG (ORCPT ); Mon, 12 Jun 2023 10:22:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237809AbjFLOVw (ORCPT ); Mon, 12 Jun 2023 10:21:52 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 393475592; Mon, 12 Jun 2023 07:19:09 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 16FDE5C012F; Mon, 12 Jun 2023 10:17:40 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 12 Jun 2023 10:17:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1686579460; x=1686665860; bh=aP w1HIovDb5iJ4pYiKtcUIbVnbrPXJ4FRPPswedoB04=; b=xlRymHB7jHhqWfKboK BHHqpl7IpRva7ElJrYLJVJASMlzQsmeKtxySzdMSNVsP7eM9qWcHiklcKHH8ldrR e2RbYqLHf7hMXK2baDiAZO8QAuN8vWyOJ8O49CSDjDDJMweOyrGHjLXFwcxKTuQZ Zvdd9KLvcL8IYb/BgzodMn7SnK4Mcd9ujhGQmmts2bhA677S4nrIAi3KxkQXyODo Xt2PNj7lyC/8YcUAO9B4oCGwFBTeTuUMoeVIkvBAJMJvtm/2SHU8d5Max+IyJjB2 79kVFZQZ2LnrhrOI1tsi8dimV3t1/20ootFlgrgxiD16eaWycOj8gyOpkExJoaeG esMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686579460; x=1686665860; bh=aPw1HIovDb5iJ 4pYiKtcUIbVnbrPXJ4FRPPswedoB04=; b=kXCb8NjVNnVfQaNku5rC9rlj+tYCE FdaGelcMW8aCd0ol5JRcA3cj06/McwJhHYP5iMJXHVaraLvikWcfJFL3XuUnPf+J /BYOF70bL9Xx6bqTP9b+vFPtkrV8wKNR6u116mhWK6rNBw6N72HkBNqZWKQcF+BC WvrJTzswEm7G/9qBGrIaMgpVLn4dGH+9DMmf5A4T8axThkoHPPiZBYd+yUvHB68x m/lMiszjdT5Bv6TlfZiAXHYZK66n+mBC9zmsY8mV030VXvRhHM2Y6rQoqHYqJmf0 0sda/0ZdjQiR5SRYwKyR0nvGr0D3iFQP94EhgW7tEynpyckb/20r6kPfg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduhedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 946CDB60086; Mon, 12 Jun 2023 10:17:39 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-492-g08e3be04ba-fm-20230607.003-g08e3be04 Mime-Version: 1.0 Message-Id: In-Reply-To: <7846c69b-5c2d-16d3-6079-d11a60171a69@foss.st.com> References: <20230609120546.3937821-1-arnd@kernel.org> <7846c69b-5c2d-16d3-6079-d11a60171a69@foss.st.com> Date: Mon, 12 Jun 2023 16:17:19 +0200 From: "Arnd Bergmann" To: "Arnaud POULIQUEN" , "Arnd Bergmann" , "Bjorn Andersson" , "Mathieu Poirier" , "Maxime Coquelin" , "Alexandre Torgue" Cc: "Ben Levinsky" , "Tanmay Shah" , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Dan Carpenter" , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote: >> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE); >> if (IS_ERR_OR_NULL(ddata->rsc_va)) { >> - dev_err(dev, "Unable to map memory region: %pa+%zx\n", >> + dev_err(dev, "Unable to map memory region: %pa+%x\n", >> &rsc_pa, RSC_TBL_SIZE); > > What about cast the RSC_TBL_SIZE define instead to ensure to be independent from > the arch and to match with the use of RSC_TBL_SIZE? > > #define RSC_TBL_SIZE ((size_t)1024) I have no objection to that, but I don't see it doing anything good either, as this is a constant value that will always work. Arnd