mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: "Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	"Denys Vlasenko" <vda.linux@googlemail.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Kees Cook" <keescook@chromium.org>,
	"Brian Gerst" <brgerst@gmail.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andy Lutomirski" <luto@kernel.org>
Subject: [RFC/PATCH 2/7] x86/entry/32: Fix an incorrect comment for work_notifysig_v86
Date: Wed,  8 Jul 2015 12:23:59 -0700	[thread overview]
Message-ID: <ba5945e97ff91b5b8f30d8aa550f9fa30220e6e1.1436383168.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1436383168.git.luto@kernel.org>
In-Reply-To: <cover.1436383168.git.luto@kernel.org>

This code path is for returns to user mode only.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 arch/x86/entry/entry_32.S | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_32.S b/arch/x86/entry/entry_32.S
index 90f9e7f6c15e..a36d5df6a749 100644
--- a/arch/x86/entry/entry_32.S
+++ b/arch/x86/entry/entry_32.S
@@ -484,8 +484,7 @@ work_notifysig:					# deal with pending signals and
 #ifdef CONFIG_VM86
 	testl	$X86_EFLAGS_VM, PT_EFLAGS(%esp)
 	movl	%esp, %eax
-	jnz	work_notifysig_v86		# returning to kernel-space or
-						# vm86-space
+	jnz	work_notifysig_v86		# special case for v86
 1:
 #else
 	movl	%esp, %eax
-- 
2.4.3


  parent reply	other threads:[~2015-07-08 19:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 19:23 [RFC/PATCH 0/7] x86_32: Migrate to new entry/exit paths Andy Lutomirski
2015-07-08 19:23 ` [RFC/PATCH 1/7] x86/entry/32: Remove 32-bit syscall audit optimizations Andy Lutomirski
2015-07-08 19:23 ` Andy Lutomirski [this message]
2015-07-08 19:24 ` [RFC/PATCH 3/7] [TEMPORARY] x86/entry/32: Sanity check for work_notifysig Andy Lutomirski
2015-07-08 19:25   ` Andy Lutomirski
2015-07-08 19:24 ` [RFC/PATCH 4/7] x86/entry/32: Finish removing bogus kernel-mode check Andy Lutomirski
2015-07-08 19:25   ` Andy Lutomirski
2015-07-08 19:24 ` [RFC/PATCH 5/7] x86/vm86: Teach handle_vm86_trap to return to 32bit mode directly Andy Lutomirski
2015-07-09 22:41   ` Andy Lutomirski
2015-07-10  1:33     ` Andy Lutomirski
2015-07-10 15:27       ` Brian Gerst
2015-07-08 19:24 ` [RFC/PATCH 6/7] x86/entry/32: Use prepare_exit_to_usermode and syscall_return_slowpath Andy Lutomirski
2015-07-08 19:24 ` [RFC/PATCH 7/7] x86/entry: Remove do_notify_resume, syscall_trace_leave, and their TIF masks Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba5945e97ff91b5b8f30d8aa550f9fa30220e6e1.1436383168.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vda.linux@googlemail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®