From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755317AbcIJJrD (ORCPT ); Sat, 10 Sep 2016 05:47:03 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:56581 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbcIJJrB (ORCPT ); Sat, 10 Sep 2016 05:47:01 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED4: 1 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: mark.rutland@arm.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <8ea2f4b2a0eef84d2992e6be0e134978> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board To: Heiko Stuebner References: <1473498094-16279-1-git-send-email-andy.yan@rock-chips.com> <9389291.9daRDJEYck@phil> <2773686.QIaAl8MGzE@phil> Cc: devicetree@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com From: Andy Yan Message-ID: Date: Sat, 10 Sep 2016 17:46:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2773686.QIaAl8MGzE@phil> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko: On 2016年09月10日 17:45, Heiko Stuebner wrote: > Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan: >> Hi Heiko: >> >> On 2016年09月10日 17:15, Heiko Stuebner wrote: >>> Hi Andy, >>> >>> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan: >>>> PX3 board is designed by Rockchip for automotive field, >>>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI >>>> video input/output interface, WIFI/BT/GPS(on a module >>>> named S500 which based on MT6620), Gsensor BMA250E and >>>> light&proximity sensor STK3410. >>>> >>>> Signed-off-by: Andy Yan >>>> --- >>>> >>>> Documentation/devicetree/bindings/arm/rockchip.txt | 4 + >>>> arch/arm/boot/dts/Makefile | 1 + >>>> arch/arm/boot/dts/rk3188-px3.dts | 337 >>>> >>>> +++++++++++++++++++++ 3 files changed, 342 insertions(+) >>>> >>>> create mode 100644 arch/arm/boot/dts/rk3188-px3.dts >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt >>>> b/Documentation/devicetree/bindings/arm/rockchip.txt index >>>> 6668645..e680105 >>>> 100644 >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt >>>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings >>>> >>>> Required root node properties: >>>> - compatible = "radxa,rock", "rockchip,rk3188"; >>>> >>>> +- Rockchip PX3 board: >>>> + Required root node properties: >>>> + - compatible = "rockchip,px3", "rockchip,rk3188"; >>> Just like to confirm the naming. >>> >>> I read the announcement of both the PX3 and PX5 socs, are the boards >>> really >>> also named only px3 + px5 - same as the socs they carry, or are they more >>> likely to be called px3-evb or similar? >>> >>> The dts themself look fine on first glance. >> We call them px3 or px5 development board in the internal development. >> Of course I can change them to px3/px5-evb if you desire. > I think I would prefer that ... to not confuse socs with boards :-) > All the other Rockchip devboards are always called evb, so I guess it would be > the same for the px3+px5 ones. > > so I guess the compatible would be > - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188"; > Okay, I will send a V2 with that > Heiko > > >