From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0A839D3EB for ; Fri, 10 Jul 2026 06:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783663560; cv=none; b=cOmzkV0cPR1mJsdJbUCDla+WrrPANoycn9RdLhZiWM6iIyyYzMXbRwEBI0bQgPG1M85b+yisRle4Y2hwjqWzZ+bszG8uKKJhIPcJky5Sb1nCa//ejaYLh8Ac4kng610sJku2ZQn/yvdLXMh2Sd2A25ToLoiGg+u36gCCCQrCMu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783663560; c=relaxed/simple; bh=qA+0IJFl9PR5cNXrobQbP+5Im40y4SAZ/GkzfaotHio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aswIe/Cq9oHlgzgEgNwpDK16Vo5twi2EntYMaVmc8XTHrTzYMZyC8ST59BsTIA1U0xVNIXQ1D5dnWrBJxscbEV75gxJlaoZTmCifj0D3rFoqgPFNrTmYT4x1DYzbqZBBKSHrTTG7O3G/vLXrL/qExxTrNzv5Sb7Wv7NUlLS5fGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LkqPmu9u; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bd1w8fu/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LkqPmu9u"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bd1w8fu/" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A3mjQt3898570 for ; Fri, 10 Jul 2026 06:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UrTdROjUR82KO5Tr5hBCL8VlYLfIpeYkN+z7iLoplTc=; b=LkqPmu9uI6rybdfQ UBsmB8vr6FL+6iwVJDY/UdWNNo4lwfEUtKq7x5N52REM20Yv8qyDYvd0fCnFw7V4 Zv3ddZlWmw+gTY5wtM8/IJaQ4zu1NOyQnY6GAL/DjszZ3VOYI9FW80WBQ61CelMq VNGW8CnrayGViHQrMG1B9KypyBf7FdrypZfezlNAk8acsiOTEY/GYB2jo5BYvgRy SgiK0Y217hcoOmghnf80Nic0Toql14QFwSMmRWJWaH/eLujDNXSX04lS9Hf63FKx 9O70Dsg2gCZve2QXRdAgfzC3kFh1knh2BPUooYwDoVrFKumeLs8MuNFwh/VR8LgG ym20TQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4faeg3k1eu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 06:05:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0ab07320so5185461cf.2 for ; Thu, 09 Jul 2026 23:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783663557; x=1784268357; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UrTdROjUR82KO5Tr5hBCL8VlYLfIpeYkN+z7iLoplTc=; b=bd1w8fu/SPVMrO8uT1s3WPKZYf/Nx484Pucxl2IVI/Px8jqie7RrFG7zoHRm82y6up NzNcgPZL+0WF9Dy563ITeszP3bxFmKFs8I/nxnnxxh0Tjn138eXDRsj56WswYUcRbQet wUHMhpPNGVi+Ruc/jJpnvUPr4slRcRdb6yTEZL5MtSvZD8Nvr6GRJIj4bJ3bd2qNC7BP knaayuPRJan5s8YJce03Pl0x43alTc9jRmQr2vhMZcGpSj8Xrnz9BX3py814Tx8jWnrD fjSoTz/OkzxDHIb6KE7SKH4KVX2oiP/XuWuHRXqmbpMZJnn1idY4n9VFkw2+6QveNS2M QoAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783663557; x=1784268357; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UrTdROjUR82KO5Tr5hBCL8VlYLfIpeYkN+z7iLoplTc=; b=aXcNJByZNohskdWnPaF2MIGe+p3LUZX6r8IKtCvl7r2pgrPgS1qb2TpDhfsfoXKIz4 H2hrBuSLGW1pr/SCmd/OU7jR4ck6Vkk0kMRKYrBeekZNx7TJrNxeR+EflFdCLk26g9BZ 8OufSuTnDZ4e/AnoTgeZB96UFMNTPg4XgiRwSvzHSbj7cYpDhQHUuc82REQBEc1uT8Zs gURnAH7tCdLKgvYJ+Y8N4x3iBfPjm8Xf8w2iP9lnO+4sN7c3Ocrg8i5jpV+oCcgVLkJ2 kBfwsTah82Q2/9TCrMWXSlAjQpNvNffs9qu3ikOy+f5424RdnEpEoUoUFXXT5TFAd764 r9fw== X-Forwarded-Encrypted: i=1; AHgh+RpHN0uxMAjPu/6DG+iWU1eJW+l3jmI6J/myahYWNK0Tc/tqcqT1kixQmXEnZhyeZQYSRZZtglYoLRcaqAc=@vger.kernel.org X-Gm-Message-State: AOJu0Yza6kpsqgIfOTnPcJ+Z2SIT3r2ORPrrgjAGQWNDNK42fttL89GL x0tQnW83Va2dJwelTQj50WWQ9T1FLB4g8sCWgCPOWOnSvwhIuLJfD2xdgcTvSPTDsZ9tYe5eVlo Ym9s+/8hUDA6eK+HaWUnLHzkuad3E4a/L0kSGcAio9756CvAE4SgM9VbfnWpIHXk6f/s= X-Gm-Gg: AfdE7ckOjm3+A0F71bEW+jbHgxgayXtxb412HKsLAQtIG6SeEbjlhjzkh8nnpsci9Eq cQi6aeYgZevk4UYxMMEO2yLBEU7N4twUm4e1t5FnU30dJGdHS4GafugHMAmqQlkRE7+OTz6WQH7 M9HvR0QdK+UmCh2X4dMeYlPqCfkjhn+rC3ACGclWRjCWiQf7CIwAhBUO1++BpOjTqrpWXzTii13 JnsqPzIAOOhHF4xwh4SdmNf3hYPYxMIg32/KnpYP2by5im5uhZ2B3Wpk+4vAxdDSokenQMEBTjz Wzv1dUABMf7btfymdkXQCXP3E970yA0tl4BZHEGxKkE1bmV3wY2k15PhzM+QWQwSxcHCXZol+z+ 6cO2CdWpA5MN+Dw02ga/B+pkxvy77yFiLwqgyyU9+VAGNKw== X-Received: by 2002:a05:622a:4290:b0:51a:8c9b:649c with SMTP id d75a77b69052e-51c8b411e7dmr114446511cf.64.1783663557094; Thu, 09 Jul 2026 23:05:57 -0700 (PDT) X-Received: by 2002:a05:622a:4290:b0:51a:8c9b:649c with SMTP id d75a77b69052e-51c8b411e7dmr114446151cf.64.1783663556699; Thu, 09 Jul 2026 23:05:56 -0700 (PDT) Received: from [192.168.0.172] ([49.205.253.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15d6cbadaasm327419266b.46.2026.07.09.23.05.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 23:05:54 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 11:35:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 07/11] arm64: dts: qcom: hamoa: Move Iris IOMMUs to sub nodes To: Dmitry Baryshkov Cc: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Reddy References: <20260709-vpu_iommu_iova_handling-v1-0-72bb62cb2dfd@oss.qualcomm.com> <20260709-vpu_iommu_iova_handling-v1-7-72bb62cb2dfd@oss.qualcomm.com> <3t76ahxtn6e7rhxzxtwhbgq26tdztgfow5kh6lxgtmtr7mucxh@dydqcmawo5g2> Content-Language: en-US From: Vikash Garodia In-Reply-To: <3t76ahxtn6e7rhxzxtwhbgq26tdztgfow5kh6lxgtmtr7mucxh@dydqcmawo5g2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA1NSBTYWx0ZWRfX151xHX+ONMrd PqOQr7l8Mn/7/baN9htnpawI39S51WbSi2fsxDtsml9TAso6y/IIMK93JRhnNazBsC/UMzDmWOs h/fiXjgQQWciNF/PSvju1wdaDzuA1uuXHXjSM+n9iJ+njjmiTXInLncRMmVBkDk9IyOj1RUrSxb NRFJuTQ6XvPKMiSu3RvmS8Jbhe3b8Ny6ME2yqaHIAmcFcDmtgK7YQyHB9jzc+olB90GGrRrwpum vTBPoGj4kc9PMOKsw6ZDjwu5/xn0s3Lr3B2thBejFcW3HugkddWq775ewlJIv2RVG6Jy/x/0hBT eTbXwHTc7pm5sCzz4+KUCCeNbc0TpKTyJ02P+6pnSfyawI3JTxcXamLDJ9zWD4YbWnJrlNUktfh eTnb3tMxgeVY239lTw5izJ9a+fW34d48rkxLHcoGHCjPJf23aBuIesNxuzCZoS0tCBiCmo8oX14 9DMnp/9kHVIRwtVfeMA== X-Authority-Analysis: v=2.4 cv=ZcMt8MVA c=1 sm=1 tr=0 ts=6a508bc6 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=MoCqpHF70WjPNMFBpltNPQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=JeYc7mxaJg17-esw_n4A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA1NSBTYWx0ZWRfX+Wt4umTF+gGi DsCcZxY0VME9dB9ZA0OByiQiP9C/WFvSnr+AgZMCIN5zIwrxHwmFhW885z1ap2fhD4VuPXkTSBB xAEKLqH4dPSCx5fTdjfICbo8tydnqu0= X-Proofpoint-GUID: u9hzL3st1UaH_f7xGZ9y3_cxL63I9hmv X-Proofpoint-ORIG-GUID: u9hzL3st1UaH_f7xGZ9y3_cxL63I9hmv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_01,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100055 On 7/9/2026 6:33 PM, Dmitry Baryshkov wrote: > On Thu, Jul 09, 2026 at 06:05:53PM +0530, Vikash Garodia wrote: >> The Iris VPU has separate streams with different IOVA constraints. The >> non-pixel stream must be limited to the 0-600 MB IOVA range, while the >> pixel stream can use the full IOVA space. >> Using a single set of IOMMU entries for the Iris node does not describe >> these per-stream limits and can allow accesses outside the supported >> range, which may lead to device crashes. One such issue was reported at: >> https://gitlab.freedesktop.org/drm/msm/-/work_items/100 >> >> Add non-pixel and pixel child nodes, move each stream ID to its >> corresponding child node, and add a reserved IOVA range for the >> non-pixel stream. >> >> Co-developed-by: Vishnu Reddy >> Signed-off-by: Vishnu Reddy >> Signed-off-by: Vikash Garodia >> --- >> arch/arm64/boot/dts/qcom/hamoa.dtsi | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi >> index 60f485a4892e062980d01f0b930af4b02f36513c..a2baa2c9f46dc19c3db11dc784358223a035475f 100644 >> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi >> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi >> @@ -657,6 +657,10 @@ smem_mem: smem@ffe00000 { >> hwlocks = <&tcsr_mutex 3>; >> no-map; >> }; >> + >> + iris_resv: reservation-iris { >> + iommu-addresses = <&iris_non_pixel 0x0 0x0 0x0 0x25800000>; >> + }; >> }; >> >> qup_opp_table_100mhz: opp-table-qup100mhz { >> @@ -5435,10 +5439,11 @@ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, >> resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>; >> reset-names = "bus"; >> >> - iommus = <&apps_smmu 0x1940 0>, >> - <&apps_smmu 0x1947 0>; >> dma-coherent; >> >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> /* >> * IRIS firmware is signed by vendors, only >> * enable on boards where the proper signed firmware >> @@ -5446,6 +5451,15 @@ &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>, >> */ >> status = "disabled"; >> >> + iris_non_pixel: non-pixel { >> + iommus = <&apps_smmu 0x1940 0x0>; >> + memory-region = <&iris_resv>; >> + }; >> + >> + iris_pixel: pixel { > > Unused label. Kept it for consistency with others, it can be dropped though. > Also, shouldn't you specify the IOMMU region for this one > too? There is no iova restriction for pixel domain, hence region is not needed there. > >> + iommus = <&apps_smmu 0x1947 0x0>; >> + }; >> + >> iris_opp_table: opp-table { >> compatible = "operating-points-v2"; >> >> >> -- >> 2.34.1 >> > Regards, Vikash