From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9093B8409 for ; Fri, 7 Aug 2026 07:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786088579; cv=none; b=bAvsO7UM3/11543YRDUpIaF7DyY1i/Fu+d9+7MBhtbtn37quvaNKsnV7IoSu9mPbNwGDN9xDB3i1XwLj0+oSlYfbe4y/JtnjdMHgKX9T9w/IXDkaUvWIHK9rD0NbNY53VkesxqBSHbYzzmCRdZBq0mhMheIkiH50zf4Tr3JVTQ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786088579; c=relaxed/simple; bh=BK9hgk6vItfxqnsIoISGzlpDU9uEpG1Eg5FlYdfLaUs=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Fc0wS4081kN0ZuNGXH0rlCW5WllJZNSGAntag66CovkQa7eLZwooKniHpDAOj6Os1v/q+KoLUp7LSuRQlwomGgcWyv7kjNzIIbCSpQrzi7FoyoLzIpjj/Xljm0QaypxJwZ5ZnD5m66YxQxL5WjgIA9AUOH3UoJVdB/5x2+GDPY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=osyx.tech; spf=none smtp.mailfrom=osyx.tech; dkim=pass (2048-bit key) header.d=osyx-tech.20251104.gappssmtp.com header.i=@osyx-tech.20251104.gappssmtp.com header.b=Pt59ZD7v; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=osyx.tech Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=osyx.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=osyx-tech.20251104.gappssmtp.com header.i=@osyx-tech.20251104.gappssmtp.com header.b="Pt59ZD7v" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47fde295992so1466022f8f.0 for ; Fri, 07 Aug 2026 00:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osyx-tech.20251104.gappssmtp.com; s=20251104; t=1786088576; x=1786693376; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ubKtK2cT3F7Eeuk7KUajYtaFkIOEcFfT6C7ChKCXeuI=; b=Pt59ZD7vP5By9u0uJTnNwqigq4pl3tWyO7b9Ri7OnGgTlZf4FY4XG7XwPLIfwoT2Fk cu+JGKL8NITz8w3kvkIG7ii35iextVYxpArc6QXrWfqw12fUikG5Jrsl9gmqnVHAi99e N7E3Vo3iTsvZQgzOKsdR2MWEPixpI6SuBtGmwiLbYZjG5Q2x6UmUWKiLwqGGG2D3Qpwm 7FCX1Hhb2H91Tt27Kr2i6BlrlyMfAUzOidDFqzMmPXdZ308L37iCPJwYgJ2Hua3eeB/D 7KaQp6KdBgzMX93u1bREQFfm+HZGIKV5Nv3c29CbAyRVerD/pfy69Y5Z3g5Biu7cxUK0 hU4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786088576; x=1786693376; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ubKtK2cT3F7Eeuk7KUajYtaFkIOEcFfT6C7ChKCXeuI=; b=OXQOJwXMzZeo29bKLdbocS5zeSfEcTKzdSmX8i1rczpdICpwf6RdI8rDIcRYFbFtIN 6M+Le8xZP4OwqoI4cFiPPHh8RtsRcY0ln9E0h2P7rYjZLsluH0SkqthcqmH8GifFmH3u 8y61Cncn/Rttcm0Mz0DOczR2LHwgE1xprvzsuTxEN10LZsfMmY1rdiPtdpcgbctnMn7N GpEXOWo2ib+awn1HUrnZVJbtSloY+4+jcX85+glMy/2/dXmw00ADC4CLn+K2Pi4VgPTi Al1uPE7kTrkvBRFxHD2x/7csM0RqAXPoukc6SxiVM6cx3gtMXepiwHJ2JJa4kkpC8gnw eBMg== X-Gm-Message-State: AOJu0YwxaxFB6yMmekk6C4UDZ8TedXxmiqbpx7wRpaeo299XTP0bmijN EFY5mY8TYOLEbboli+CXlbRHervZVJpRGOwHyOKYBDi3b6wQqUlR74bYvJhc5larLcMS X-Gm-Gg: AR+sD12+Sgo7gUXS2bmJ33aZGm8mOzjTDfubOQPI1RcEPFWa2j5T0hjw1VmdBOleKJ6 fY3sTQfvo7ACehcaRUJA9mMq9uaeIpKQDdeezV5nAhwa/bvKg6SJfPdAZibHpFJZ0cywfiMCLLj o+hZX6+gOF/VTCBA52REe5yfHVx90+Cyf/PaJRd3siDUespy3Soa+hBNJ15DOVOhG+6RlIKgKy4 jEtYF7y5JBGOhtxtB+1onbUpaRuUOPE/S2G4q82RPxQkJAfy78pdFy/uAWSuWSkRGhoLgxlcVW9 nvKuYacu4c4SOXp4rGS52BJX9RYOFHAyCqK6G5OvHzBbdd+hhfDZVAkv1rJ8egMekMkQFnlqHDw dNudlFhzgLN709Qb22GoRRr7XH/kpogZLIvca3cjXhz8r9d2GicI/lQ804ZbUUJ7TkNQiHg1aWJ 4504FuOk/0fyqVajCVt1IXRS0kW65BqmbwCkGIk8ohtsyy+VRiuBovmdb+fiojB5IDc5a1nYIOE nHy1Eau2soM+DEmPn3UMSvkXikMBCbFYA== X-Received: by 2002:a05:6000:2889:b0:47f:f002:3656 with SMTP id ffacd0b85a97d-47ff86d5b33mr14529837f8f.12.1786088576046; Fri, 07 Aug 2026 00:42:56 -0700 (PDT) Received: from ?IPV6:2001:8a0:f59c:a900:2600:fba1:8d1e:1692? ([2001:8a0:f59c:a900:2600:fba1:8d1e:1692]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021506c0sm3100099f8f.11.2026.08.07.00.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 00:42:55 -0700 (PDT) Message-ID: Date: Fri, 7 Aug 2026 08:42:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: =?UTF-8?Q?Jo=C3=A3o_Peixoto?= Subject: Re: [PATCH 2/6] virt: bao: Add Bao IPC shared memory driver To: Andrew Jones , joaopeixoto@osyx.tech Cc: linux-kernel@vger.kernel.org, ajd@linux.ibm.com, alex@ghiti.fr, aou@eecs.berkeley.edu, bagasdotme@gmail.com, catalin.marinas@arm.com, conor+dt@kernel.org, corbet@lwn.net, dan.j.williams@intel.com, davidmcerdeira@osyx.tech, devicetree@vger.kernel.org, dev@kael-k.io, gregkh@linuxfoundation.org, haren@linux.ibm.com, heiko@sntech.de, jose@osyx.tech, kever.yang@rock-chips.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, maddy@linux.ibm.com, mani@kernel.org, nathan@kernel.org, neil.armstrong@linaro.org, palmer@dabbelt.com, pjw@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com, robh@kernel.org, will@kernel.org References: <20251224135217.25350-1-joaopeixoto@osyx.tech> <20260107162829.416885-1-joaopeixoto@osyx.tech> <20260107162829.416885-3-joaopeixoto@osyx.tech> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/14/26 20:37, Andrew Jones wrote: > On Wed, Jan 07, 2026 at 04:28:25PM +0000,joaopeixoto@osyx.tech wrote: > ... >> diff --git a/arch/riscv/include/asm/bao.h b/arch/riscv/include/asm/bao.h >> new file mode 100644 >> index 000000000000..35658f37e1bd >> --- /dev/null >> +++ b/arch/riscv/include/asm/bao.h >> @@ -0,0 +1,31 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Bao Hypervisor Hypercall Interface >> + * >> + * Copyright (c) Bao Project and Contributors. All rights reserved. >> + * >> + * Authors: >> + * João Peixoto >> + * José Martins >> + * David Cerdeira >> + */ >> + >> +#ifndef __ASM_RISCV_BAO_H >> +#define __ASM_RISCV_BAO_H >> + >> +#include >> + >> +#define BAO_SBI_EXT_ID 0x08000ba0 >> + >> +static inline unsigned long bao_ipcshmem_hypercall(unsigned long hypercall_id, >> + unsigned long ipcshmem_id) >> +{ >> + struct sbiret ret; >> + >> + ret = sbi_ecall(BAO_SBI_EXT_ID, hypercall_id, ipcshmem_id, 0, 0, 0, 0, >> + 0); > Just let lines like these stick out. We have up to 100 chars and these > types of few-char wraps are the most annoying. > > Thanks, > drew Agreed. In v3 the IPC hypercall ID is a shared constant, so bao_ipcshmem_hypercall() now takes a single argument and its declaration fits on one line, and I unwrapped the remaining few-char wraps. For example the RISC-V ecall is now a single line:     ret = sbi_ecall(BAO_SBI_EXT_ID, BAO_IPCSHMEM_HYPERCALL_ID, ipcshmem_id, 0, 0, 0, 0, 0); Thanks.