mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	gregkh@linuxfoundation.org, Benson Leung <bleung@chromium.org>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v2 2/2] platform/chrome: cros_ec_typec: Set partner num_altmodes
Date: Tue, 10 Nov 2020 17:01:04 +0100	[thread overview]
Message-ID: <ba6c1415-457b-1e8d-b604-fad603fe9be6@collabora.com> (raw)
In-Reply-To: <20201110105015.GF1224435@kuha.fi.intel.com>

Hi,

On 10/11/20 11:50, Heikki Krogerus wrote:
> On Mon, Nov 09, 2020 at 10:15:36PM -0800, Prashant Malani wrote:
>> Set the number of altmodes available for a registered partner using the
>> Type C connector class framework routine.
>>
>> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Heikki, would you like to take these two through your tree? It'd help if you can
create an inmutable branch so I can pick other cros_ec_typec patches on top of it.

Thanks,
 Enric

>> ---
>>
>> Changes in v2:
>> - Patch introduced for the first time in v2.
>>
>>  drivers/platform/chrome/cros_ec_typec.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
>> index ce031a10eb1b..743a28426f98 100644
>> --- a/drivers/platform/chrome/cros_ec_typec.c
>> +++ b/drivers/platform/chrome/cros_ec_typec.c
>> @@ -621,6 +621,7 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>>  	struct cros_typec_altmode_node *node;
>>  	struct typec_altmode_desc desc;
>>  	struct typec_altmode *amode;
>> +	int num_altmodes = 0;
>>  	int ret = 0;
>>  	int i, j;
>>  
>> @@ -647,9 +648,16 @@ static int cros_typec_register_altmodes(struct cros_typec_data *typec, int port_
>>  
>>  			node->amode = amode;
>>  			list_add_tail(&node->list, &port->partner_mode_list);
>> +			num_altmodes++;
>>  		}
>>  	}
>>  
>> +	ret = typec_partner_set_num_altmodes(port->partner, num_altmodes);
>> +	if (ret < 0) {
>> +		dev_err(typec->dev, "Unable to set partner num_altmodes for port: %d\n", port_num);
>> +		goto err_cleanup;
>> +	}
>> +
>>  	return 0;
>>  
>>  err_cleanup:
>> -- 
>> 2.29.2.222.g5d2a92d10f8-goog
> 
> thanks,
> 

  reply	other threads:[~2020-11-10 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  6:15 [PATCH v2 1/2] usb: typec: Add number of altmodes partner attr Prashant Malani
2020-11-10  6:15 ` [PATCH v2 2/2] platform/chrome: cros_ec_typec: Set partner num_altmodes Prashant Malani
2020-11-10 10:50   ` Heikki Krogerus
2020-11-10 16:01     ` Enric Balletbo i Serra [this message]
2020-11-11 10:28       ` Heikki Krogerus
2020-11-11 10:56         ` Greg KH
2020-11-11 11:21           ` Heikki Krogerus
2020-11-10 10:49 ` [PATCH v2 1/2] usb: typec: Add number of altmodes partner attr Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba6c1415-457b-1e8d-b604-fad603fe9be6@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®