From: YueHaibing <yuehaibing@huawei.com>
To: Boris Brezillon <bbrezillon@kernel.org>
Cc: <robert.jarzmik@free.fr>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <marek.vasut@gmail.com>,
<richard@nod.at>, <linux-kernel@vger.kernel.org>,
<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH -next] mtd: docg3: Fix a possible memory leak of mtd->name
Date: Wed, 23 Jan 2019 16:54:04 +0800 [thread overview]
Message-ID: <ba7a5252-893c-6fb5-84b4-1ab482738afd@huawei.com> (raw)
In-Reply-To: <20190123094644.23f27c3e@bbrezillon>
On 2019/1/23 16:46, Boris Brezillon wrote:
> On Wed, 23 Jan 2019 14:59:43 +0800
> YueHaibing <yuehaibing@huawei.com> wrote:
>
>> In case DOC_CHIPID_G3, mtd->name should be freed in the
>> err handling path, which is alloced by kasprintf.
>>
>> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/mtd/devices/docg3.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
>> index 60ddc38..cbd25f9 100644
>> --- a/drivers/mtd/devices/docg3.c
>> +++ b/drivers/mtd/devices/docg3.c
>> @@ -1867,6 +1867,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
>>
>> nomem4:
>> kfree(docg3->bbt);
>> + kfree(mtd->name);
>
> Please use devm_kasprintf() instead.
Ok, will do it in v2.
>
>> nomem3:
>> kfree(mtd);
>> nomem2:
>
>
> .
>
prev parent reply other threads:[~2019-01-23 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 6:59 YueHaibing
2019-01-23 8:46 ` Boris Brezillon
2019-01-23 8:54 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7a5252-893c-6fb5-84b4-1ab482738afd@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®