From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B013F9FB for ; Tue, 30 Jun 2026 11:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819581; cv=none; b=tiUJ1zqti4J8e9NmWoXLooWregnsWP2zVoKyLjDPpdKV1kRh4rQKyVC0CmffOt0W+gp32SHkrdAZlnLBqJpL65fI+DysdDEo2+YzDUsFrje23RHSPxu6cOz6/39zjZJobgVbJdf0QkOHjhkgz69Z6DeMHQLb71dxE/VWqGrweyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819581; c=relaxed/simple; bh=dTV3MPnIioxdSrn8J02he+ujmPpSp+0/L58Xubw7F3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r3QXpfVxoE1BEmhl24dIm9XnPtPq6BLLAAMsEVHld6QGrUDa6JoBxvaUkzeDWLogLS7+UmN6Ac6jDXphFnx1lAOmqEwkCpXy2EJyISgAoqNAoFEy5Fdnu+sZRgEg+n6ybinVdiLUmrxfNZa+k46p0fvzfhW7MCPRhlStMECEhg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RHFj5iG0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z2EqDQLV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RHFj5iG0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z2EqDQLV" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9mq5g1611618 for ; Tue, 30 Jun 2026 11:39:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rdbY7oOtbUjem5ySMQM5N8rPfYTeW7okkUfToKfplx0=; b=RHFj5iG0e4+cC7rJ qDaSe6mYVEEvAudWxepD9Woe0NkROI3wLfQ5wZI2KCVVS+apPaeQsBNu84FoCfoA Ab/FZvygn1hfEgculA3RtOuvugirEv8liX8UrGMO7G9t49oRQmBB7N1VPkE553Dp xu7xG00v+YPyhKg18+ZGpPl/F9t53dK1ars0kUkrm9E/QRwHgH/BmcsoFNPOItEb Aln3D81u7ElRWghx9nEQN7/Mk/aoa3JRERwqo4AFRqKT/yA5Ugo/RKPHRp7l6sUs SV7qqt4IPkXG6wgoCBYBheNrq/Ru2Jgs1TA7Kp7yS8u8VEaAbZegDpOni8jKyGTO a6lwJg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f441gtd4g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 11:39:38 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8f0c6ea10e8so4219896d6.2 for ; Tue, 30 Jun 2026 04:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782819577; x=1783424377; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rdbY7oOtbUjem5ySMQM5N8rPfYTeW7okkUfToKfplx0=; b=Z2EqDQLVeUCK3xQJSXg3lxYTUQ1s0Wi+lZypmK87d2j1vfUF4phV1rG+a2qS/d/HNz 2C+VvmOvXOJ6brVaGctkqr7Hi4vC4HqISDaLFHfRlLW5uHy8OUF9KN0YOBTx2BWwhx22 TQ0rCkG3xbmsoggc+rV1kIoIEK60vzr8Yvbhrek7LbnW0CPd2LPB8hkkSgtqqh39i1fz nal7noub1QguEWbmtvdEGJ+luJQcmgjDUsq0b3s11jyE9g9KIu2VOcOGrw5ljjZJbVui B1ZdZskYGs5z/tmJ7yXt1JOKYBHjU2OxODf1zX+TeHiqswo6mXCeuR5JH14BnocdDTpf 36Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782819577; x=1783424377; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rdbY7oOtbUjem5ySMQM5N8rPfYTeW7okkUfToKfplx0=; b=KLvcDg+Fc7FqH4X3gplPZKuuusqNaXfLeuBms1vvYOwq5ycw0fnlbLlkXE3g8gqprx vS9U9N1mR+ZNnIK/FD5+NBNq5QNmSVEusotL0X9AKIWjFBEpuptl8b3TgrFZVaOsXwx1 JPPEIHDAMaiz5r771eEJkmJ3SDQ7d+Vg7ZLW2rXxhROaiPv2fF73ro29IWA4aU1W/04H yjvj9Sgd73rijYBwCKSZhLX62ZoSlSPvhwkaHVslP68yxER2ggG3AHBA/1RN2YseA/S2 0hPYTyP3nSm+dn9/URdS//iulsHJBpfqYzQoqTpIsMgPOaS3vSEOUoDZDEgO/O+NRhoy T4JA== X-Forwarded-Encrypted: i=1; AFNElJ80tdJN1OrNeytekAjPS5vrQACcqWMP0ZSTQmJ5nDdk9pUC7Dp2z7ejdBjAe+BshwIFQk5SM3H4v/YFjzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy56n2QO3Ox/GB1iRSD7gsku5rvBncmOvwhu5kDVVgGOE/bXJOv x06poJkJebq1V4bq5dwX6LP3Z4hMKHEyccXikhikof7JGuLydik7VvKi+ZbD1kiujg0TAEDSVJI QHDtedJLpK4xpf0LmcUd+6aLpQzoFR3K2DcOgKZdKUQnTrbvHAhBOI26JwowSp6zSV1KOPBvRRL s= X-Gm-Gg: AfdE7cmD//J/oJg4owjaeLGcmj2F3cN+8FFPmGUKKDHUDRjYzCn+jQsPvv+Ct8d7TSU 9CkC6Z1j59K7SAC6E9dD6U1ypvxzWQfj8SnlNnNH0AECaig+5u0TAq17odnJ5dITi6sA/49AVhO t9ykxzYb9o77/w8IKK8HyknNXIZ8dP1J94Of86x02o6DA6txUJIqosIOGTHk08YwKwFeZ4bkVvo 6Fl9Jbd8CnVAnTUdDFYgMkZLeZdMx0PeMseTpRxMgascSY90xDqAsJJR5Kc/LekjL6PrgCFAoTT Ns2EiTTbikjpUUchkKFNrgwFHBMfIfubzfK7BFknLWcy0emrKchfhsgWJfvowK9WBV5N4SaCQt9 lxLB+fLnf9cvpZuPYfDLYfqHJImE6YX8efwA= X-Received: by 2002:ac8:7d84:0:b0:51b:f40b:2faf with SMTP id d75a77b69052e-51c1074ddbfmr27483681cf.4.1782819577368; Tue, 30 Jun 2026 04:39:37 -0700 (PDT) X-Received: by 2002:ac8:7d84:0:b0:51b:f40b:2faf with SMTP id d75a77b69052e-51c1074ddbfmr27483481cf.4.1782819576932; Tue, 30 Jun 2026 04:39:36 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f0cb71sm109324966b.39.2026.06.30.04.39.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 04:39:36 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 13:39:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/3] ASoC: codecs: lpass-va-macro: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260629-xo-sd-codec-v7-b4-v7-0-fb37ce457c42@oss.qualcomm.com> <20260629-xo-sd-codec-v7-b4-v7-2-fb37ce457c42@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260629-xo-sd-codec-v7-b4-v7-2-fb37ce457c42@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEwNyBTYWx0ZWRfX09r6y+vpR0yW 8hhgn4lB2gPk64BeFwACMt9nF0geZ/J4JO1z0QifeAwsuMxCFwS3h5DHOOOWg8vcb2lkP053JRb Y46oqtsC4gtyc6JtRTg6GA8b7CN6HJQ= X-Proofpoint-ORIG-GUID: i_IX2xJDArT9gzH-7M4h_KSjvoqku0tW X-Authority-Analysis: v=2.4 cv=F8dnsKhN c=1 sm=1 tr=0 ts=6a43aafa cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=vZmOQDSLvvN2LDkdrM8A:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEwNyBTYWx0ZWRfX/d25EwI20Znn Gk0XrNMmLZ4xsnz0uIJAZfF0oJ95T8XytcZU0f/S5Tb9iO2Tef2tc162p9xga3X+DoghoCwq2q8 X2VdIDkeiwETOZMy3V+FFfBJh469I9VPi9WMNOuJqQg1A6yicwIRwMKxP/apXc8vpEw40blcozt GBKcKM8fCISBrUxHrZxS+O0s9ZxqjxGMjU0F+DWNsEeq9TvMqFVIFxAODeJgxMiguzCfJNVsfBq HyGchSEiWTYG5zkoLu78x9nrN9gmvt7EcSEhHevU1fL1G+swMvOcyE08wwjzQrOd0tKjufgbFS8 4p+TZl6/0QNmdBX++Hj9jGUIM16zoavmZi5Wk3ewfTzORMVerHqXDaw9n1L9VRSYkoWtbisFiw4 K2YQf3L6O7BWjIOsxrV9kvMQG+o8bDGWubMBFAvflOuEpSPSFb7p80gpiB5GIs+nGy4DOKs4gU1 nxUgw6rftvSRyoFMD3Q== X-Proofpoint-GUID: i_IX2xJDArT9gzH-7M4h_KSjvoqku0tW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300107 On 6/29/26 12:05 PM, Ajay Kumar Nandam wrote: > Convert the LPASS VA macro codec driver to runtime PM clock management by > using the PM clock framework. > > Replace manual macro/dcodec/mclk/npl clock handling with PM clock helpers > and runtime PM callbacks, and keep runtime PM references around fsgen clock > gating so PM-clock-managed clocks remain active while fsgen is enabled. > > Set autosuspend delay to 100 ms so PM-clock-managed votes are dropped soon > after idle while still avoiding suspend/resume churn on short gaps. > > Add a PM_CLK dependency to SND_SOC_LPASS_VA_MACRO since this patch > introduces PM clock APIs. > > Improve failure unwind paths: handle runtime PM put errors in probe/fsgen > paths and restore regcache state correctly on resume failure. > > Suggested-by: Mark Brown > Signed-off-by: Ajay Kumar Nandam > --- [...] > +static int va_macro_setup_pm_clocks(struct device *dev) > +{ > + int ret; > + > + ret = devm_pm_clk_create(dev); > + if (ret) > + return ret; > + > + ret = of_pm_clk_add_clks(dev); > + if (ret < 0) > + return ret; > + > + return 0; > } https://lore.kernel.org/linux-arm-msm/84167531-b252-425c-bea5-49992a9c4500@oss.qualcomm.com/ Konrad