From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E182D47ED for ; Tue, 16 Dec 2025 10:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765882564; cv=none; b=nq35crW9zOTX/1bOQ8NJK94tr/GdThn43q/zWfgZRfjsoFcLd+5ZZ6y9zHTqcVeK6zYQfwneEZSM6Ph7Dn33GO0GfwVLcMcVpOJcNmBmSMqgVCfTPiS2x6LHX1WzyD+ZzBPtTm7G3TJaNihkDSdW5E3MIimchMrGHecOq9BxpPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765882564; c=relaxed/simple; bh=H9cZO5APtyb3lyLd/FMer4Qth68kXoMpjMZtASqJfS8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l68T/tG0/C7sj5azoatKRP37j7KDqVmTsZpx2uFjQtTeSEfwIv5UNGh79vwWTQloP91bm9I7Q/2CM4H/s+MOtWlOx1BpI0zy2NYAd46F/v06L4pLDjXxqbOKyw8l+s6JLdWILsoaHYyqruw8Dw7u0DelrZ5HbrWRQros6OKf6Z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b6OHuUgq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WjNLDoFi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b6OHuUgq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WjNLDoFi" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BGAMBal3829526 for ; Tue, 16 Dec 2025 10:56:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oki31/DgsZ6+KzPwIohVz4qvXrFW1AnimENJ+INjaho=; b=b6OHuUgqaipIg7eX o/zFibA/JMxcrYY9VhNBSzvv3mhwSXg746mvpGhlxcSROS8WY0AK11hjXyO5yi4T kfZ/iSpIrksabGpPOGG9K43FIQHb/mqUxs5S1PjBw4UlL0OZnC6ndYNeqOdFtu29 EEKKcae0N1ZqrqWT2urRO/UCkWb0Rjqm8L4YiMTaE3vYbhg76zVwYqwBl8qQHI9H m6DJxVn1rVpeHGTc+zYWQUpS6u6bN71IFc5kNbmTXskRxWanTOaFtAJvzJxSqMQo Jjkng4fq0kk/Nig3dMr+EhTtn6Ie5+YXt56GaACMiEhY8HeCl9witxpvipnu+utz br/WoA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b35m2r55e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Dec 2025 10:56:00 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c904a1168so4086474a91.1 for ; Tue, 16 Dec 2025 02:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765882560; x=1766487360; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oki31/DgsZ6+KzPwIohVz4qvXrFW1AnimENJ+INjaho=; b=WjNLDoFidaO+zAR5duUiPjpPq6BYNiEpCNFpPbiTesprVcOLsFXNgrkzlZ5AibjURc evAoH5yG61B8IV3SclCjjdV6GS/ZCaREff+ljDBOmWFlCcx5AInWJHIFk2RtUBenlR9k ga2hSE809dJFwwvK9HaVL066NY67FrdEx8EmicCt3663t+vJkCGqzzSmeTLvlduq7aGa 66iqVjBf6t32a44PY9bv0V7Sk1fZt4kNPUnV184WdRsbz7eZs9zNs1Ql9A+5PNOGbdpd pQxXpQFSt84e6jKeT0AGAyO6IG0M321sNfePO+NWqT7BxkDplORIx1sj2nHzK+3FZDGY lHpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765882560; x=1766487360; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oki31/DgsZ6+KzPwIohVz4qvXrFW1AnimENJ+INjaho=; b=f/trQrJKw0TxnEY5UGykG5HJ1rKlHHLuFuMTG00n0AxWzWSipzI6WyKRlwXz+5uXXc EcWVuUUkkxK0lCi7FmoYT1xAPOlNDZ7KFYvsLZF6Uq7pX/qqDBAVN69RowXpQq+twJEH k+u0wIsvLKFv1awJVJrOUHC+Apap9x6blBc2L2QDjuEe5kl1oqS3ezmLrd+r+45UjYl7 HjjUbOikCpWcgMeIcERcTj38zhYitcqV+3Og78fROSSqs6hZSt+ekPYBusppSaXTm2ud UQu+MX8XaPazXn4ma5XETKUlR9JwmxWwCOaeYzvtThixQawZMvmdqbKkSZuvSQEsVHGr sEPw== X-Forwarded-Encrypted: i=1; AJvYcCU/O27/9vWDpd84hD36WDkf74Qc0dibY8szcUWCFCuJ4EsWFU/+gt0ybPBwFMrTNqUc4PLKKcpjgM2jUHs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1CXXigY4x+0dmkPqblbR0zMJfkqYPuvB1YaIjrvDrJvh6Lp8b /JkUeKvqvIb3kM0I2/mHad8/jNrvbFIK6uKe+P8kNhxps121Sr+Immj+H8RbXxmNXtoF6JKmDJZ S4VVGNAwzH0rp+T8i9Sy/jImdSvYg7aAANfMp+Zdzx9trVG/GlJhUoxW7msz5/0SLR6I= X-Gm-Gg: AY/fxX42iJnL7WDB43H3TygnNVZEtPM/hH0wVLqNwszqO4tRvjPgs6F1yhk4HW7MxAh l3yS7/9x+/ZpqAIBMrmJvQ0UQscfHCkV2e1/njdkkpsmaAvLb3H2j/QRxcQR2/Hljzv4sYKNfAF 9G/y+tc7PeiL6gKJnbEpdzsr4TiD2Wyl/gEqpfOObzQQOwKiK9AkDMME0eP9zgaGWwGV1TUlsH9 OXbntA1EyHlqg2pPlkZWfmDwOnS3/+cswnYbDoI8fjPSFxEC6etQLiU0OejuAw/WqEozRagLId2 bJKUvUyIarsp+4WtedLiRzdjwsMx3sqzhqghawc4MSd2Qa8bsW0mREXDEK3lP39cNlomyl6Nr+B yVjgH4nRLLP/mT3zOIHjOr0yhdSafE3OU25yiOdc= X-Received: by 2002:a17:90b:2e0c:b0:34a:8e4b:5b52 with SMTP id 98e67ed59e1d1-34abd6cc4ccmr11105472a91.8.1765882559609; Tue, 16 Dec 2025 02:55:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrvhxL/1OIe2D/GBuAobttB7vmHPJWOQlRriLy1UbuK0EuA2bfX1PNz1XLE0mXVVGn4xs3Zg== X-Received: by 2002:a17:90b:2e0c:b0:34a:8e4b:5b52 with SMTP id 98e67ed59e1d1-34abd6cc4ccmr11105452a91.8.1765882559165; Tue, 16 Dec 2025 02:55:59 -0800 (PST) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe294a00sm12076710a91.12.2025.12.16.02.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 02:55:58 -0800 (PST) Message-ID: Date: Tue, 16 Dec 2025 16:25:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tee: fix tee_ioctl_object_invoke_arg padding To: Jens Wiklander , Amirreza Zarrabi Cc: Sumit Garg , Arnd Bergmann , Arnd Bergmann , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sumit Garg , Alexandre Ghiti , Etienne Carriere , Randy Dunlap , op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20251204101730.1036671-1-arnd@kernel.org> <0b061075-ab71-4ac1-93ec-438ddaaec903@oss.qualcomm.com> <2c0d09b7-0d8c-4bf2-a1bd-1dc4b58cd0a8@oss.qualcomm.com> <3aacf997-3a21-4e4b-b6bd-c55c36fb4c74@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=LpGfC3dc c=1 sm=1 tr=0 ts=69413ac0 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=ZhWf7fvzcGQh0Gx6-UQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: Xcx1uN9JfOdE1VclDO4sbYR6_-kubzvd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE2MDA4OSBTYWx0ZWRfX826xXYV7ycEH bZymGp6ByE44XZPNR9dHX9xLv8BsUa5G4U06kxN8kQaOHK4LksrgetXiOR6LmePxh8rA1BV9J/L QKXegAqw8LHgSwvBfP67IJw1ohQy+gzCEafERZ7DeLV5BtiIAFEsSi7sTRwMLc3+eoX/b+q8VSw 0Btj8EKHwFqNQvA3j7npR+2Z/Ngod20mSlhJbakwXtlEPr5j/6wVbrYFcAae+j14FO23/Fbxx5Y JbkYpmX/ANDtss2ckFROKMtuAwDuc2n/S8AstW0rprcPquajwQjOdNSBpiZlRh2KNKrxPFYF0E/ 1l+nYQMXxsv6vT0B8XuS+WZtz7BnyevmcwM7Ad22U8FwNdDAmpWmbuU/PmFa2phjgQRKf1LB1FQ fSKX4waJAPHT2RIw0Q08XPLp1Q7p/w== X-Proofpoint-ORIG-GUID: Xcx1uN9JfOdE1VclDO4sbYR6_-kubzvd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-16_01,2025-12-15_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512160089 Hi Jens, On 12/16/2025 1:18 PM, Jens Wiklander wrote: > Hi, > > On Tue, Dec 9, 2025 at 4:54 AM Amirreza Zarrabi > wrote: >> >> Hi, >> >> On 12/8/2025 11:54 PM, Harshal Dev wrote: >>> >>> >>> On 12/8/2025 5:50 PM, Sumit Garg via OP-TEE wrote: >>>> On Mon, Dec 08, 2025 at 04:24:17PM +1100, Amirreza Zarrabi wrote: >>>>> Hi, >>>>> >>>>> On 12/5/2025 12:27 AM, Jens Wiklander wrote: >>>>>> Hi, >>>>>> >>>>>> On Thu, Dec 4, 2025 at 11:17 AM Arnd Bergmann wrote: >>>>>>> >>>>>>> From: Arnd Bergmann >>>>>>> >>>>>>> The tee_ioctl_object_invoke_arg structure has padding on some >>>>>>> architectures but not on x86-32 and a few others: >>>>>>> >>>>>>> include/linux/tee.h:474:32: error: padding struct to align 'params' [-Werror=padded] >>>>>>> >>>>>>> I expect that all current users of this are on architectures that do >>>>>>> have implicit padding here (arm64, arm, x86, riscv), so make the padding >>>>>>> explicit in order to avoid surprises if this later gets used elsewhere. >>>>>>> >>>>>>> Fixes: d5b8b0fa1775 ("tee: add TEE_IOCTL_PARAM_ATTR_TYPE_OBJREF") >>>>>>> Signed-off-by: Arnd Bergmann >>>>>>> --- >>>>>>> The new interface showed up in 6.18, but I only came across this after >>>>>>> that was released. Changing it now is technically an ABI change on >>>>>>> architectures with unusual padding rules, so please consider carefully >>>>>>> whether we want to do it this way or not. >>>>>>> >>>>>>> Working around the ABI differences without an ABI change is possible, >>>>>>> but adds a lot of complexity for compat handling. >>>>>> >>>>>> This is currently only used by the recently introduced qcomtee backend >>>>>> driver. So it's only used on a few arm64 Qualcomm platforms right now. >>>>>> >>>>>> I think we should take this patch, but let's hear what others think. >>>> >>>> Yeah since it's not an ABI issue on arm64 platforms where QTEE runs, so: >>>> >>>> Reviewed-by: Sumit Garg >>>> >>>>>> >>>>>> Thanks, >>>>>> Jens >>>>>> >>>>> >>>>> I agree. We should take this patch. As noted, there are not many >>>>> clients relying on it yet, so updating the userspace should >>>>> be straightforward. >>>> >>>> You should rather test without any userspace library update to test it's >>>> not an ABI issue. Just for correctness sake, you can update the library >>>> too. >>>> >>> >>> I'll take the time to test it at some point this week both with and without updating >>> the library ABI. >>> >> >> Summit, that was the plan from the beginning, that's why I did not add "Reviewed-by:" >> in the first place. Thanks Harshal for volunteering. > > Are we good with this patch now? > Yes, this is good from our side. Tested-by: Harshal Dev > Cheers, > Jens