From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 756773CF680 for ; Mon, 11 May 2026 09:03:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490205; cv=none; b=bltA6piNGigGYeih53o+CE4fUxTKcaQvypwq9ZiT1+I4stAo/d+JpTgr/V6uiz98TlpsrX5vSxHRj6lpqEkMz8e2lFKa70p5bR9n2jbZO/F05Dw66tp37QzD0un+6Smjy+0eOXfCQDehc8ylWlvo2DqmYPBQK6lHl+55DOg0C4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490205; c=relaxed/simple; bh=jAEaO4JfYvTZh0h5rRrKJYMGQ45gKsBKH3AVbKj8c00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VZBLxbmxN9J/tQpz2JlOm3ZdCYaEsTxKjBvtemybfaPaIxUoY73ya0Hy2xhlxrk2Z2i2ko1oOsQ/xoN1iwXY9m4WKdHNbrMiIM6BWAkQBsMLapaz2RYMl9VhnaGnADAiDJxra1pKOjvYxoYJPZRQ4QxGL59HPeiET9Pi0DwUBEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TkM3RQMS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=P7Hy8+yZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TkM3RQMS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="P7Hy8+yZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778490203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dLzVjPl4JuXWdYl/OMkyXvKlFkDQF6qpB2cxYBp2hXA=; b=TkM3RQMS4xvOuRv3OIo8ziR+afLwc14Ivt/Ed7btIO4qAVbVrfCQoisqZ2QognSDOSs29a kJB/osaM4Y78dyClWqS6eG02yNsZanRoUGrN87KLOIAgDYkHPPoMF8DNtxd7YAWXWAc+Cv DG/lalMq4tTnj8fhG+JOdZyrPSkiHoU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-BkwuNcNtMMGLOodL98jZgQ-1; Mon, 11 May 2026 05:03:22 -0400 X-MC-Unique: BkwuNcNtMMGLOodL98jZgQ-1 X-Mimecast-MFC-AGG-ID: BkwuNcNtMMGLOodL98jZgQ_1778490201 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48e79219704so7729075e9.1 for ; Mon, 11 May 2026 02:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778490201; x=1779095001; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dLzVjPl4JuXWdYl/OMkyXvKlFkDQF6qpB2cxYBp2hXA=; b=P7Hy8+yZYQdGgAV0dBHSK+Xzt6PIK2Wg5HO/iKLPASEKfUR7UCTZtAkd8HDsOn8AwN N/eYqgbA0zPxb5uq4Ww72hhBh/zPhSPlgXJMHbNtb8bVfkGc53nuR1SmKL5kHRxFn5uR ksYgQDLAqbsYiRUk923xeh7ow4jVlPtWF6Nah/nE4aufhzEAFj10dkbSei8DlcZgKOni DuLhpoVmJ8Zii0Wo9sIii1/XNJ7i0raHQ7WbWv5QKRL16tHOb0GxDjTHiRLrqOKkx25b T74BZ9p/aknptbFAqMYTb1SeOqPGUkUK+lfQeRlMEy3fN5eRLgMJO/+2R/pm1ZGbFRa4 16zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778490201; x=1779095001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dLzVjPl4JuXWdYl/OMkyXvKlFkDQF6qpB2cxYBp2hXA=; b=DEOVtbsQRc35X2rXIWry1sWVG3FWGD+ysDbso0t9dKDS6VJcY4hac4bYP1N76JBVIG LGu8i9ZJxzIUEPz6F7YR3Oi9aQOhwyGvhTyHZJnYdHfBQsuQgJKXeWxKeXXD3CbRDuHY 0hSvuCgJIm5LnTREYBjHPNe75PJSwa+aVoSujkI5lWSsWXLqObWbgTjL4Vexvan/KDCG GYDzCUaez9Scu1ZV30TC6dOfkqZ2DR9T/KfXcUrEM0AdvcHkbFSYqekdE/USHvOyOEqa 3shed2z44D2ZZuAowDNXvkdgWBpyVudh9VMNc+tj9nyJGXKkxdKT8irhEY0LrPtxo4LU jMBA== X-Gm-Message-State: AOJu0Yz6y99e8D09fX0UFv8EUUaUd9A/mwgePJzRN75KXCJsbwiJnrQB wOaqSLpZLdl+R8j4fODP+ZGaI+lanYiMnpOrx6FLTgRPh9CXbkiqShChrkjCLPE/lf+lIGoopsU omzUTRDMfxMVbV+PCWtcaeU9vb85aFplfjRBop5vAieltCyT3Lwu7nID1Z1jIx0iidS30RAAz5P +4vidwfLfn6cGs421VhYFrrmBa1qHtyMjZ0LFGbq849ro= X-Gm-Gg: Acq92OEaN9IDcfcyMhT+m0RSpYPzyPiC6+aLK6pNWJUcbPwbRoX7RQEXTe+G9ySYZcJ CwUENlaquI3J9LPDP2qYVaCeEPDbyAHfxUzEaieMwqfzQE68ZdYyNQxk7vDlzBmaN9M3pVMZfnC u06+lTblJYL0HGBVy04i8aCHD/wFOX8eg6nwI4//CNN0TUJPNb2+Tyk7jcqlhoFURF2Cij8pA/y IcKiljT09anMZTK2INcOfXRQI7FlyjlPBHbjgDYsTTS3JIPJ69cyDo5cY8GoPdRqv0sw5BF2vNH 95NlzHJTffdq70be04awuQUq6mSwxBAPlJNEgPrEJAV7Fy/WisgG+N0pZ6NFMJq2hY9NxuJDbQe fYd6Tg3ti2A44VTC8g+Z1+ZlHLtMFdxmE4XEEvfAm X-Received: by 2002:a05:600d:6:b0:488:b749:8482 with SMTP id 5b1f17b1804b1-48e51f21e2amr304831835e9.4.1778490200536; Mon, 11 May 2026 02:03:20 -0700 (PDT) X-Received: by 2002:a05:600d:6:b0:488:b749:8482 with SMTP id 5b1f17b1804b1-48e51f21e2amr304830375e9.4.1778490199227; Mon, 11 May 2026 02:03:19 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6d8d4462sm80127935e9.1.2026.05.11.02.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 02:03:18 -0700 (PDT) Date: Mon, 11 May 2026 05:03:13 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli , "Liam R. Howlett" Subject: [PATCH resend v6 16/30] mm: page_reporting: allow driver to set batch capacity Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Add a capacity field to page_reporting_dev_info so drivers can control the maximum number of pages per report batch. This is useful when the driver needs to reserve virtqueue descriptors for metadata (e.g., a bitmap buffer) alongside the page buffers. The value is capped at PAGE_REPORTING_CAPACITY and rounded down to a power of 2. If unset (0), defaults to PAGE_REPORTING_CAPACITY. The virtio_balloon driver sets capacity to the reporting virtqueue size, letting page_reporting adapt to whatever the device provides. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 --- drivers/virtio/virtio_balloon.c | 5 +---- include/linux/page_reporting.h | 3 +++ mm/page_reporting.c | 26 +++++++++++++++----------- 3 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c index f6c2dff33f8a..6a1a610c2cb1 100644 --- a/drivers/virtio/virtio_balloon.c +++ b/drivers/virtio/virtio_balloon.c @@ -1017,10 +1017,6 @@ static int virtballoon_probe(struct virtio_device *vdev) unsigned int capacity; capacity = virtqueue_get_vring_size(vb->reporting_vq); - if (capacity < PAGE_REPORTING_CAPACITY) { - err = -ENOSPC; - goto out_unregister_oom; - } vb->pr_dev_info.order = PAGE_REPORTING_ORDER_UNSPECIFIED; @@ -1041,6 +1037,7 @@ static int virtballoon_probe(struct virtio_device *vdev) vb->pr_dev_info.order = 5; #endif + vb->pr_dev_info.capacity = capacity; err = page_reporting_register(&vb->pr_dev_info); if (err) goto out_unregister_oom; diff --git a/include/linux/page_reporting.h b/include/linux/page_reporting.h index 9d4ca5c218a0..5ab5be02fa15 100644 --- a/include/linux/page_reporting.h +++ b/include/linux/page_reporting.h @@ -22,6 +22,9 @@ struct page_reporting_dev_info { /* Minimal order of page reporting */ unsigned int order; + + /* Max pages per report batch (default PAGE_REPORTING_CAPACITY) */ + unsigned int capacity; }; /* Tear-down and bring-up for page reporting devices */ diff --git a/mm/page_reporting.c b/mm/page_reporting.c index 7418f2e500bb..006f7cdddc18 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -174,10 +174,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, * list processed. This should result in us reporting all pages on * an idle system in about 30 seconds. * - * The division here should be cheap since PAGE_REPORTING_CAPACITY - * should always be a power of 2. + * The division here should be cheap since capacity should + * always be a power of 2. */ - budget = DIV_ROUND_UP(area->nr_free, PAGE_REPORTING_CAPACITY * 16); + budget = DIV_ROUND_UP(area->nr_free, prdev->capacity * 16); /* loop through free list adding unreported pages to sg list */ list_for_each_entry_safe(page, next, list, lru) { @@ -222,10 +222,10 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_unlock_irq(&zone->lock); /* begin processing pages in local list */ - err = prdev->report(prdev, sgl, PAGE_REPORTING_CAPACITY); + err = prdev->report(prdev, sgl, prdev->capacity); /* reset offset since the full list was reported */ - *offset = PAGE_REPORTING_CAPACITY; + *offset = prdev->capacity; /* update budget to reflect call to report function */ budget--; @@ -234,7 +234,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone, spin_lock_irq(&zone->lock); /* flush reported pages from the sg list */ - page_reporting_drain(prdev, sgl, PAGE_REPORTING_CAPACITY, !err); + page_reporting_drain(prdev, sgl, prdev->capacity, !err); /* * Reset next to first entry, the old next isn't valid @@ -260,13 +260,13 @@ static int page_reporting_process_zone(struct page_reporting_dev_info *prdev, struct scatterlist *sgl, struct zone *zone) { - unsigned int order, mt, leftover, offset = PAGE_REPORTING_CAPACITY; + unsigned int order, mt, leftover, offset = prdev->capacity; unsigned long watermark; int err = 0; /* Generate minimum watermark to be able to guarantee progress */ watermark = low_wmark_pages(zone) + - (PAGE_REPORTING_CAPACITY << page_reporting_order); + (prdev->capacity << page_reporting_order); /* * Cancel request if insufficient free memory or if we failed @@ -290,7 +290,7 @@ page_reporting_process_zone(struct page_reporting_dev_info *prdev, } /* report the leftover pages before going idle */ - leftover = PAGE_REPORTING_CAPACITY - offset; + leftover = prdev->capacity - offset; if (leftover) { sgl = &sgl[offset]; err = prdev->report(prdev, sgl, leftover); @@ -322,11 +322,11 @@ static void page_reporting_process(struct work_struct *work) atomic_set(&prdev->state, state); /* allocate scatterlist to store pages being reported on */ - sgl = kmalloc_objs(*sgl, PAGE_REPORTING_CAPACITY); + sgl = kmalloc_objs(*sgl, prdev->capacity); if (!sgl) goto err_out; - sg_init_table(sgl, PAGE_REPORTING_CAPACITY); + sg_init_table(sgl, prdev->capacity); for_each_zone(zone) { err = page_reporting_process_zone(prdev, sgl, zone); @@ -377,6 +377,10 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) page_reporting_order = pageblock_order; } + if (!prdev->capacity || prdev->capacity > PAGE_REPORTING_CAPACITY) + prdev->capacity = PAGE_REPORTING_CAPACITY; + prdev->capacity = rounddown_pow_of_two(prdev->capacity); + /* initialize state and work structures */ atomic_set(&prdev->state, PAGE_REPORTING_IDLE); INIT_DELAYED_WORK(&prdev->work, &page_reporting_process); -- MST