mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware/dmi: Include product_sku info to modalias
Date: Thu, 22 Oct 2020 21:11:32 +0800	[thread overview]
Message-ID: <ba8ca9b3-da06-4543-6804-ac0d47f26b06@canonical.com> (raw)
In-Reply-To: <20201022144255.667ca9ce@endymion>

Hello Jean,

There are multiple product skus share the same product name, like 
clamshell and 2-in-1 for Latitude series.
Both of them have 3-axis accelerator, but rotation is only disable for 
clamshell model.
Originally, it should be descriminated by chassis_type, but found that 
chassis_type is not trustful.
https://github.com/systemd/systemd/pull/17084#issuecomment-706931881
Therefore, I would like to propose a change to include the product_sku 
for applying customized configuration easier.

Thanks,
KaiChuan

On 10/22/20 8:42 PM, Jean Delvare wrote:
> Hi Kai-Chuan,
> 
> On Thu, 22 Oct 2020 14:40:47 +0800, kaichuan.hsieh@canonical.com wrote:
>> From: Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
>>
>> Some Dell platforms rely on modalias to customize configuration,
>> the product sku can be more specific for the hardware.
>>
>> Add product_sku to modalias for better utilization.
> 
> Do you have an actual use case for this already, or is it a theoretical
> concern?
> 

  reply	other threads:[~2020-10-22 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22  6:40 kaichuan.hsieh
2020-10-22 12:42 ` Jean Delvare
2020-10-22 13:11   ` Kai-Chuan Hsieh [this message]
2020-10-27 16:12     ` Jean Delvare
2020-10-28  3:50 Kai-Chuan Hsieh
2020-10-28  9:04 ` Jean Delvare
2020-10-28  9:15   ` Kai-Chuan Hsieh
     [not found] <[PATCH] firmware/dmi: Include product_sku info to modalias>
2020-10-28  4:13 ` Kai-Chuan Hsieh
     [not found] <20201022064936.10854-1-kaichuan.hsieh@canonical.com>
2020-10-28  4:38 ` Kai-Chuan Hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba8ca9b3-da06-4543-6804-ac0d47f26b06@canonical.com \
    --to=kaichuan.hsieh@canonical.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®