From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 220C638B9A0 for ; Thu, 22 Jan 2026 19:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769110022; cv=none; b=fe05xJ0sj3/7y8jmxFgN7x5MduK1/GYXxtbqjMSnDGp7+kNObxEkqMLPESiIXUq1Kf++7CbYBT5Xx2v+EhRQwGgaS1uJz1bxCoUhDJIDgikd9wt0+TAzJzmOdc30Zxg3O/YyLxZRCrpr8ALrbDfv4n76h0/dfbd9eJML0bmyHnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769110022; c=relaxed/simple; bh=Nw/nInipLCUu+jLQhKIbrMH/RHjA+u5/sde1eZX0c6M=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=EaJpuDU3BKXFJg6hZfMTG+o8xEYSuRnWFehO1BQiR6kjBqmrZ0Vmhlw8e5ZV5zmh20gCQ1Vajzy5n8KkPrSmnuhY/W2i0KZhkF8R9W+BE9+QSmsanq3u+J5Pxj5EOxrvoSNRJ3qPhOjHv/9MvKp1tWUsKSasDTIxTgmWG/EGkjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=FkLnFaM+; arc=none smtp.client-ip=209.85.219.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FkLnFaM+" Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-88888c41a13so15797346d6.3 for ; Thu, 22 Jan 2026 11:26:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769110015; x=1769714815; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4UUagfqRa3jCP2fBiA3Ur8fXwirA3RKoOMc660AuSI0=; b=nfq0LMeiLh6l52fvkbNmMzrNT2gR+utz9D2jzgiU6zg/t+ocE47TUAQfB8mAxqVke8 0i3cDPwRZTuNwm4jriDOQgS0vFypBc7R0kjAOO9StqdypuwAUKSNowPHMbg29KsAwW3O AJ/Tbf0nzXXu2RGU4HHabE3rNqeNoBY2XuNAdaXxGj4u6B2uQrzEtu5Tti+8+6/qXMcI DZrIiFaQV0UhbxrX3nVU9hXRdwjdFHtoWUmTnsRe5IoKg2E7OOpB/bAUiZAiv1frqhYk WIiI9t7ZhYbA9Ee0Wwl99JcmOS4X/u1RJQNG+7kOEcLTadNGYTJnIKrrerxH8lU3TB5S awnQ== X-Gm-Message-State: AOJu0YzT/TKyNe0lG2xVOqt8u5h/oYoqGCifXndV4j8xKa2gNUOHtXpF 6jzg+y2bncMmMQAVkzNOD1+3RHIr31aNbkssyQ9WU7bnzBp3wx2sfqRYRbkH3zbIf8BfJvE25Op +cFPVhOG7sZEadzMXy/gdME9SwJRdRHYLKVcUj1z3uITbNjbgL45vhh1IqE/yRn17uzt7BsMYRm dVN5SunOjNlIQixUnrcEBMjarSmlGGrTKqc8qtKiV7mqgG6dXZh1MEaC8IIAojalSkouSy1ZuSj ZwiVsV1jF5htB/+hVKNlw7L X-Gm-Gg: AZuq6aKYw4KCv30V66mrGE6kcOKMrenb6ToZXHK+W2ne0w8Xj8lDkQ3EQf3sGl0t4V1 g2GAmotgDuIW7A9NGqJOKC7n5bsL5vk8Kp5/N4veLWPivmV9fDhX+8W35GBlDp1vqBFfRuv28+6 YXm79DXvq5p7FJQp1Y+Fxh8vkJPfYu48AlTaSKCpjQvzVD4eHU1+Bi24dWnY9ONoFX+iHLjat6N s0NveNKfoVWGUi44+mxZsHlcsGNz3kyPIuf6AkxqUJSdv6dBHYSHgaQBToyNExIWhGsTEEJp+72 WkoQE49RC3In+RMRjMcUnyTI9wddCrovKEZQaCUMBJmDfQvmnL6Tzz0sYMtqvRssCHn10digfMD LEYe+493KSB8WLWwTg68XwKDLwO9Oo+hcJiHtqJdiIy58qpqKM4oxMphBg3Ltc+rxqelPpsR7Xm cIVA+5JUeu/c9+atkyjP4vJqqCGSAzknuiZebPKNBYEGz7aJ2jkcBA X-Received: by 2002:a05:6214:1c0b:b0:888:8804:50f4 with SMTP id 6a1803df08f44-894901acd9fmr9614346d6.20.1769110014481; Thu, 22 Jan 2026 11:26:54 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-8949157e4c1sm205556d6.0.2026.01.22.11.26.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2026 11:26:54 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-123349958b2so5508988c88.0 for ; Thu, 22 Jan 2026 11:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769110013; x=1769714813; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4UUagfqRa3jCP2fBiA3Ur8fXwirA3RKoOMc660AuSI0=; b=FkLnFaM+HuJCu9z3g8mqel4eNLXCnfzKOtM2RDb8vLOYW+rIRxF29ZR33yuJv9ZRBb U4kdloWC46HvaZMW/Wtaksb40xuMTUMoaYNK+qsqRZcL1qvitN1P8wFw7SKM/S3NdPH3 jgluJc+aORb63pZDuGCKxpQ6honPCMX+uPnTk= X-Received: by 2002:a05:7022:438e:b0:11d:fc72:e17f with SMTP id a92af1059eb24-1247dbbba5bmr270186c88.18.1769110013226; Thu, 22 Jan 2026 11:26:53 -0800 (PST) X-Received: by 2002:a05:7022:438e:b0:11d:fc72:e17f with SMTP id a92af1059eb24-1247dbbba5bmr270169c88.18.1769110012532; Thu, 22 Jan 2026 11:26:52 -0800 (PST) Received: from [10.63.25.133] ([12.75.221.34]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1247d90ce0dsm597516c88.4.2026.01.22.11.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 11:26:51 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 11:26:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gpio: brcmstb: implement irq_mask_ack From: Florian Fainelli To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Doug Berger , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Christophe Leroy , "open list:GPIO SUBSYSTEM" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20260122010516.1200630-1-florian.fainelli@broadcom.com> <20260122010516.1200630-3-florian.fainelli@broadcom.com> Content-Language: en-US Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/22/2026 11:17 AM, Florian Fainelli wrote: > > > On 1/21/2026 11:36 PM, Andy Shevchenko wrote: >> On Thu, Jan 22, 2026 at 3:06 AM Florian Fainelli >> wrote: >>> >>> From: Doug Berger >>> >>> The irq_mask_ack operation is slightly more efficient than doing >>> irq_mask and irq_ack separately. >> >> I would refer to the callbacks as >> >> .irq_mask() >> .irq_ack() >> >> et cetera. > > Ack. > >> >>> More importantly for this driver it bypasses the check of >>> irqd_irq_masked ensuring a previously masked but still active >>> interrupt gets remasked if unmasked at the hardware level. This >>> allows the driver to more efficiently unmask the wake capable >>> interrupts when quiescing without needing to enable the irqs >>> individually to clear the irqd_irq_masked state. >> >> ... >> >>> -// Copyright (C) 2015-2017 Broadcom >>> +// Copyright (C) 2015-2026 Broadcom >> >> Shouldn't it be rather 2015-2017,2026 ? (In one case when I updated a >> driver for Intel, I went via Git history to gather the info.) > > Ack. > >> >> ... >> >>>   static void brcmstb_gpio_set_imask(struct brcmstb_gpio_bank *bank, >>> -               unsigned int hwirq, bool enable) >>> +               unsigned int hwirq, bool enable, bool ack) >> >> This type of interface is usually discouraged as it makes code harder >> to read and follow. Since there are a lot of duplication, I recommend >> to move the ack op to a separate helper. > > Good point, knowing the order and what set in those parameters can be > confusing. > >> >> ... >> >>> -       gpio_generic_write_reg(&bank->chip, >>> -                              priv->reg_base + GIO_MASK(bank->id), >>> imask); >>> +       if (ack) >>> +               gpio_generic_write_reg(&bank->chip, >>> +                                      priv->reg_base + >>> GIO_MASK(bank->id), >>> +                                      imask); >> >> Id est this piece... >> >> >> >>> +static void brcmstb_gpio_irq_mask_ack(struct irq_data *d) >>> +{ >>> +       struct gpio_chip *gc = irq_data_get_irq_chip_data(d); >>> +       struct brcmstb_gpio_bank *bank = gpiochip_get_data(gc); >>> + >>> +       brcmstb_gpio_set_imask(bank, d->hwirq, false, true); >> >> ...and call it here explicitly (seems the only place for it, so it can >> even be just moved here without an intermediate helper). Actually we need it to be part of brcmsftb_gpio_set_imask() because this is where the guard(gpio_generic_lock_irqsave) resides. I can't really see a better alternative, short of create two implementations: of brcmstb_gpio_set_imask() and brcmstb_gpio_set_imask_ack() which does not feel any better than the proposed patch. -- Florian