From: Sekhar Nori <nsekhar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <stable@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Lechner <david@lechnology.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
Date: Wed, 11 Dec 2019 15:42:42 +0530 [thread overview]
Message-ID: <ba94531d-1f16-b985-5638-c226bab28d5b@ti.com> (raw)
In-Reply-To: <20191210195202.622734-1-arnd@arndb.de>
Hi Arnd,
On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <stable@vger.kernel.org> # v5.4
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Assuming you are going to apply directly to ARM-SoC,
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index dd427bd2768c..02b180ad7245 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select REGMAP_MMIO
> + select RESET_CONTROLLER
> select HAVE_IDE
> select PINCTRL_SINGLE
>
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-12-11 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:51 Arnd Bergmann
2019-12-11 9:14 ` Bartosz Golaszewski
2019-12-11 10:00 ` Philipp Zabel
2019-12-11 10:12 ` Sekhar Nori [this message]
2020-01-13 12:02 ` Sekhar Nori
2020-01-16 18:34 ` Olof Johansson
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
2019-12-17 16:46 ` Tony Lindgren
2019-12-21 16:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba94531d-1f16-b985-5638-c226bab28d5b@ti.com \
--to=nsekhar@ti.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®