From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9713FA372A for ; Wed, 16 Oct 2019 13:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F84B20650 for ; Wed, 16 Oct 2019 13:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n3woTuDz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404147AbfJPNVY (ORCPT ); Wed, 16 Oct 2019 09:21:24 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41520 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388141AbfJPNVX (ORCPT ); Wed, 16 Oct 2019 09:21:23 -0400 Received: by mail-lj1-f193.google.com with SMTP id f5so24006776ljg.8; Wed, 16 Oct 2019 06:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8t0MjC1TDAZp6Auw3cZVTxNMQ8hM6OEjKScXfrE2vxU=; b=n3woTuDzJV9AoYhlwEUS1oYaJH8ERL8aYYerhx7ked9ZxHwomfoUQiakFZyIw0xAi8 jMDcaoxBQjAQMQV8ee76tUAQYLQJINhX+iuVSmtMW9x1wah/TE/9JRrvqkaQZP/awuEG fLCuUk6k3lsgz00JEB65n09eoVuFDP9M5V1+Im9hG9wmjchAHPqVqYg8HpXa7Pdc2qvB cEeU4v//zGCTQBr9LBU1wZ3yaxFlC/4lM8cX8zw5Om9brz2SjYb8vFipX2XwDckTRdXh LOBWQRACI2X2/mVMjYrS0UmPi/3Jz8FA0WEqoTpMn5Ik8FZjg6mlCMftiqkd4kPutKiD hUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8t0MjC1TDAZp6Auw3cZVTxNMQ8hM6OEjKScXfrE2vxU=; b=PZWQS8qGBLPXVVxs0T9M3vjgRq4JuaXvGHivIo55cz9ntcjDr6+Y/zxdcHn0+zbcMH y5g1SlbjEZ3kSxiVrvqrX7Z1aAsAimEaKYJ9xF+NSxGE0pN4fBVXmtzXlE+t8/nufEzJ 5UuZ4C0/cv4v7vCzL9L2hn4vGJ2xyadyJII7kiyThsp7XbV1RsRPshHhKWar3bKk7JCf tGxxZmjibHx2OEnXwmbPeEIuDW8EtFa7fuaWjfKaDAlCvHkKp2TbAWmh9p07ocAFNv9z FL5rCcFu4ax9Uh7nofi9mZNvezqaJsDqDkMCiZva5XYQ55+MBnBPCoW90CitaZZxgbPE /2Bw== X-Gm-Message-State: APjAAAUqkd4d7K9nB+kXsLiU3Xe3gQNHS7oazYOenR2zs/k1YYJSNvUA eIc5Q+sQkqroHryxH9mU+NV0muwS X-Google-Smtp-Source: APXvYqyCT7A8rXmaOtj0hAM67N241Q5cshOzSzWgLHHqVdjLhd39lFdCGWmC4ZBv8jOCBy6BfBhnBg== X-Received: by 2002:a2e:42d6:: with SMTP id h83mr25258614ljf.21.1571232081003; Wed, 16 Oct 2019 06:21:21 -0700 (PDT) Received: from [192.168.2.145] ([94.29.10.250]) by smtp.googlemail.com with ESMTPSA id b67sm7983191ljf.5.2019.10.16.06.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 06:21:20 -0700 (PDT) Subject: Re: [PATCH v1 11/17] ARM: dts: tegra20: Add CPU Operating Performance Points To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Peter De Schrijver , Prashant Gaikwad , "Rafael J. Wysocki" , Rob Herring , Michael Turquette , Stephen Boyd , Peter Geis , Nicolas Chauvet , Marcel Ziswiler , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191015211618.20758-1-digetx@gmail.com> <20191015211618.20758-12-digetx@gmail.com> <20191016052323.w6hav4qqn3ybt55q@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Wed, 16 Oct 2019 16:21:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191016052323.w6hav4qqn3ybt55q@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 16.10.2019 08:23, Viresh Kumar пишет: > On 16-10-19, 00:16, Dmitry Osipenko wrote: >> Operating Point are specified per HW version. The OPP voltages are kept >> in a separate DTSI file because some boards may not define CPU regulator >> in their device-tree if voltage scaling isn't necessary, like for example >> in a case of tegra20-trimslice which is outlet-powered device. >> >> Signed-off-by: Dmitry Osipenko >> --- >> .../boot/dts/tegra20-cpu-opp-microvolt.dtsi | 201 ++++++++++++ >> arch/arm/boot/dts/tegra20-cpu-opp.dtsi | 302 ++++++++++++++++++ >> 2 files changed, 503 insertions(+) >> create mode 100644 arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi >> create mode 100644 arch/arm/boot/dts/tegra20-cpu-opp.dtsi >> >> diff --git a/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi b/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi >> new file mode 100644 >> index 000000000000..e85ffdbef876 >> --- /dev/null >> +++ b/arch/arm/boot/dts/tegra20-cpu-opp-microvolt.dtsi >> @@ -0,0 +1,201 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> + >> +/ { >> + cpu0_opp_table: cpu_opp_table0 { >> + opp@216000000_750 { > > Maybe just drop the _750 (i.e. voltage) from the names as we don't generally > follow it :) The reason for the _750 postfix is that there are multiple OPPs for 216MHz and they have different voltages for different versions of hardware, thus those are separate OPPs and they can't be squashed into a single OPP node.