From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00513C43217 for ; Thu, 1 Dec 2022 08:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbiLAI3s (ORCPT ); Thu, 1 Dec 2022 03:29:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiLAI3o (ORCPT ); Thu, 1 Dec 2022 03:29:44 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 95798FCA; Thu, 1 Dec 2022 00:29:41 -0800 (PST) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 01 Dec 2022 17:29:40 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 7B1BE2059054; Thu, 1 Dec 2022 17:29:40 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 1 Dec 2022 17:29:40 +0900 Received: from [10.212.157.157] (unknown [10.212.157.157]) by kinkan2.css.socionext.com (Postfix) with ESMTP id AD02EA855D; Thu, 1 Dec 2022 17:29:39 +0900 (JST) Message-ID: Date: Thu, 1 Dec 2022 17:29:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221129103509.9958-1-hayashi.kunihiko@socionext.com> <20221129103509.9958-2-hayashi.kunihiko@socionext.com> From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/01 0:24, Krzysztof Kozlowski wrote: > On 30/11/2022 09:59, Kunihiko Hayashi wrote: >>>> +maintainers: >>>> + - Kunihiko Hayashi >>>> + >>>> +description: |+ >>>> + System controller implemented on Socionext UniPhier SoCs has multiple >>>> + functions such as clock control, reset control, internal watchdog >>>> timer, >>>> + thermal management, and so on. >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - socionext,uniphier-ld4-sysctrl >>>> + - socionext,uniphier-pro4-sysctrl >>>> + - socionext,uniphier-pro5-sysctrl >>>> + - socionext,uniphier-pxs2-sysctrl >>>> + - socionext,uniphier-ld6b-sysctrl >>>> + - socionext,uniphier-sld8-sysctrl >>>> + - socionext,uniphier-ld11-sysctrl >>>> + - socionext,uniphier-ld20-sysctrl >>>> + - socionext,uniphier-pxs3-sysctrl >>>> + - socionext,uniphier-nx1-sysctrl >>> >>> All of them can have children or only some? >> >> In case of this system controller, >> all SoCs has clock-controller, reset-controller and watchdog. >> >> However, some SoCs don't have thermal-sensor and >> their register addresses are reserved. > > OK > >> >>>> + - socionext,uniphier-sysctrl > > What about this one? What SoC is this? Looks too generic. It's the same one as soc-glue, so it should be placed as follows. items: - enum: - ... - ... - const: socionext,uniphier-sysctrl However, currently it is no use for now. I'll drop it. Thank you, --- Best Regards Kunihiko Hayashi