From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5DD332ED45 for ; Fri, 27 Feb 2026 06:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772174886; cv=none; b=cMqQCxJ41JvyTZGh/2VPIewEpqIZU6JYFCl4qa3AcBbrMzYfx4ceo3wAOjbEVIu74jYHARhIYLxRmALrWHuQqk+1f585SwyBss+W/OVhz3Hjlelvbv7N512IDpNAUe6KpmLDbLMqKjKxkzmvkNaw1VtVfZ32DY7Vrl1RLhb3OTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772174886; c=relaxed/simple; bh=ba3c1gXGQy+o5rD2JlqzieKSqhaLlsBOFfFLgEvtwYw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=pu/bbEHU9YVp+aOrPvWHbVTlU9PlyEVxDAt1eoocSCmsUCTgzjT687erZ0eEUi11J6HjtIUijy7MbgzNqnOEFvTL7fK224RbfnDzzk0cmZV6snFzr0yQ6DhZy4ugl8pjI/hvfGiWo68hxBxH4cv0p906ii2plxmYSCJi2FnS8Ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=gohzbNVp; arc=none smtp.client-ip=80.241.56.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="gohzbNVp" Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4fMf6166hsz9tSP; Fri, 27 Feb 2026 07:47:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772174873; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ba3c1gXGQy+o5rD2JlqzieKSqhaLlsBOFfFLgEvtwYw=; b=gohzbNVpnfS7gMzYQ8WBzmO5pJ+i4s1RNC0StxgUNEqhVz9DYQCyQ7vzCrMH0nP9mq3mxm 0napB2rLwwX/chsnmYDjpLw70M7RM3VDFrzlG4MW+UtQsoqnWaE/y3LDXSH+o85aIrdtJ0 OL3eTS6zqE3ObLdRIeqFPNh9W9kNGTnZVjydUHHVN1JPGzbm0LqKOQy5Fd1ePJFSni/XsG oue1vGiPBecEClCgWdG2G6XBZyaLoQMpocY1tqTBH6CL+n6/VOyTSsyYvywnS6T5PFpuXk MI6iqkYoxzAergs5rbT71pDBYZXgCEuTi3+BWrtjC9kj7liI+zGlxec0ADno+g== Message-ID: Subject: Re: [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() From: Philipp Stanner Reply-To: phasta@kernel.org To: Yujie Liu , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Kenneth Feng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Patrik Jakobsson , Matthew Brost , Danilo Krummrich , Philipp Stanner , Thomas =?ISO-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi Cc: Pierre-Eric Pelloux-Prayer , Srinivasan Shanmugam , Tvrtko Ursulin , Sunil Khatri , Lijo Lazar , Asad Kamal , Yang Wang , Hawking Zhang , Tao Zhou , Gangliang Xie , Candice Li , YiPeng Chai , Matthew Auld , Luben Tuikov , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , =?UTF-8?Q?Micha=C5=82?= Winiarski , Michal Wajdeczko , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Date: Fri, 27 Feb 2026 07:47:42 +0100 In-Reply-To: <20260226030038.1182961-3-yujie.liu@intel.com> References: <20260226030038.1182961-1-yujie.liu@intel.com> <20260226030038.1182961-3-yujie.liu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-ID: 7f64d465d2b58537bfb X-MBO-RS-META: yswx9ra8z6mx41t598aw6gzhe1ftcf6h On Thu, 2026-02-26 at 11:00 +0800, Yujie Liu wrote: > Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'r= esult' not described in 'drm_sched_job_done' >=20 > Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors") > Signed-off-by: Yujie Liu Thanks for fixing this! Acked-by: Philipp Stanner > --- > =C2=A0drivers/gpu/drm/scheduler/sched_main.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sch= eduler/sched_main.c > index e6ee35406165..fe4c1017734b 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_s= cheduler *sched) > =C2=A0/** > =C2=A0 * drm_sched_job_done - complete a job > =C2=A0 * @s_job: pointer to the job which is done > + * @result: 0 on success; -errno on failure nit: shouldn't it be -ERRNO? But idk. > =C2=A0 * > =C2=A0 * Finish the job's fence and resubmit the work items. > =C2=A0 */