From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E0BC2BB9A for ; Tue, 15 Dec 2020 20:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9A2022CB1 for ; Tue, 15 Dec 2020 20:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725776AbgLOUdA (ORCPT ); Tue, 15 Dec 2020 15:33:00 -0500 Received: from smtprelay0050.hostedemail.com ([216.40.44.50]:40640 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727900AbgLOUby (ORCPT ); Tue, 15 Dec 2020 15:31:54 -0500 X-Greylist: delayed 598 seconds by postgrey-1.27 at vger.kernel.org; Tue, 15 Dec 2020 15:31:49 EST Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id 6054618027F88; Tue, 15 Dec 2020 20:13:54 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 357FE1802958B; Tue, 15 Dec 2020 20:13:54 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cave84_270289327426 X-Filterd-Recvd-Size: 2059 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 15 Dec 2020 20:13:53 +0000 (UTC) Message-ID: Subject: Re: [PATCH] atm: horizon: remove h from printk format specifier From: Joe Perches To: trix@redhat.com, Chas Williams <3chas3@gmail.com> Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 15 Dec 2020 12:13:51 -0800 In-Reply-To: <20201215142413.1850207-1-trix@redhat.com> References: <20201215142413.1850207-1-trix@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-12-15 at 06:24 -0800, trix@redhat.com wrote: > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix > --- >  drivers/atm/horizon.c | 6 +++--- Chas? Madge has been out of business for a couple decades now. I doubt anyone does but does anyone actually use this driver or even have working hardware? If not, how about just deleting this driver altogether instead? from horizon.h: /* Madge Horizon ATM Adapter driver. Copyright (C) 1995-1999 Madge Networks Ltd. */ /* IMPORTANT NOTE: Madge Networks no longer makes the adapters supported by this driver and makes no commitment to maintain it. */ > diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c [] > @@ -1609,7 +1609,7 @@ static int hrz_send (struct atm_vcc * atm_vcc, struct sk_buff * skb) { >      if (*s++ == 'D') { >   for (i = 0; i < 4; ++i) >   d = (d << 4) | hex_to_bin(*s++); > - PRINTK (KERN_INFO, "debug bitmap is now %hx", debug = d); > + PRINTK (KERN_INFO, "debug bitmap is now %x", debug = d); An IMO ugly assignment in a printk too.