From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2785332906 for ; Wed, 15 Apr 2026 10:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776250800; cv=none; b=IfLGaRAR0YlgPh9O5AG4HKDXdwpdaWpY4edWWiASRPW3aNRxDwjqqwcnqYEcXym1b/MKrsihb9RcFtTtmQ2VdRk/LNS/GUVQYf3uCfHHabuD1WAt+vR4lS3fE8vJbDrBbHUyv9DlqQJ9RsiyZManjeLyEwAanEKQt4Fe10J/LTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776250800; c=relaxed/simple; bh=+lnRg2QVwgm/33FpWxNm7zhDQuwHwAICUyGFrKrkn9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EHVgeGUXW/C6P0jcq3BZ4wlNcCJR9vQQlkGlPXi2JAVEACb+SaO3dHmJ/Bzubc1aL3+Urky2mnnHCdIvUuUiIgPThPqnVSaSVwxiUvN/LddzWB3nlU6wkEYtPet9xsiDufedDHxu9oXSfNEcRJzbW4xDR5mKd/d3yXKnX4OvA88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o+vvvPTZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KqhJG+IJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o+vvvPTZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KqhJG+IJ" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63FALQru3059042 for ; Wed, 15 Apr 2026 10:59:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r/7FN8NQtfV7xQGVRyNcE/DUA+bUuRssnQVKpgLbVXk=; b=o+vvvPTZrb/xN3zj 49oGiH1oJIYx8vbIku1sto2ygLwSW+b1f4xN0ORlCBzAdIrBidJo3R0/cIDPHtuP WoOJ3M3lMN8t4GhUrkEsTVPDm691cOy1uPhucOLy/BLpw8wDfHGCqFFJyWVF++/a RkNRrXJhQClGZOWtul2uBkpswW2RBi9MH6Ee5CKDvN7UMfqzccvt7G6liumpH5gO mZCoqNgRi9VAX0hQ8yyJvDUKNDFB5jZ3prEs+QEoXd46gyb8BstOr1d/VtmDEh+t 8jUMv8Uva4wt3wsNmURzMwHM1+5b3kQn1XtXp+m36K2urwRAmMBzxoAdv/o4wjzX K658Kg== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dhteptvf8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Apr 2026 10:59:57 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8954b9b5da7so21592306d6.2 for ; Wed, 15 Apr 2026 03:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776250797; x=1776855597; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r/7FN8NQtfV7xQGVRyNcE/DUA+bUuRssnQVKpgLbVXk=; b=KqhJG+IJFECGHGsT1i97JXVXPd7TerkTln4a7TWgL9nGjdBGS+qa21borcFnPtTmVB I+P1JXSmgHMCDqTI2vF/fwIrkOU1cKTHQHU7GCGlbtUKrAcLJWJStv7Y7hbVFqU9Ho6o bJXW5a9rTkcyI3lJltvp5Ohm6iw4H0BGBSZkyUi/+zjM0Sn0oBk7jc9rVH4KGgZQcl6J 1CnBI9ryDmB3iOdCfXDOFUy3vKlieHi/mgYMp85UWyeSmWJ0jb5xnL+uR749ZXGABD+t 2NrEBht09AuCfGH3Nc162wjQnmBpzsdVfOQvRAaTMFy2ikWc963rkNGqTEO4JNmleyDh yGvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776250797; x=1776855597; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r/7FN8NQtfV7xQGVRyNcE/DUA+bUuRssnQVKpgLbVXk=; b=fXTOJkNfwkf/0yDgeMo/A16yGyinJC8/1Dbg3Yo7LUwQMGmQg5/rJrF6pIpgUgomMy vjS85LUPdLs3AuhO0M0OQXmV0JrH0tNnCxiK/ADwIKLMuxZY8IWLpl5quV1uQvL2kxd9 mm49sE3u6elTYSbul7ajsuR32w7CxmpEThvCcyeogA5Rg4ezZxYUtpllhCYKcT+FL5hM exjlz0w5gr9ULWZxXkqqhPmeQsDw7cbVKt+NG8+EIznH3JWfbgP64eMpavhe1YXL8CP6 2cygqmLFIcg1amgB4bmzLgHpR3oJL5R+LDelc5ffp9Ys4BdGg2qn9xCTb1Ls+Jyh0uXn 4kDw== X-Forwarded-Encrypted: i=1; AFNElJ94VGxUUmqV2BMQZqfmv5KGgaFSwYINJJvsfRWV5c/1MPkw9u38wn8DHKqAmAXg+ZcOgquKN6jDc1v91UA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3k7klk9Hzrgf/bg08nzWlBVtJbP87YHzLeda4t717Ns8Xi6Wu Xh84ys6R+vO2sd5AcxgFPl7NCm8j6DbFIDw7ZXWefFI+S8phwxU5vholIKQr9tTzofVP7CrA41z KPTage6WqNV12DFKan3w3mdrAupZY9klCgFansWUUpo+qz4UO4PjqbTC+sOCcLBdomPY= X-Gm-Gg: AeBDieuMQ997+8Em7/951OdPtZCGU5szT4tn5DpZ6gPpttrArEnCRl1/5OzPVqN3I53 H7p8ANxVPXjav9Em8SGBLKZa/WCCNLtWvojrVWR14dBHGO608FpP7raxkvNvBdvLuXOojgRts81 Cgg2ZxymbH2FmfpmYvRF8nsOE1qxCWZqcu3QO+NPuybpVjG2WcFicia7WyHcleDLciZbfuPSiFA PmPaYljwzBv+AOLDuaJUh6PtlSEF73/fbyF+QV8FaEDe6fkS+HXAIyagQEuUYWtTAwEx7Vonzo0 55uxNrbcB6n8oM0gEuE9vmaD0gdalVgIAXDQ1I1leXJCh3X6hNsnHGO1vp3l+/5l75F0B76ByLw j1YTGVG/UHo40cnB1z8rQFGE4DendcIb7LmAPymO9nA9/zd0qzRN2GlabyxyLfM7YMUV0To9gkM Iwttl1bQEDfKcyFw== X-Received: by 2002:ac8:690d:0:b0:509:a3c:e390 with SMTP id d75a77b69052e-50e1a7601b3mr16917281cf.4.1776250796855; Wed, 15 Apr 2026 03:59:56 -0700 (PDT) X-Received: by 2002:ac8:690d:0:b0:509:a3c:e390 with SMTP id d75a77b69052e-50e1a7601b3mr16917081cf.4.1776250796485; Wed, 15 Apr 2026 03:59:56 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67237fff281sm310720a12.20.2026.04.15.03.59.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 03:59:54 -0700 (PDT) Message-ID: Date: Wed, 15 Apr 2026 12:59:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: qcom-qmp-ufs: Fix kaanapali PHY PLL lock failure after SM8650 G4 fix To: Nitin Rawat , vkoul@kernel.org, neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com, mani@kernel.org, abel.vesa@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260415104851.2763238-1-nitin.rawat@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260415104851.2763238-1-nitin.rawat@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: tAeXv-yvaMYXyRN3ShWzAMxPPhrzi4Sq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE1MDEwMSBTYWx0ZWRfX+T/xuorqJUG3 hKtQgnruXvxhxf3WNGF3N4mh5+XNfvBNbDc5+CCwBSHp/nq5GNGgzcDst4+84ksmKFA1grJNk2p Is3ai77Csrc0udV1Jyx0hmHUVvSIVVwVm34IQTREsB5vUSCxJ262tnxcKBlhNojfLTeH9WwYHI6 bBPyl6dgte5g36LoZIXBum3nqq/+hmLmSUkaWnCE9EW50/YGjGxEGTsQJo3hhXMAhT3ymZmVWaw 76Zm4aZlTsdRJRQOzDZBteNrO1/ariGVW7ibK0w7UAwebDhtMhi8zUUMH+PRTtVlC73ppaVDqOe wrfGh44T0jR3GEBw1ExVPPR5WUmGMxsfd7KQhK0CnGwguUQFuKXk2aeux9jg+99SJ/zD/zXwmA4 cfVFfT77tUmYRqs5I78hlImgxFukgdWpzENubr3T7pqRS6rxfnavKoPeRMZc6tGI62+RHAxw96W X6GlOOIbCI9SFi+Bofg== X-Authority-Analysis: v=2.4 cv=CoGPtH4D c=1 sm=1 tr=0 ts=69df6fad cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IGLtpV1Bqx4y0bnjnHsA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: tAeXv-yvaMYXyRN3ShWzAMxPPhrzi4Sq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_04,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604150101 On 4/15/26 12:48 PM, Nitin Rawat wrote: > Commit 81af9e40e2e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4") > moved QPHY_V6_PCS_UFS_PLL_CNTL register configuration from the shared > sm8650_ufsphy_g5_pcs table to the SM8650-specific sm8650_ufsphy_pcs base > table to fix Gear 4 operation on SM8650. > > However, this change inadvertently broke kaanapali and SM8750 SoCs > which also rely on the shared sm8650_ufsphy_g5_pcs table for Gear 5 > configuration but use their own sm8750_ufsphy_pcs base table. After the > change, kaanapali PHYs are left without the required PLL_CNTL = 0x33 > setting, causing the PHY PLL to remain at its hardware reset default > value, preventing PLL lock and resulting in DME_LINKSTARTUP timeouts. > > Fix this by adding the missing QPHY_V6_PCS_UFS_PLL_CNTL = 0x33 entry > to the sm8750_ufsphy_pcs table, mirroring what the original commit > already did for sm8650_ufsphy_pcs. > > Cc: stable@vger.kernel.org # v6.19.12 > Fixes: 81af9e40e2e4 ("phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4") > Signed-off-by: Nitin Rawat > --- Reviewed-by: Konrad Dybcio Konrad