From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5A91E487; Wed, 18 Dec 2024 03:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734491911; cv=none; b=KqXhFL7B47QFwD6ORwCDJNj2tbAgNC9nI6SthuLwIKEdym6m6mbioklS8apC8RGyNVkGmzBuqR9h5toDczztijl1YtDtk2myFMExuJCFtKiLw/ASRmtGfGBEFKc48ag7Fbm/pvNng6nz5qaef2MQq78dNIGmY0ob7+aa0+5hwcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734491911; c=relaxed/simple; bh=SHFOvW2BiD+eHefPaaxzl5uu3xWqhdkOljDJEVXVOX0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=bDxa7m79x0dmdLZGEty2Bc9zYySq4xHnC95azKiqcso9OKIrMbZhiW9avze9ZNLBYHHQNWgQIteN0/dNsA0TX+xxLgZFXVSrhUBsoAOmupic8CG6bFjOMF9dZBJPiziOcYO6O3bS7MsF3wtVK9bXbuyLmldrUyQmmojxHZoBBE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=HuQed8pp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="HuQed8pp" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHKdkXD001491; Wed, 18 Dec 2024 03:18:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MY4bThfd3nHovNrRAuLqu4dGpe6E0cynHU9jcVwEij4=; b=HuQed8pp07PEh9Dv UUghu+uZvjhmU9aPQtf6Thx+UiLI1hgiGbURJV4wWUd2j7KjrkH57KK5mWRnzCD5 Ig4Pt/rKI/qa6nNNJzb+l1B+h9FObKumV36o1S4MYJwA7G2goE3ARRCwdJ2s9Z2s KRs5vTx8E6PcRHb0kOOMbBMwztG14XtbMysm95uN9pSQNZxmK1oC2nq+pkFsrv6G zr7o6R3wkYHqjOyOOvW5Xe2bWAfeGfkiyStvXANomrbi/ar7RvtTG6QtnahiUtdT MCEjwEY+XtEiPafdzoaD7CBa1HTRNqmwMvEscOaK76BsR2tjMTrKf9g8znxqU5EE jVTm9w== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43kghk0qmf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Dec 2024 03:18:11 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BI3IA19009355 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Dec 2024 03:18:10 GMT Received: from [10.64.16.151] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 17 Dec 2024 19:18:04 -0800 Message-ID: Date: Wed, 18 Dec 2024 11:18:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 9/9] arm64: dts: qcom: Add display support for QCS615 RIDE board To: Dmitry Baryshkov CC: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Krishna Manikandan" , Bjorn Andersson , Konrad Dybcio , Liu Li , Xiangxu Yin , , , , , References: <20241210-add-display-support-for-qcs615-platform-v4-0-2d875a67602d@quicinc.com> <20241210-add-display-support-for-qcs615-platform-v4-9-2d875a67602d@quicinc.com> <92b6335e-a303-49d3-9b77-f951663fc10c@quicinc.com> Content-Language: en-US From: fange zhang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: p98UkB7seudijRo0Vqo4k0l5gySZ6_zn X-Proofpoint-ORIG-GUID: p98UkB7seudijRo0Vqo4k0l5gySZ6_zn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412180023 On 2024/12/13 18:19, Dmitry Baryshkov wrote: > On Fri, 13 Dec 2024 at 11:21, fange zhang wrote: >> >> >> >> On 2024/12/10 19:02, Dmitry Baryshkov wrote: >>> On Tue, Dec 10, 2024 at 02:54:00PM +0800, Fange Zhang wrote: >>>> From: Li Liu >>>> >>>> Add display MDSS and DSI configuration for QCS615 RIDE board. >>>> QCS615 has a DP port, and DP support will be added in a later patch. >>>> >>>> Signed-off-by: Li Liu >>>> Signed-off-by: Fange Zhang >>>> --- >>>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 89 ++++++++++++++++++++++++++++++++ >>>> 1 file changed, 89 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>>> index a25928933e2b66241258e418c6e5bc36c306101e..694719a09ac46bfa2fe34f1883c0970b9d0902be 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >>>> @@ -32,6 +32,18 @@ xo_board_clk: xo-board-clk { >>>> #clock-cells = <0>; >>>> }; >>>> }; >>>> + >>>> + dp-connector { >>>> + compatible = "dp-connector"; >>>> + label = "DP"; >>>> + type = "mini"; >>>> + >>>> + port { >>>> + dp_connector_out: endpoint { >>>> + remote-endpoint = <&anx_7625_out>; >>>> + }; >>>> + }; >>>> + }; >>>> }; >>>> >>>> &apps_rsc { >>>> @@ -202,6 +214,83 @@ &gcc { >>>> <&sleep_clk>; >>>> }; >>>> >>>> +&i2c2 { >>>> + clock-frequency = <400000>; >>>> + status = "okay"; >>>> + >>>> + ioexp: gpio@3e { >>>> + compatible = "semtech,sx1509q"; >>>> + reg = <0x3e>; >>>> + interrupt-parent = <&tlmm>; >>>> + interrupts = <58 0>; >>> >>> Use IRQ flags instead of just 0 (here and further on). Also it might be >>> better to use interrupts-extended instead. >> Got it, will use interrupts-extended instead >> - interrupt-parent = <&tlmm>; >> - interrupts = <58 0>; >> + interrupts-extended = <&tlmm 58 IRQ_TYPE_NONE>; >>> >>>> + gpio-controller; >>>> + #gpio-cells = <2>; >>>> + interrupt-controller; >>>> + #interrupt-cells = <2>; >>>> + semtech,probe-reset; >>>> + }; >>>> + >>>> + i2c-mux@77 { >>>> + compatible = "nxp,pca9542"; >>>> + reg = <0x77>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>> >>> Add empty line before device nodes (here and furher on). >> Sorry, will add it in next patch. >>> >>>> + i2c@0 { >>>> + reg = <0>; >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + anx7625@58 { >>>> + compatible = "analogix,anx7625"; >>>> + reg = <0x58>; >>>> + interrupt-parent = <&ioexp>; >>>> + interrupts = <0 0>; >> will change it to interrupts-extended in next patch >> - interrupt-parent = <&ioexp>; >> - interrupts = <0 0>; >> + interrupts-extended = <&ioexp 0 IRQ_TYPE_NONE>; > > Yes, much better. BTW: are you sure that it's really IRQ_TYPE_NONE? We extensively tested FALLING and BOTH type, and they all work. However, I believe it’s better to use the default type, which is the same as the downstream approach. This way, it will be more stable. > >>>> + enable-gpios = <&tlmm 4 GPIO_ACTIVE_HIGH>; >>>> + reset-gpios = <&tlmm 5 GPIO_ACTIVE_HIGH>; >>>> + wakeup-source; >>>> + >>>> + ports { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + >>>> + port@0 { >>>> + reg = <0>; >>>> + anx_7625_in: endpoint { >>>> + remote-endpoint = <&mdss_dsi0_out>; >>>> + }; >>>> + }; >>>> + >>>> + port@1 { >>>> + reg = <1>; >>>> + anx_7625_out: endpoint { >>>> + remote-endpoint = <&dp_connector_out>; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> + }; >>>> +}; >>>> + >>>> +&mdss { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&mdss_dsi0 { >>>> + vdda-supply = <&vreg_l11a>; >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&mdss_dsi0_out { >>>> + remote-endpoint = <&anx_7625_in>; >>>> + data-lanes = <0 1 2 3>; >>>> +}; >>>> + >>>> +&mdss_dsi0_phy { >>>> + vdds-supply = <&vreg_l5a>; >>>> + status = "okay"; >>>> +}; >>>> + >>>> &qupv3_id_0 { >>>> status = "okay"; >>>> }; >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> > >