From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shreeya Patel <shreeya.patel@collabora.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
heiko@sntech.de
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com,
Christopher Obbard <chris.obbard@collabora.com>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B
Date: Tue, 4 Apr 2023 21:02:38 +0200 [thread overview]
Message-ID: <baaf63d1-272f-d326-cf6f-b6150afe34e2@linaro.org> (raw)
In-Reply-To: <20230404174121.38727-1-shreeya.patel@collabora.com>
On 04/04/2023 19:41, Shreeya Patel wrote:
> Add DT node to enable RTC support for Rock 5B board.
>
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
> .../boot/dts/rockchip/rk3588-rock-5b.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 95805cb0adfa..fcb5af09e49b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
> };
> };
>
> +&i2c6 {
> + status = "okay";
> +
> + hym8563: hym8563@51 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
prev parent reply other threads:[~2023-04-04 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:41 Shreeya Patel
2023-04-04 19:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baaf63d1-272f-d326-cf6f-b6150afe34e2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®