From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72866EB64D7 for ; Fri, 23 Jun 2023 11:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231330AbjFWLaQ (ORCPT ); Fri, 23 Jun 2023 07:30:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbjFWLaN (ORCPT ); Fri, 23 Jun 2023 07:30:13 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74761268A; Fri, 23 Jun 2023 04:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=D0ozaDmhNyFK25SoDuRwst2ICRzooGIruMu1J/0UTdw=; b=e1VU5HupzKjPk3tMn37weKC8T1 Df1rHFJLyS3VCJbM9W9xH+rDHA24BxaSXm97nyn8vtwSmOLplRM2ZDCtGw+4a6TjR7AjmkoE7e3WM IeNesvLOTnPILGjPWBqyUEq2PniAppsVbh3FrVT29eidMgR7UlyvrLrj4qR3c/QZntS3HScTq2sLX x1HLlKfB1VC8ypOT+frAyYy08Ax0GAZxV93p6Kbjl2H7UH8cgYjVKV1D8pIYVXY7pXyu3b8jEhSC5 LhQtrKd4nRYZKTNDsfWIx0mOmSHJ/gGRl96XDvwWvaGYx9AgEM8MaoWTZ0pZT7NMFtNipd6FQ4gk9 dvEdDP0w==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qCezJ-0000a8-PL; Fri, 23 Jun 2023 13:30:01 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCezJ-000G0O-7d; Fri, 23 Jun 2023 13:30:01 +0200 Subject: Re: [PATCH] bpf: Replace deprecated -target with --target= for Clang To: Quentin Monnet , Fangrui Song , Alexei Starovoitov , John Fastabend , bpf@vger.kernel.org Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230623020908.1410959-1-maskray@google.com> From: Daniel Borkmann Message-ID: Date: Fri, 23 Jun 2023 13:30:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.8/26948/Fri Jun 23 09:28:15 2023) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/23 10:51 AM, Quentin Monnet wrote: > 2023-06-23 02:09 UTC+0000 ~ Fangrui Song >> -target has been deprecated since Clang 3.4 in 2013. Use the preferred >> --target=bpf form instead. This matches how we use --target= in >> scripts/Makefile.clang. > > This seems to be the relevant commit, for reference: > > https://github.com/llvm/llvm-project/commit/274b6f0c87a6a1798de0a68135afc7f95def6277 > >> >> Signed-off-by: Fangrui Song >> --- >> Documentation/bpf/bpf_devel_QA.rst | 10 +++++----- >> Documentation/bpf/btf.rst | 4 ++-- >> Documentation/bpf/llvm_reloc.rst | 6 +++--- >> drivers/hid/bpf/entrypoints/Makefile | 2 +- >> kernel/bpf/preload/iterators/Makefile | 2 +- >> samples/bpf/Makefile | 6 +++--- >> samples/bpf/gnu/stubs.h | 3 ++- >> samples/bpf/test_lwt_bpf.sh | 2 +- >> samples/hid/Makefile | 6 +++--- >> tools/bpf/bpftool/Documentation/bpftool-gen.rst | 4 ++-- >> tools/bpf/bpftool/Makefile | 2 +- >> tools/bpf/runqslower/Makefile | 2 +- >> tools/build/feature/Makefile | 2 +- >> tools/perf/Documentation/perf-config.txt | 2 +- >> tools/perf/Makefile.perf | 4 ++-- >> tools/perf/util/llvm-utils.c | 4 ++-- >> tools/testing/selftests/bpf/Makefile | 6 +++--- >> tools/testing/selftests/bpf/gnu/stubs.h | 3 ++- >> tools/testing/selftests/hid/Makefile | 6 +++--- >> tools/testing/selftests/net/Makefile | 4 ++-- >> tools/testing/selftests/tc-testing/Makefile | 2 +- >> 21 files changed, 42 insertions(+), 40 deletions(-) >> > >> diff --git a/samples/bpf/gnu/stubs.h b/samples/bpf/gnu/stubs.h >> index 719225b16626..cc37155fbfa5 100644 >> --- a/samples/bpf/gnu/stubs.h >> +++ b/samples/bpf/gnu/stubs.h >> @@ -1 +1,2 @@ >> -/* dummy .h to trick /usr/include/features.h to work with 'clang -target bpf' */ >> +/* SPDX-License-Identifier: GPL-2.0 */ > > Are these necessary, seeing that the files only contain this single-line > comment? Yeah, lets drop that one. Otherwise looks good. Could you split out the tools/perf/ changes into a separate commit? I would assume that Arnaldo wants to take these changes via perf tree instead. >> +/* dummy .h to trick /usr/include/features.h to work with 'clang --target=bpf' */ > > Other than this, the change looks good, thanks. Although it should > probably target bpf-next rather than bpf? > > Acked-by: Quentin Monnet