From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F9731717D for ; Wed, 12 Aug 2026 20:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786566262; cv=none; b=CInmJujxeQuwVKYy2m0Qg79VK+hBIu91n8xcDlNcSXNGHlmDr5577Mxt4zugvyf6XznREubVmTZREQkE7S5WYWcsWcM8T6RR4Mx4/qyJNzvHda22VgHL3/OwdCqlAo/zxkHKTcX/DuXfGAw6zW0ipeKhIVLGNhjmZbEe2AgQWIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786566262; c=relaxed/simple; bh=i8ktCy2GlL0xTxDMdbz8Utu9rRX8YCUyaxzKr/VT31w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=af7Hl59D/P2lp1kfBxDIg+h+pC7c1gHli7itoAXEF67EdvUySoys1BRhCb/4mwWDC2YUp0y3KALq1nMTglpLBikqpcz98hiXFvVNvuZQMdll0I2gagKFQ7czkt4Dk3MhvEkT9WsDzS+cpIDECjFUtsh/0kJtKhgRhEsOGXdg0Rg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=G704KI8O; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="G704KI8O" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-38e42560ebcso1323592a91.1 for ; Wed, 12 Aug 2026 13:24:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786566260; x=1787171060; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BZtZnEw9abfd2kfAccbrrChpAaOCNlD+RCF2EVqOizI=; b=cvCw6HMq0EvTy8rKgDcYq2gX1Qnr320RIokTTmVDFKnNPzbw//bjQEr8G3kZsMQN4/ BQJ27nyiZdhrkt/g+AgnOP49Xv9mev9kJ3u6n8T1d7HOFgO4UlkpmdyYrfHPLHmT/ilq NapcDztfGnfLXGpZr3F2rZySS3v7MY2rkOp0N9hmFf6wd5JYcgn/kEFt41JoaBE8JwiE DxUuUazu3ftDQswD6MiHNv5ts4BCR8QLyg3nJA1BSxQ9wCWWMMABWmPiNr28ityAFIdi Shz59RvmrKI709A6BpCN+EIfZMGIZ+vCe7gvsnurgEvXF16F1dMaVcTTtG1zz8JAukGw D1OQ== X-Forwarded-Encrypted: i=1; AHgh+RopaNm+Hw0rJCB5+fsVPopknebHUfGxWy1rSzicGfszomftKDnbkWfzcSBcDfwqZQpzYrNxG/agafTCOlk=@vger.kernel.org X-Gm-Message-State: AOJu0YwWnTn3vFZMC1O3jbMqzgVJmpI4cjuMwXfPdzAhkmCXBrlfSYjU VbDEKB01pL5V4fz9Rl93X1nferVzNC7AXIwjExfcS78vqwWy5AYezFKpmhKi2YFTjvuRSv9VYiJ 9mlaDrtfVTyoJ9Ybnv2bzxRI4eoXVDTLcKSsheuOST1MzhjVPj13pSe0r42laaPYb9FkU7zb/U3 DtFl69y/45yyIUPOdOUV+42vR2vx4hVD6Z48obYmXYuOYPxtQ1Ka5ZpcIDbGNW/qmw/ZLa40xwu ZhWhq92Nn6vxOeUZqmr3r6w X-Gm-Gg: AR+sD12uKv2/kehuwKkvVEXwidmVFepqxMiN/IAJ9CP2mQRLO4phNEcPKZVXA2vUgL7 JuuHWd6NOWFlnTpJ8j5kod6DEIjtbjPJlD6yH8RcpuA0wYjKkjhncSLjgzWdHzh7UfuWsifSyzz u5+nghayTJiLq3HHrz2cccZymAJRcPy6UPawK+42EnijeftaL30TkDFbQmP5Lyd/aSq3GIYN8MU V2NqNZ03ZsFoaamKs0374SXwdXNLWLoJ55u42CEJJf2Ypf0WRWGh9rWcg6UMTSkxEy+bV3bYL46 qwKhEAaWZhnu9CxEhJkiLloF2vFsqMFtVxoeKDvW9uumb9PWprsBmzNpL+xt7bUcdrHOebndsEc F+z2/m2rRLyxtuLyV7J5QxtUVT1f5yH+ZAhFvs1Ibu42Tvdo9Mg4GD4hJFGm4tnGyc7AMnqd2b6 NVjqQT4EmbMF2U3qdrg2zxpoP66KKqQQtvYb+4fNFQ X-Received: by 2002:a17:90b:2e50:b0:37f:df85:272f with SMTP id 98e67ed59e1d1-3931e30bd44mr880704a91.19.1786566260271; Wed, 12 Aug 2026 13:24:20 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-20.dlp.protect.broadcom.com. [144.49.247.20]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3931cf2e7dfsm200374a91.13.2026.08.12.13.24.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Aug 2026 13:24:20 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cfa55c9430so16509325ad.0 for ; Wed, 12 Aug 2026 13:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1786566258; x=1787171058; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BZtZnEw9abfd2kfAccbrrChpAaOCNlD+RCF2EVqOizI=; b=G704KI8O1LtqDF/vHGXopyiqBVTlUVyHWxLhFmlPjkTRdg6jrr27d7T0NKxcuxQDVU FWXFQT1BbPnS7WWSjZQriebYTKkWxHo/+AdBxXGy69GXyG/IZE2Bb1SDP5vAfZlNtIrk ipcCJYdhzw6kE36f+c7+jdnbOJ5W2dBq0xx8o= X-Forwarded-Encrypted: i=1; AHgh+RprEVIlpFC3+axrlzdWg5ZIXoN/mENvNrj8LCLEHvn8PmTtED5HCiOL8nxbZDoNGId4COXBg2gMLy2Y/g4=@vger.kernel.org X-Received: by 2002:a17:90b:254a:b0:36b:77b9:5c8c with SMTP id 98e67ed59e1d1-3931e2dd751mr874736a91.17.1786566258312; Wed, 12 Aug 2026 13:24:18 -0700 (PDT) X-Received: by 2002:a17:90b:254a:b0:36b:77b9:5c8c with SMTP id 98e67ed59e1d1-3931e2dd751mr874693a91.17.1786566257764; Wed, 12 Aug 2026 13:24:17 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf628e2aasm16442300eec.14.2026.08.12.13.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Aug 2026 13:24:17 -0700 (PDT) Message-ID: Date: Wed, 12 Aug 2026 13:24:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: dsa: b53: fix error propagation from b53_fdb_dump() To: Vladimir Oltean , netdev@vger.kernel.org Cc: Florian Fainelli , Jonas Gorski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20260812201121.2012356-1-vladimir.oltean@nxp.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260812201121.2012356-1-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 8/12/26 13:11, Vladimir Oltean wrote: > The blamed commit replaced "return ret" statements in b53_fdb_dump() > with "break;" which jumps to the mutex_unlock() -> return 0 section. > > This is notably problematic because it swallows errors from the > b53_fdb_copy() -> cb() path, and this will result in FDB dump truncation > when the netlink skb overflows - see commit 21b52fed928e ("net: dsa: > sja1105: fix broken backpressure in .port_fdb_dump"). > > Let's go back to "return ret". We don't need to preinitialize "ret" with > 0, because the "do {} while" block guarantees we cannot reach the end of > the function without at least once calling b53_arl_search_wait(), which > will have initialized ret to some valid value. > > Fixes: f7eb4a1c0864 ("net: dsa: b53: serialize access to the ARL table") > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian