mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>, vkoul@kernel.org
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
	srk@ti.com
Subject: Re: [PATCH] dmaengine: ti: k3-udma: Enable second resource range for BCDMA and PKTDMA
Date: Wed, 19 Feb 2025 17:24:10 +0200	[thread overview]
Message-ID: <bab71a0a-bc4c-4ec1-9db8-0d9153da505c@gmail.com> (raw)
In-Reply-To: <20250205121805.316792-1-s-vadapalli@ti.com>



On 05/02/2025 14:18, Siddharth Vadapalli wrote:
> The SoC DMA resources for UDMA, BCDMA and PKTDMA can be described via a
> combination of up to two resource ranges. The first resource range handles
> the default partitioning wherein all resources belonging to that range are
> allocated to a single entity and form a continuous range. For use-cases
> where the resources are shared across multiple entities and require to be
> described via discontinuous ranges, a second resource range is required.
> 
> Currently, udma_setup_resources() supports handling resources that belong
> to the second range. Extend bcdma_setup_resources() and
> pktdma_setup_resources() to support the same.

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>  drivers/dma/ti/k3-udma.c | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 7ed1956b4642..b223a7aacb0c 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -4886,6 +4886,12 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>  				irq_res.desc[i].start = rm_res->desc[i].start +
>  							oes->bcdma_bchan_ring;
>  				irq_res.desc[i].num = rm_res->desc[i].num;
> +
> +				if (rm_res->desc[i].num_sec) {
> +					irq_res.desc[i].start_sec = rm_res->desc[i].start_sec +
> +									oes->bcdma_bchan_ring;
> +					irq_res.desc[i].num_sec = rm_res->desc[i].num_sec;
> +				}
>  			}
>  		}
>  	} else {
> @@ -4909,6 +4915,15 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>  				irq_res.desc[i + 1].start = rm_res->desc[j].start +
>  							oes->bcdma_tchan_ring;
>  				irq_res.desc[i + 1].num = rm_res->desc[j].num;
> +
> +				if (rm_res->desc[j].num_sec) {
> +					irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
> +									oes->bcdma_tchan_data;
> +					irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
> +					irq_res.desc[i + 1].start_sec = rm_res->desc[j].start_sec +
> +									oes->bcdma_tchan_ring;
> +					irq_res.desc[i + 1].num_sec = rm_res->desc[j].num_sec;
> +				}
>  			}
>  		}
>  	}
> @@ -4929,6 +4944,15 @@ static int bcdma_setup_resources(struct udma_dev *ud)
>  				irq_res.desc[i + 1].start = rm_res->desc[j].start +
>  							oes->bcdma_rchan_ring;
>  				irq_res.desc[i + 1].num = rm_res->desc[j].num;
> +
> +				if (rm_res->desc[j].num_sec) {
> +					irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
> +									oes->bcdma_rchan_data;
> +					irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
> +					irq_res.desc[i + 1].start_sec = rm_res->desc[j].start_sec +
> +									oes->bcdma_rchan_ring;
> +					irq_res.desc[i + 1].num_sec = rm_res->desc[j].num_sec;
> +				}
>  			}
>  		}
>  	}
> @@ -5063,6 +5087,12 @@ static int pktdma_setup_resources(struct udma_dev *ud)
>  			irq_res.desc[i].start = rm_res->desc[i].start +
>  						oes->pktdma_tchan_flow;
>  			irq_res.desc[i].num = rm_res->desc[i].num;
> +
> +			if (rm_res->desc[i].num_sec) {
> +				irq_res.desc[i].start_sec = rm_res->desc[i].start_sec +
> +								oes->pktdma_tchan_flow;
> +				irq_res.desc[i].num_sec = rm_res->desc[i].num_sec;
> +			}
>  		}
>  	}
>  	rm_res = tisci_rm->rm_ranges[RM_RANGE_RFLOW];
> @@ -5074,6 +5104,12 @@ static int pktdma_setup_resources(struct udma_dev *ud)
>  			irq_res.desc[i].start = rm_res->desc[j].start +
>  						oes->pktdma_rchan_flow;
>  			irq_res.desc[i].num = rm_res->desc[j].num;
> +
> +			if (rm_res->desc[j].num_sec) {
> +				irq_res.desc[i].start_sec = rm_res->desc[j].start_sec +
> +								oes->pktdma_rchan_flow;
> +				irq_res.desc[i].num_sec = rm_res->desc[j].num_sec;
> +			}
>  		}
>  	}
>  	ret = ti_sci_inta_msi_domain_alloc_irqs(ud->dev, &irq_res);

-- 
Péter


  reply	other threads:[~2025-02-19 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 12:18 Siddharth Vadapalli
2025-02-19 15:24 ` Péter Ujfalusi [this message]
2025-03-10 21:06 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bab71a0a-bc4c-4ec1-9db8-0d9153da505c@gmail.com \
    --to=peter.ujfalusi@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®