From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3DDEB64D9 for ; Thu, 6 Jul 2023 07:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233931AbjGFHxe (ORCPT ); Thu, 6 Jul 2023 03:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjGFHxc (ORCPT ); Thu, 6 Jul 2023 03:53:32 -0400 X-Greylist: delayed 414 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 06 Jul 2023 00:53:31 PDT Received: from out-32.mta0.migadu.com (out-32.mta0.migadu.com [91.218.175.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 923061BE4 for ; Thu, 6 Jul 2023 00:53:31 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688629593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mSFPEWACQpchhembCD7557WcJ8CIvjd+YhpuCa5eWqc=; b=ba7U0BSKt4uErWaG6b2V1oRqFQQBHmB2BivIVGnrj1HW+43NEnz/olQ6k7Mi2mqSzlAqSq ejUH2qVH67rYE/yS+Eryyn+v+iqYXv8+2eRQ2d75OUYXE85IxSmxY23/iTA18oh0WQokEf MbKxX8QobiIs68j12M+Dw34ZH06YpJo= Date: Thu, 6 Jul 2023 15:46:23 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah() To: Minjie Du , Mustafa Ismail , Shiraz Saleem , Jason Gunthorpe , Leon Romanovsky , "open list:INTEL ETHERNET PROTOCOL DRIVER FOR RDMA" , open list Cc: opensource.kernel@vivo.com References: <20230706022704.1260-1-duminjie@vivo.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20230706022704.1260-1-duminjie@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/7/6 10:27, Minjie Du 写道: > Delete a duplicate statement from this function implementation. > Please add "Fixes ". Zhu Yanjun > Signed-off-by: Minjie Du > --- > drivers/infiniband/hw/irdma/verbs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c > index 9c4fe4fa9..a8326a95d 100644 > --- a/drivers/infiniband/hw/irdma/verbs.c > +++ b/drivers/infiniband/hw/irdma/verbs.c > @@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr) > ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos; > ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl; > ah_attr->grh.sgid_index = ah->sgid_index; > - ah_attr->grh.sgid_index = ah->sgid_index; > memcpy(&ah_attr->grh.dgid, &ah->dgid, > sizeof(ah_attr->grh.dgid)); > }