From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbeDIN4v (ORCPT ); Mon, 9 Apr 2018 09:56:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:47129 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbeDIN4u (ORCPT ); Mon, 9 Apr 2018 09:56:50 -0400 Subject: Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION To: Johannes Thumshirn , "Martin K . Petersen" Cc: Linux Kernel Mailinglist , Linux SCSI Mailinglist , Bart Van Assche , Himanshu Madhani References: <20180409123922.854-1-jthumshirn@suse.de> From: Hannes Reinecke Organization: SUSE Linux GmbH Message-ID: Date: Mon, 9 Apr 2018 15:56:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180409123922.854-1-jthumshirn@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2018 02:39 PM, Johannes Thumshirn wrote: > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. > > Signed-off-by: Johannes Thumshirn > Reported-by: Bart Van Assche > Cc: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_isr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 49d67e1d571f..ed6cdfea00b4 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2195,7 +2195,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) > 0x10, 0x1); > set_driver_byte(cmd, DRIVER_SENSE); > set_host_byte(cmd, DID_ABORT); > - cmd->result |= SAM_STAT_CHECK_CONDITION << 1; > + cmd->result |= SAM_STAT_CHECK_CONDITION; > return 1; > } > > @@ -2205,7 +2205,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) > 0x10, 0x3); > set_driver_byte(cmd, DRIVER_SENSE); > set_host_byte(cmd, DID_ABORT); > - cmd->result |= SAM_STAT_CHECK_CONDITION << 1; > + cmd->result |= SAM_STAT_CHECK_CONDITION; > return 1; > } > > @@ -2215,7 +2215,7 @@ qla2x00_handle_dif_error(srb_t *sp, struct sts_entry_24xx *sts24) > 0x10, 0x2); > set_driver_byte(cmd, DRIVER_SENSE); > set_host_byte(cmd, DID_ABORT); > - cmd->result |= SAM_STAT_CHECK_CONDITION << 1; > + cmd->result |= SAM_STAT_CHECK_CONDITION; > return 1; > } > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)