From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39643222D52 for ; Thu, 12 Dec 2024 15:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734018476; cv=none; b=D3sv8HBIt602Qw5ogG9EavxJVhXpJwtVR2ppvL+FvAozF7aneZQz5BQyZJs2rxPxXDWt104wfhBTp/yI6AaczH146gUlRZl6t5mJ0FXB0lBbM6D8Z91vJBnxp2VbhP9tmJzdyFKdoy5/FMr0LNUu+z6dMqadkrTUBecHMHFDR0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734018476; c=relaxed/simple; bh=JRUrY4w4rGls/uJtVfSS19+b5gWlwP+rEoxccPnxBto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IpYfEiPgCMonHKlBdEpMzlWdV2q9EnHNtf0TJPd4fWC1DHqjplOirF3DQBf4I+i+0qydsQ7AV6wbGi7wAtyu2VtBOCObS/2k2oLJm0xWNfCA2ij6DnlbuJM5XxloD01d1OibLjPvs7o0gP27uY9BaZbnBjbNpmyEnEbXGJ250WQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PSf2LJFP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PSf2LJFP" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BC7juMd003235 for ; Thu, 12 Dec 2024 15:47:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8eLOXkCeC0DlQZVU51a+KZOt4UMu9djdUd60zKv59H8=; b=PSf2LJFPyGwGPl91 Yn+u/JqMOWQDfjTj0tW1z1xXBA0Y7dPxpR+t9SKZu7MI14w3rI1WohqnImIZ1sAV ul3Iziqstscrkd30PH6Ob/1cvX8wSi8503vDlHlz2h4K+cIOerGkqXH0+HXAaCK1 vlkEJ2IXkz3xYBJFKb71SSFxTOs1sGQN08a1mmZYn9IzT8lpy6VrI2E1/m0gDUBM xZAYZxl2RTESRj9ndv7zbozC9E4Kpjz3BZfZb27aIUp84MJr/CNApWYYVzyjbcpl Nk9viNrip8qmNYi7ZlxMPPink6Xs7d8b8kc7WBd61ud9c4DXAYSnGgNM31Xah4ST 2pdkeQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43f0r9wx9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 Dec 2024 15:47:53 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4679d6f9587so1404011cf.1 for ; Thu, 12 Dec 2024 07:47:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734018473; x=1734623273; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8eLOXkCeC0DlQZVU51a+KZOt4UMu9djdUd60zKv59H8=; b=ayhfSy7dh1FVf37TYtfTipFlo1uBCwflVANAS7LpOGIwQdl2Rg/vpNvvdgY7bwAjV1 M7lyNgIqCd/rAUHR+eKm1wNszA/+FXNbf4V7wt0mqPw5UZ6pYhu8KSbmQ89CDEAD9dTP zM4882DL1wN9u+DOAAwaLi2bddTCSVzu+C2kaPCnxW8UKrAjO0jBzoDrPrMGEZh6B0or s4khrN5p0eoU4Mksq1xLYyfCcqEOEfG8zrbH6VzvmwUu1Hb5VS+sC2kbNjSHFNiJNk0C 5Jf/X4i4TAePrqr8TFw/72I7396XurSwZywllXIC35swGk9PY+/WNvm99HUHYMglDTk4 1xQQ== X-Forwarded-Encrypted: i=1; AJvYcCUBO6x2as4wxx5dzsJKnjTFY74kb3Lx/5Vb4kzHeAJi7UJjyEff8Baek+kCfdt644/YqUOVh7ply0k9/bI=@vger.kernel.org X-Gm-Message-State: AOJu0YwovhEhhG9eNHURL4Ql6XMbHa3cyycHeY0NZTl8ftCXVrY0N+Q8 20B7g0CWW3/lzJBdYOJFfBe001oDONFEIeKaobxVT8YnHS99CHmALOmt8RAj4XeBRca5IH80RyD 1GaPqQzoMesMNLSD+LjWYQZWxMF3w1BCp5W0xwxRc/DtFL1I4ZiYICaRvfsQFkvk= X-Gm-Gg: ASbGnctNo4cDpnlLlfgCZvSQhTQQdgvmdweonW3fy2o/+0Sxy/nvAKrm1Iql1gXSaS3 wp6a4wVen/tMDIhyj7j4hcDseWzw+epZipkOlIr/YdG9ZkVCNgPhzUpMS6Llr1GnNFmXjfvLHiJ b61Ch1gBZpzYmblxon8sKhPU4N/oZluKo0iYKZgPKT2WJVl84qx+K11DBQ26mSxPK/NFlsN3YNn RCZNOBBvHinJd3jWhLheXoLcUIgfawNuI9zBBi7A5pmJxh5kqtigZGuEYd1Yvjo8gX41WZJ+/y/ DXS6Im2O6FS/g/KwjkkTrCJC5qdHE/fJ6JXlvw== X-Received: by 2002:a05:622a:a:b0:464:9faf:664b with SMTP id d75a77b69052e-467a14cfd41mr3889151cf.2.1734018473232; Thu, 12 Dec 2024 07:47:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXwZ9ATJawzq2/gDuuZrX3rouLOdXBu6sOMLvS2WbAH7jQqNN/imbNCFi/63dfoNHWb1jKmg== X-Received: by 2002:a05:622a:a:b0:464:9faf:664b with SMTP id d75a77b69052e-467a14cfd41mr3888991cf.2.1734018472938; Thu, 12 Dec 2024 07:47:52 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d149a25cdcsm10493167a12.9.2024.12.12.07.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 07:47:52 -0800 (PST) Message-ID: Date: Thu, 12 Dec 2024 16:47:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies To: Johan Hovold , Marc Zyngier , Sibi Sankar Cc: Stephan Gerhold , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Xilin Wu , Abel Vesa , Dmitry Baryshkov , Aleksandrs Vinarskis , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241210-x1e80100-usb-qmp-supply-fix-v1-0-0adda5d30bbd@linaro.org> <86ttbbsm69.wl-maz@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: lgagD3zquq_LQF7pPX1Ml5MddErd93wQ X-Proofpoint-GUID: lgagD3zquq_LQF7pPX1Ml5MddErd93wQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 mlxlogscore=971 malwarescore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412120114 On 10.12.2024 4:38 PM, Johan Hovold wrote: > On Tue, Dec 10, 2024 at 01:27:26PM +0000, Marc Zyngier wrote: >> On Tue, 10 Dec 2024 13:18:20 +0000, >> Johan Hovold wrote: >>> >>> On Tue, Dec 10, 2024 at 10:07:31AM +0100, Stephan Gerhold wrote: >>>> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 >>>> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 >>>> are actually powered by &vreg_l2j_1p2. >>>> >>>> Since most X1E device trees just mirror the power supplies from the >>>> x1e80100-crd device tree, this series fixes up all the X1E boards with >>>> the same change. >>> >>> Nice find! I've confirmed that this matches both the CRD and T14s >>> schematics. >> >> Can someone with access to the schematics confirm that the devkit >> indeed has the same supplies? > > Sibi, can you confirm our assumption that these definitions were copied > from the CRD devicetree and need to be fixed like this also for the > devkit? I can confirm the fix applies to devkit too. Konrad