From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5287DC35DF2 for ; Tue, 25 Feb 2020 05:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A01324683 for ; Tue, 25 Feb 2020 05:03:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WP0isu4k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgBYFDR (ORCPT ); Tue, 25 Feb 2020 00:03:17 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:58394 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725783AbgBYFDQ (ORCPT ); Tue, 25 Feb 2020 00:03:16 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 01P53C1f053677; Mon, 24 Feb 2020 23:03:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1582606992; bh=pqg8FMYGRN98RoiwIVfqMq71IWxG8ilSU9xMVrDRDU4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=WP0isu4kmKs2Xtfsehs+mrAG6MNoAX7JPso+ly2t3q7pNtKR5qxtxpF2a9XKqXd23 SWDQMjswsCu7KNYGlUmD+McRBqC1NOVXkDqR95mNznN5rUDYYZaCkI6FGnX53p4CWZ Kb0Ck8LCIfa1D7sE+S97DA1ElCoMOLj+i429Yspg= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 01P53C6t062869 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 24 Feb 2020 23:03:12 -0600 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Mon, 24 Feb 2020 23:03:12 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Mon, 24 Feb 2020 23:03:12 -0600 Received: from [10.24.69.20] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 01P539bC016936; Mon, 24 Feb 2020 23:03:10 -0600 Subject: Re: [PATCH 2/4] pwm: omap-dmtimer: Fix pwm enabling sequence To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= CC: Thierry Reding , Tony Lindgren , Linux OMAP Mailing List , , , Sekhar Nori References: <20200224052135.17278-1-lokeshvutla@ti.com> <20200224052135.17278-3-lokeshvutla@ti.com> <20200224084956.wwsnf2y24ragg3vf@pengutronix.de> From: Lokesh Vutla Message-ID: Date: Tue, 25 Feb 2020 10:32:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20200224084956.wwsnf2y24ragg3vf@pengutronix.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On 24/02/20 2:19 PM, Uwe Kleine-König wrote: > On Mon, Feb 24, 2020 at 10:51:33AM +0530, Lokesh Vutla wrote: >> To configure DM timer is pwm mode the following needs to be set in >> OMAP_TIMER_CTRL_REG using set_pwm callback: >> - Set toggle mode on PORTIMERPWM output pin >> - Set trigger on overflow and match on PORTIMERPWM output pin. >> - Set auto reload >> >> This is a one time configuration and needs to be set before the start of >> the dm timer. But the current driver tries to set the same configuration >> for every period/duty cycle update, which is not needed. So move the pwm >> setup before enabling timer and do not update it in pwm_omap_dmtimer_config. > > Is this change kind of moot with the conversion to .apply in the next > patch? Yes, but I didn't want to club it with the conversion to .apply as this is functional change wrt to the existing driver. Thanks and regards, Lokesh