From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomasz Figa <tfiga@chromium.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] media: vb2: frame_vector.c: replace WARN_ONCE with a comment
Date: Thu, 17 Aug 2023 17:02:31 +0200 [thread overview]
Message-ID: <bacb37eb-16ab-4643-bc67-9ecd9f21f4fc@xs4all.nl> (raw)
In-Reply-To: <CAHk-=wgR3JSopXha1pJh4dRDH-U+jHgqp1zy1nR8OovUQTJgWw@mail.gmail.com>
On 17/08/2023 16:56, Linus Torvalds wrote:
> On Thu, 17 Aug 2023 at 12:41, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>>
>> There are no reports of WARN_ONCE being issued for actual VM_IO cases, so
>> just drop it and instead add a note to the comment before the function.
>
> Ack. That was meant to catch any (unlikely) strange users, but yeah,
> it can obviously be triggered by "intentional" strange users, ie
> syzbot and friends, so since there seems to be no sign of actual
> real-world use, just removing the WARN_ONCE() is the right thing to
> do.
>
> I'm assuming I'll get this eventually through the regular media pulls?
>
> Linus
Yes, that's the plan.
Regards,
Hans
prev parent reply other threads:[~2023-08-17 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 10:41 Hans Verkuil
2023-08-17 11:21 ` David Hildenbrand
2023-08-17 11:41 ` Hans Verkuil
2023-08-17 14:56 ` Linus Torvalds
2023-08-17 15:02 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bacb37eb-16ab-4643-bc67-9ecd9f21f4fc@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=david@redhat.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tfiga@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®