From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B1A921171F for ; Fri, 10 Jan 2025 15:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736523448; cv=none; b=s1uvgeSMU7wSM60cmU7nH1AC7RpD+Maae3lYT4RiKwWrPOtELXRw2Y8u2xpoh8SRCvXqBeTDlUEJ+NgBUSzTMuqNzt6YKyBnPryUVBJDAgfLrEC9inSHYdHDsuljeTSS2bUiKJprXnFpYqD2IRHFczGDZkS7DGYUzbuLfKTuuBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736523448; c=relaxed/simple; bh=NxsyjlRY9eSv8Bx7MvUzChCQ40psdT0zMm//ImIxtL4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RHpJ1goQCLwnyCpB18ExGG98DG06e0Gz8CPRJIJ4aiovnDaq/bTJCiiC4gmCn5a+kYXpPNCg7oiOcsew8a28r31vy7/mB0g88KxDedPUMN+jT4FjUYhKK/4Es+P8AFstAxsAVYrbaXIwPs8snZrnskdCiGeLA0VgTrZ3tk2umkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=bygqjHMj; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="bygqjHMj" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e22b2387cso1378949a34.3 for ; Fri, 10 Jan 2025 07:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736523443; x=1737128243; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GFjmL4vQsZVXEWCgmHUIpNa6KkGBfMf79YAzsQMd3fo=; b=bygqjHMj0U+UyZxXrBALClkJy1VLnq4ZZNCmxbj8QEgZWV9q8H08qpPS1jd0a1Cdp5 tBDJhNnKH6RvHlt2NIxwzWSdIrlVHSMnzharTNzbKmvw2i0j98tAYCeuWd0vqkDBykkP K2h4yM5WwCF98hEs4daYFweO75dRXHtN4SRKFodbziZPUrCgTkxgbdiHUMP/THQBCXKO hPYJmeijyWK6B7OGev0S/IvLrLOhMVvkYYZjjOXDDd64BGfdZB1Ayo+g+OFj8u+/XI3S PUasF2J/4aIR6qCq8DfEcR5RY0opPZHS3/KxDDoACDLpeGKvT+hW0K4Fc29RNpuo77aI MoPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736523443; x=1737128243; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GFjmL4vQsZVXEWCgmHUIpNa6KkGBfMf79YAzsQMd3fo=; b=BdfIIvYuMV7lgpl4/xaT5mMdNrUADy6Wfdsf+drqmFukdAkRia2bQIeKAUY8hC2+sZ XVzmVB70ISBpKUyBSU3I3NrDN4HIHX/IDER9qZ6+5WAKtBh89NBzhA9N1NkZ8EWxci6p V00XWAjStCnLiQrf/XqMEoSvJdMOSD0LkMVGO/bBzf2vnbVFl5UJd2nXTtjJMa7IIC96 Ltf4esPV9tzR7hdp903e8FQHDCHzxbZoApSZmP+DIVXGkFcNoK2eZgR/Ta5B37MA0KGB cQLUS26gPtAEem+YbFKlinDGSR0X6bzpJytOZMJHaI9tCcJFwc7Og7vQicfk22yWCPHN EycA== X-Forwarded-Encrypted: i=1; AJvYcCUm0QK8K+y1Ahqc1L07XnNG3iin4H5Pv8S6xksmtlVtaaUs82VVWzHCEFGwbVFh8EWxoqumelqAYELlsVo=@vger.kernel.org X-Gm-Message-State: AOJu0YyMqJjxyAhQtRm3AIGoThq3d6lpO4tFwzMBRnqREY7ts7oPh1HU 5vHseuIQUz1OHEOgvPSzo5jSb9hWZAavTdP9IC/V4rNwmSs/39qWfb0YtUjYT18= X-Gm-Gg: ASbGncuvjKCHs4DjTUchrcWATF1rCIuwHewkF6HHpQ7aSX40q7/lG6tNnUpRPyAe52p YlJnldI77iB8nhw95BY50n2PjLQLweoOrNSQBgSElsTmodmJ8HCMCfb1dzfogdRQSyt+jdBzvHL bFICq76J+86mAr4LN8KMVCe3tXm47EmIgl3dp0UONx0kMvoIowsWk2gbTszujXvEZsrNIu5Fh2J s6bQMD1XPwFP+c0V5no77pVP6QtIHwNEm7P1Z5pPAGi7dhGgbujW6vDHe6JuFUDd3GyaMhvOZtq o2pE+lM7fkpy0a57Dw== X-Google-Smtp-Source: AGHT+IHrjb11VqIowNyTP1M1tANhFfhWQDQanAzhT94jxSFIb5jVokyRlUAmdyDcUP7GamU0aj/AJg== X-Received: by 2002:a05:6830:670f:b0:71d:63fc:2ea6 with SMTP id 46e09a7af769-721e2e3103fmr7591412a34.8.1736523443621; Fri, 10 Jan 2025 07:37:23 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7231862a20asm876790a34.65.2025.01.10.07.37.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 07:37:22 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 09:37:20 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] iio: dac: ad3552r-hs: use instruction mode for configuration To: Angelo Dureghello , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Nuno Sa Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250110-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v3-0-ab42aef0d840@baylibre.com> <20250110-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v3-6-ab42aef0d840@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: <20250110-wip-bl-ad3552r-axi-v0-iio-testing-carlos-v3-6-ab42aef0d840@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/10/25 4:24 AM, Angelo Dureghello wrote: > From: Angelo Dureghello > > Use "instruction" mode over initial configuration and all other > non-streaming operations. > > DAC boots in streaming mode as default, and the driver is not > changing this mode. > > Instruction r/w is still working becouse instruction is processed s/becouse/because/ > from the DAC after chip select is deasserted, this works until > loop mode is 0 or greater than the instruction size. > > All initial operations should be more safely done in instruction > mode, a mode provided for this. > > Signed-off-by: Angelo Dureghello > --- > drivers/iio/dac/ad3552r-hs.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/iio/dac/ad3552r-hs.c b/drivers/iio/dac/ad3552r-hs.c > index 27949f207d42..991b11702273 100644 > --- a/drivers/iio/dac/ad3552r-hs.c > +++ b/drivers/iio/dac/ad3552r-hs.c > @@ -132,6 +132,13 @@ static int ad3552r_hs_buffer_postenable(struct iio_dev *indio_dev) > return -EINVAL; > } > > + /* Primary region access, set streaming mode (now in SPI + SDR). */ > + ret = ad3552r_qspi_update_reg_bits(st, > + AD3552R_REG_ADDR_INTERFACE_CONFIG_B, > + AD3552R_MASK_SINGLE_INST, 0, 1); > + if (ret) > + return ret; Do we need to undo this operation before we return in the case of an error later in this function? > + > ret = st->data->bus_reg_write(st->back, AD3552R_REG_ADDR_STREAM_MODE, > loop_len, 1); > if (ret)