From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18E97C433E0 for ; Tue, 30 Jun 2020 01:02:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E33E12078A for ; Tue, 30 Jun 2020 01:02:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fEBFm8o8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727789AbgF3BCi (ORCPT ); Mon, 29 Jun 2020 21:02:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgF3BCi (ORCPT ); Mon, 29 Jun 2020 21:02:38 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E071DC03E979 for ; Mon, 29 Jun 2020 18:02:37 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id l9so16190882ilq.12 for ; Mon, 29 Jun 2020 18:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XeuAEJ6F4qGbUXxI3k7ZEhXMPuXG1rflAk7Rajdg7vc=; b=fEBFm8o8Xd0YzPQyeY9SaA872zwIod+qVof7Ablh9IF29NSS9oDY203eC7GBqGb0br gzAmC+uDgwy6EBBd0x9dt2p7NyTFZ4e7IudoVWp5+x2CpRb3R5svfA17dPLQzOeTxyTr ks+2qxSSeXIpU+HlIwuYRhymluxxx8HUORPaJwLl1zN/7Rxe0o0XJQ6c8UT4RIWQYe2G wweV/I8TOKrslqueyDf/49VXtpmsL06/vW9s8eph3pfQOzIGfyQx7nuld7tTJ7B6Hv1F SgwwkmE64vpHjJLB03iahhJXGv7aulyQrftY9KcPCUJd1Ir0uIbIiXRpG+eH5K7pRVei 0Lbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XeuAEJ6F4qGbUXxI3k7ZEhXMPuXG1rflAk7Rajdg7vc=; b=XjFk2WpvRz0u0A+OdDBv3VpJs/G7ubL8AX0KOPJZID7DU0PrEwOkLRZWXHzytes/Of N2cdouqe7WW2dwUTANeA403UyY7lJfMqZFZl70SEIMaulKlRGnWFvkv+CROKohN8WItG VjYUvZluM0DraRP9fxh6K23ASNL6soaie3n/oSl4xqVYp5HLTxLDxsloGM2Jf7iEdDl9 XmN5+C9jrNLUbsNW61jHoTsGWiwk+3fzrLGM5BAJkX0XQABp+7HlPAq5eKNNas9V0TkG LodjU6tUZxONNxD0Ryn8wY0wgJu5hb8naS9+xcTG1KLSQ6HvgpX+/3qiCD+ZrNT86CyS RDbw== X-Gm-Message-State: AOAM530JnlscAAzol8bMyP1iNJCdcn9Csfr69gcGwWeZsj6cW20i+N1z 4K/CKIEwFGo3FEygc3KonpA9srO1OaQ= X-Google-Smtp-Source: ABdhPJx9186hwjMiBQNNLPoIbe4pAfgxSYxb9AWbMLIA6uTup2bfwKI2mKj6DW6FN4b2yDKuUD5N/Q== X-Received: by 2002:a92:bb57:: with SMTP id w84mr248609ili.104.1593478957059; Mon, 29 Jun 2020 18:02:37 -0700 (PDT) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id s12sm908503ilk.58.2020.06.29.18.02.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 18:02:36 -0700 (PDT) Subject: Re: [PATCH net 2/3] net: ipa: no checksum offload for SDM845 LAN RX To: Jakub Kicinski Cc: davem@davemloft.net, evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200629212038.1153054-1-elder@linaro.org> <20200629212038.1153054-3-elder@linaro.org> <20200629171046.4b3ed68c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Alex Elder Message-ID: Date: Mon, 29 Jun 2020 20:02:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200629171046.4b3ed68c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/20 7:10 PM, Jakub Kicinski wrote: > On Mon, 29 Jun 2020 16:20:37 -0500 Alex Elder wrote: >> The AP LAN RX endpoint should not have download checksum offload >> enabled. >> >> The receive handler does properly accomodate the trailer that's >> added by the hardware, but we ignore it. >> >> Signed-off-by: Alex Elder > > For this net series - would you mind adding Fixes tags to each patch? Yes. That hasn't been my practice in the past; I guess I'll add it to my checklist... I will fix the spelling error in version 2. -Alex > > Also checkpatch sayeth: > > WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? > #10: > The receive handler does properly accomodate the trailer that's >