From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0446137C929 for ; Tue, 18 Aug 2026 06:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787036359; cv=none; b=lMzvCTB+USbbwdBYe6nNzYvcbzxV6muFoMxpRQf0p6air9cjYn5Fov9KSjy+cOAKLt1LXLzTQSTbTTOy/kjr7FGI7OkSpomoSonPAtISah+n7+rJeFYlqI4UPrstPCijbuwW2+Ku3kOZYxmFNbQqCo4oHatwUt/edM5IPypxKRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787036359; c=relaxed/simple; bh=Lo9Dnt2y/TMGSSskmCCw/E68ISLvoXSSWMqfmsWr4W4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bl3m/p9PyiRCVMvYZbhFHExq5GorEkl68B6p2WthxsqZNy67vVQ7dwEohuqKCycu/mqflc3/Y2BPcj39vxTCLDDQaaDC3NKzYDGG7U4Pj7UgUrKuCiNQcbssvkpn/8ZGeHom4Lrmb8sZt8srMqR0dbLvrNKShPs9ENVhI0nEtDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/qJj9Tb; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/qJj9Tb" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so54067505ad.1 for ; Mon, 17 Aug 2026 23:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787036357; x=1787641157; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=EsgqEQAUqrVWXU1GldXAhQw/hCdlChW/NiKf+A/QTHM=; b=K/qJj9TbqgJIQQyPUVfyJ91r2dc4GyrA13mhJYIyUJApa1JmjYsdYrZa5pKOHJmFl8 rXF7ub+jJVk8iCi6ZYonZZwPJKLffwSWwLXr3l2BC+QmKvUTFisz4BVFjHTO2qmxrASD folm+hRObzREp7uz5hE1rdjvKA50Lyl+0Mq/O9UCUOd9Xa7/ZDv5iejp/Ibh0M4UPmDR LhETIae7nLCGdivTyRT3A91lnA3dlHGbI1w2dBh+dgGzK3EajU8m6f7qnxIt7RzLGfVg 9xBpxaWI8K47ntdL3pzJnggjPNU7HDAKodWt4vZwjqvee1DMFdOtL94q8C5efFL8rTQX ziLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787036357; x=1787641157; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EsgqEQAUqrVWXU1GldXAhQw/hCdlChW/NiKf+A/QTHM=; b=NRUKJIdnFUcbIAjdhhBYG8WKLULCOMcxxB0daNF+QNPqCmZQBftuTnyT2J8MsjLDex dIzVo6zQpBmkgj8LV2qnlNL7cS0UXessY1fi31kh57uNy/Lam0o7LbEf9mrt0cno5bts R0DmxMoSrGnOrtAIfTjC6A4gnAkEe/nlCXXysOdvVmmaAAyY2Nb9tTvvkBBf4z/fME1Q D6WMP3RSYvQaSv/i1Ptx2UdZHnykhFY05sfIUz9kBL2D6b4HxBD2lcyfbtJyUKbA/Ab0 R3wn2jhjMVJMVUZbP5cP3COX8bdP0s6JZubzeWQ+QiskLJeokT1wmjJlDQEfqQ48E6nZ pkWw== X-Forwarded-Encrypted: i=1; AHgh+RqAKJkZU5bPO7S2mAyJMtVcghlnuznRUdqqgK4NCLZrWbFh5/zbCVHhoCzpmv1QcAOeP9rv3Dmos7ovDf8=@vger.kernel.org X-Gm-Message-State: AOJu0YyRJGeXVzXzQ9e6hB05dvt+sr6tEDduDr9Ee5A+gswkoYaQPFIs Ar5xYqLtqdlZpZ2aFHyZF1mmhWKoavqFCcTIJk+ya2TNbUUvO9sM11hD X-Gm-Gg: AR+sD11BL8WgyjsPRe80ndqrgLsaU/CsnEWdhFB8b9qrr7b4FqMIu6Yj53qHg2lfT5B mq/KaypdzCSJETp4C0sn4XPKHo0jL3KFBX97GDw9+cniCTXHfEqAHKh/tQh8yXX9By8RMCfh/Jc sO2THUde2whUoCs42eVu7kTfiKILad3X+NCHjyjSXSKkhcXEmZkECsF7jnYhe/Krm99aKF+zAAD juvTQ0tISO9Ieox3u8JoX/EOkdQJSPfvLs9N735rSxFY7AXFZh8GbyB4O1Us9xZUSBpXVHg4sXJ fOab9BxoxCQiJyQGvw/Em+fNUQVDTz9SNA23z1QenXALegX3+uZ0fB+QuBXavYgGl5PzNZv8+k2 Byb8Ug3zlpfXLAD+GBJkxQogHZQXv4iHLUtbiLkexOU3R6h/NmQY8miEZ82Yzrw8aWdKShmWJKX 6rj5ugOCWNV2d/6T0u4U0UkMODPffEEbl/Bx9GXVjHjh7he80FXWD7WqtV2BAb2Os9WB2zHfWt7 wZRMLeQVKL1E/U= X-Received: by 2002:a17:902:f548:b0:2ca:e565:7b15 with SMTP id d9443c01a7336-2d3b0874ce2mr279530695ad.10.1787036356990; Mon, 17 Aug 2026 23:59:16 -0700 (PDT) Received: from [100.82.107.240] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1e528b3sm10780415ad.46.2026.08.17.23.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 23:59:16 -0700 (PDT) Message-ID: Date: Tue, 18 Aug 2026 14:59:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ext4: reject delalloc to nodelalloc before applying remount options To: Ojaswin Mujoo Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, libaokun@linux.alibaba.com, jack@suse.cz, ritesh.list@gmail.com, yi.zhang@huawei.com, bretznic@gmail.com, stable@vger.kernel.org References: <20260814034855.1573759-1-guzebing1612@gmail.com> From: guzebing In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/14/26 3:41 PM, Ojaswin Mujoo wrote: > Can you please add an xfstests for this. The test can stress this path and > then use the _check_dmesg_for helper to detect if there were any > i_reserved_data_blocks related warnings. > > Regards, > ojaswin Hi Ojaswin, Thanks for the review. I have posted the corresponding fstests regression test here: https://lore.kernel.org/linux-ext4/20260818064023.2309786-1-guzebing1612@gmail.com/ The test stresses buffered write/truncate operations in parallel with the expected-failing remount,nodelalloc operation, and checks dmesg for leaked delayed allocation reservations during unmount. Locally, the test fails on an affected kernel with i_reserved_data_blocks not cleared warnings, and passes with this patch applied. Thanks, Guzebing