From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752239AbdEUI1m (ORCPT ); Sun, 21 May 2017 04:27:42 -0400 Received: from mout.web.de ([212.227.17.12]:63692 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdEUI1j (ORCPT ); Sun, 21 May 2017 04:27:39 -0400 Subject: [PATCH 3/3] zswap: Delete an error message for a failed memory allocation in zswap_dstmem_prepare() From: SF Markus Elfring To: linux-mm@kvack.org, Dan Streetman , Seth Jennings Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Message-ID: Date: Sun, 21 May 2017 10:27:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:QjYxzNSBVhIVIX20FQy8vtZkChbHv7iJCDsFyTzqHIfys7F4Sr7 EhReobO2U0VAYM0SSSjiF7hMFeEbNT4Xk25DRzwv4GOXbv/p70uwiGU13XnBmSTpscjYPZ3 HkgYSd25KELd42NXjfi0JKd9Y6i48IG8s2H8DxS/xEyv1vIe/xaowhq7DBcPY1a8y7h+RDK /cwm+RSERo+Ccy10Hvayg== X-UI-Out-Filterresults: notjunk:1;V01:K0:GyWuZjr40fI=:UZHX8xes/DAjNzUtr9HzJF sTAbfL/VF4PnQFU1k37k0QN1cGOQZVF/6MhidGMZW1WI0V9hJg719yVCo0ifOT1gPIh8BTl1K IpgZFk/wiiLDoFGKY1nEkleUF94JEebnQ8WqjCVp/TYOdsmlh7vp2Qf5bF5+EnRIp39c202hO XpAys43MHjA7BCvalXkDFYzeadjZBZSGL5TgnG/Ii7MzUm4ubBqeSS6ltKVSaaJ3zjm5IxrwA 0Pw1pCqYz+JXfeSHDNby8vSB33pXD5o8Ru/lJ+uaC8NARlcQpE50S2hp0JKtdxNal33sCmYtb cytjCptEB6SwyvXVQJBu8oaY4fMhyJVRFwT4Tml77S3it8FVqE6fDjaSg7NcvcJfqh8EkgJJs TSEtfkrclqbOx51YTjuqnk+H3PuWmsbL5J3/UP6myJuGOR6yeVHtAdDNSnIdB7jc253RDCSlD rBW4AXnYrNuPBsTJ48xzHVNujgERluIC0a/GN9Ths23dndgQApltOFU6LOKg/oixNaTXMI+DY g7GpmRMclRKVqvROKedsCZZDj1VLmr3JoDbLPMnZi6m4J/Y7IBU3q+ylesfLAn3nh2uleJkd/ ILHYNIADZa1Ykd1qZEUUOwRutrb+q1vJgkrGeYMloJRBHc9Dw/9nAwYZzM1vHQHB2Cs082VdM 503dj8DjK6u+W3f6gRkEIDl/5Vco8csMnVAHidEs/s0kBH2uPW0GOl7ikRes6VDC8JI77ybnA 6A+/DanNRHZn/oP2jYJDzwnAJSdD3jPJ59Oo8cvLOsUetKiF9z3etURiNBrIFl8I3nDrKgaWq F8MgpD1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 May 2017 09:29:25 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- mm/zswap.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index 3f0a9a1daef4..ed7312291df9 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -374,7 +374,6 @@ static int zswap_dstmem_prepare(unsigned int cpu) - if (!dst) { - pr_err("can't allocate compressor buffer\n"); + if (!dst) return -ENOMEM; - } + per_cpu(zswap_dstmem, cpu) = dst; return 0; } -- 2.13.0